You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by wc...@apache.org on 2020/04/23 10:05:15 UTC
[hbase] branch branch-2.2 updated: HBASE-23047
ChecksumUtil.validateChecksum logs an INFO message inside a
"if(LOG.isTraceEnabled())" block.
This is an automated email from the ASF dual-hosted git repository.
wchevreuil pushed a commit to branch branch-2.2
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-2.2 by this push:
new 45349ea HBASE-23047 ChecksumUtil.validateChecksum logs an INFO message inside a "if(LOG.isTraceEnabled())" block.
45349ea is described below
commit 45349eadfc60f5fb36b00185ae5616dd2647a80b
Author: Wellington Chevreuil <wc...@apache.org>
AuthorDate: Thu Sep 19 15:31:47 2019 +0100
HBASE-23047 ChecksumUtil.validateChecksum logs an INFO message inside a "if(LOG.isTraceEnabled())" block.
Signed-off-by: Peter Somogyi <ps...@apache.org>
(Cherry picked from commit a85c6b48672552136ead76a682458c884a558dc2)
---
.../org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java
index 5eb1826..1edf44a 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/ChecksumUtil.java
@@ -103,16 +103,11 @@ public class ChecksumUtil {
cktype.getDataChecksumType(), bytesPerChecksum);
assert dataChecksum != null;
int onDiskDataSizeWithHeader =
- buffer.getInt(HFileBlock.Header.ON_DISK_DATA_SIZE_WITH_HEADER_INDEX);
- if (LOG.isTraceEnabled()) {
- LOG.info("dataLength=" + buffer.capacity()
- + ", sizeWithHeader=" + onDiskDataSizeWithHeader
- + ", checksumType=" + cktype.getName()
- + ", file=" + pathName
- + ", offset=" + offset
- + ", headerSize=" + hdrSize
- + ", bytesPerChecksum=" + bytesPerChecksum);
- }
+ buffer.getInt(HFileBlock.Header.ON_DISK_DATA_SIZE_WITH_HEADER_INDEX);
+ LOG.trace("dataLength={}, sizeWithHeader={}, checksumType={}, file={}, "
+ + "offset={}, headerSize={}, bytesPerChecksum={}",
+ buffer.capacity(), onDiskDataSizeWithHeader, cktype.getName(),
+ pathName, offset, hdrSize, bytesPerChecksum);
try {
ByteBuffer data = (ByteBuffer) buffer.duplicate().position(0).limit(onDiskDataSizeWithHeader);
ByteBuffer checksums = (ByteBuffer) buffer.duplicate().position(onDiskDataSizeWithHeader)