You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Taewoo Kim (Code Review)" <do...@asterixdb.incubator.apache.org> on 2016/08/20 01:55:09 UTC
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Taewoo Kim has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/1094
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
ASTERIXDB-1186: fixed a composite primary index search issue.
- Providing only one field to a composite primary index search
now works properly by broadcasting search predicates to all nodes.
Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
---
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeJobGenParams.java
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.1.ddl.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.2.update.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.3.query.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.4.query.aql
A asterixdb/asterix-app/src/test/resources/runtimets/results/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.3.adm
A asterixdb/asterix-app/src/test/resources/runtimets/results/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.4.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M asterixdb/asterix-common/src/test/java/org/apache/asterix/test/aql/TestExecutor.java
13 files changed, 12,250 insertions(+), 24 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/94/1094/1
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 7:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2379/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Carey <dt...@gmail.com>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Taewoo Kim (Code Review)" <do...@asterixdb.incubator.apache.org>.
Taewoo Kim has submitted this change and it was merged.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
ASTERIXDB-1186: fixed a composite primary index search issue.
- Providing only one field to a composite primary index search
now works properly by broadcasting search predicates to all nodes.
Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1094
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Taewoo Kim <wa...@yahoo.com>
---
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java
M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_03.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_04.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_05.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_06.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_03.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_04.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_05.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_06.plan
M asterixdb/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv19/cross-dv19.3.query.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.1.ddl.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.2.update.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.3.query.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.4.query.aql
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.query.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/results/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.3.adm
A asterixdb/asterix-app/src/test/resources/runtimets/results/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.4.adm
M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.ast
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlIndex.java
20 files changed, 12,252 insertions(+), 66 deletions(-)
Approvals:
Taewoo Kim: Looks good to me, approved
Jenkins: Verified; No violations found; Verified
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Carey <dt...@gmail.com>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Michael Carey (Code Review)" <do...@asterixdb.incubator.apache.org>.
Michael Carey has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 6:
Looked at the code and plans - looks good to me. (Got a jump start in person during a meeting today that helped a lot.)
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Carey <dt...@gmail.com>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Taewoo Kim (Code Review)" <do...@asterixdb.incubator.apache.org>.
Taewoo Kim has uploaded a new patch set (#2).
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
ASTERIXDB-1186: fixed a composite primary index search issue.
- Providing only one field to a composite primary index search
now works properly by broadcasting search predicates to all nodes.
Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
---
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeJobGenParams.java
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.1.ddl.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.2.update.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.3.query.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.4.query.aql
A asterixdb/asterix-app/src/test/resources/runtimets/results/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.3.adm
A asterixdb/asterix-app/src/test/resources/runtimets/results/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.4.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
12 files changed, 12,245 insertions(+), 24 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/94/1094/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 7: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/452/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Carey <dt...@gmail.com>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 4:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2319/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 1:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2311/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Taewoo Kim (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1094
to look at the new patch set (#4).
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
ASTERIXDB-1186: fixed a composite primary index search issue.
- Providing only one field to a composite primary index search
now works properly by broadcasting search predicates to all nodes.
Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
---
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeJobGenParams.java
M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_03.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_04.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_05.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_06.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_03.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_04.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_05.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_06.plan
M asterixdb/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv19/cross-dv19.3.query.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.1.ddl.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.2.update.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.3.query.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.4.query.aql
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.query.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/results/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.3.adm
A asterixdb/asterix-app/src/test/resources/runtimets/results/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.4.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
22 files changed, 12,282 insertions(+), 71 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/94/1094/4
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Yingyi Bu (Code Review)" <do...@asterixdb.incubator.apache.org>.
Yingyi Bu has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 5:
(2 comments)
Obtain the index info (composite or not, number of fields from AqlIndex) in BTreeSearchOperator, such that other source files can stay unchanged.
https://asterix-gerrit.ics.uci.edu/#/c/1094/5/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java
File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java:
Line 84: this.isCompositeIndex = isCompositeIndex;
The detour from btreeJobGenParams to obtain isCompositeIndex and numberOfKeyFields seems awkward to me.
Can we directly obtain the information from idx (AqlIndex) in the if-block at line 154? E.g., add a private method in this class to obtain the info from idx.
Line 156: || (isCompositeIndex && (lowKeyVarList.size() == numberOfKeyFields)
remove isCompositeIndex in the right branch of "||"
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Taewoo Kim (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1094
to look at the new patch set (#5).
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
ASTERIXDB-1186: fixed a composite primary index search issue.
- Providing only one field to a composite primary index search
now works properly by broadcasting search predicates to all nodes.
Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
---
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeJobGenParams.java
M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_03.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_04.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_05.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_06.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_03.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_04.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_05.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_06.plan
M asterixdb/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv19/cross-dv19.3.query.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.1.ddl.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.2.update.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.3.query.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.4.query.aql
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.query.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/results/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.3.adm
A asterixdb/asterix-app/src/test/resources/runtimets/results/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.4.adm
M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.ast
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
23 files changed, 12,299 insertions(+), 71 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/94/1094/5
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Taewoo Kim (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1094
to look at the new patch set (#6).
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
ASTERIXDB-1186: fixed a composite primary index search issue.
- Providing only one field to a composite primary index search
now works properly by broadcasting search predicates to all nodes.
Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
---
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java
M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_03.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_04.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_05.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_06.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_03.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_04.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_05.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_06.plan
M asterixdb/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv19/cross-dv19.3.query.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.1.ddl.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.2.update.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.3.query.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.4.query.aql
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.query.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/results/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.3.adm
A asterixdb/asterix-app/src/test/resources/runtimets/results/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.4.adm
M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.ast
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlIndex.java
20 files changed, 12,252 insertions(+), 66 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/94/1094/6
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Taewoo Kim (Code Review)" <do...@asterixdb.incubator.apache.org>.
Taewoo Kim has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 5:
(2 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1094/5/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java
File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java:
Line 84: this.isCompositeIndex = isCompositeIndex;
> The detour from btreeJobGenParams to obtain isCompositeIndex and numberOfKe
Done
Line 156: || (isCompositeIndex && (lowKeyVarList.size() == numberOfKeyFields)
> remove isCompositeIndex in the right branch of "||"
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 6:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2362/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Taewoo Kim (Code Review)" <do...@asterixdb.incubator.apache.org>.
Taewoo Kim has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 7:
Forwarding Yingyi's +2 from the patch set 6 (just rebased)
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Carey <dt...@gmail.com>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 6: Integration-Tests-1
Integration Tests Failed
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/432/ : UNSTABLE
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 5: Integration-Tests+1
Integration Tests Successful
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/397/ : SUCCESS
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Taewoo Kim (Code Review)" <do...@asterixdb.incubator.apache.org>.
Taewoo Kim has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 2:
(3 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1094/2/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java
File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java:
Line 159: ListSet<LogicalVariable> searchKeyVars = new ListSet<LogicalVariable>();
> MAJOR SonarQube violation:
Done
Line 163: List<ILocalStructuralProperty> propsLocal = new ArrayList<ILocalStructuralProperty>();
> MAJOR SonarQube violation:
Done
Line 164: List<OrderColumn> orderColumns = new ArrayList<OrderColumn>();
> MAJOR SonarQube violation:
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-HasComments: Yes
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Taewoo Kim (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1094
to look at the new patch set (#3).
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
ASTERIXDB-1186: fixed a composite primary index search issue.
- Providing only one field to a composite primary index search
now works properly by broadcasting search predicates to all nodes.
Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
---
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/SetAsterixPhysicalOperatorsRule.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeAccessMethod.java
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/BTreeJobGenParams.java
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.1.ddl.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.2.update.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.3.query.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.4.query.aql
A asterixdb/asterix-app/src/test/resources/runtimets/results/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.3.adm
A asterixdb/asterix-app/src/test/resources/runtimets/results/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.4.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
12 files changed, 12,245 insertions(+), 24 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/94/1094/3
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Yingyi Bu (Code Review)" <do...@asterixdb.incubator.apache.org>.
Yingyi Bu has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 6:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2359/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 2:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2312/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 3:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2313/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Michael Carey (Code Review)" <do...@asterixdb.incubator.apache.org>.
Michael Carey has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 6:
NOTE: A number of the (optimizer only) test cases affected by this change were previously WRONG! I.e., we had WRONG PLANS (as in correctness wrong, not just performance wrong) checked in as the expected results. I wonder how many other cases might be like that. Scary..... I wonder if there's a need for an audit of the expected results in our optimizer test cases?
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Carey <dt...@gmail.com>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 6:
Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/432/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Michael Carey (Code Review)" <do...@asterixdb.incubator.apache.org>.
Michael Carey has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 6: Code-Review+1
Since I'm a novice reviewer, I won't +2 it, but I would if I had more confidence. :-)
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Carey <dt...@gmail.com>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 6:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2358/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Taewoo Kim (Code Review)" <do...@asterixdb.incubator.apache.org>.
Hello Michael Carey, Yingyi Bu, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/1094
to look at the new patch set (#7).
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
ASTERIXDB-1186: fixed a composite primary index search issue.
- Providing only one field to a composite primary index search
now works properly by broadcasting search predicates to all nodes.
Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
---
M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/BTreeSearchPOperator.java
M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_03.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_04.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_05.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/primary-composite-key-prefix-join_06.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_03.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_04.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_05.plan
M asterixdb/asterix-app/src/test/resources/optimizerts/results/nested-index/btree-index-join/primary-composite-key-prefix-join_06.plan
M asterixdb/asterix-app/src/test/resources/runtimets/queries/cross-dataverse/cross-dv19/cross-dv19.3.query.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.1.ddl.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.2.update.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.3.query.aql
A asterixdb/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.4.query.aql
M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.query.sqlpp
A asterixdb/asterix-app/src/test/resources/runtimets/results/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.3.adm
A asterixdb/asterix-app/src/test/resources/runtimets/results/index-selection/btree-index-composite-key-02/btree-index-composite-key-02.4.adm
M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/cross-dataverse/cross-dv19/cross-dv19.3.ast
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite.xml
M asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlIndex.java
20 files changed, 12,252 insertions(+), 66 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/94/1094/7
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Carey <dt...@gmail.com>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 5:
Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/397/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 5:
Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2320/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Jenkins (Code Review)" <do...@asterixdb.incubator.apache.org>.
Jenkins has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 7:
Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/452/
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Carey <dt...@gmail.com>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No
Change in asterixdb[master]: ASTERIXDB-1186: fixed a composite primary index search issue.
Posted by "Taewoo Kim (Code Review)" <do...@asterixdb.incubator.apache.org>.
Taewoo Kim has posted comments on this change.
Change subject: ASTERIXDB-1186: fixed a composite primary index search issue.
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit https://asterix-gerrit.ics.uci.edu/1094
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f75229ea804a02e7cacd04f7269a4907668eab0
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Carey <dt...@gmail.com>
Gerrit-Reviewer: Taewoo Kim <wa...@yahoo.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-HasComments: No