You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@curator.apache.org by "Jordan Zimmerman (JIRA)" <ji...@apache.org> on 2013/09/07 04:41:51 UTC

[jira] [Resolved] (CURATOR-51) LeaderSelector with custom Executor does not guarantee unique leadership

     [ https://issues.apache.org/jira/browse/CURATOR-51?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jordan Zimmerman resolved CURATOR-51.
-------------------------------------

    Resolution: Fixed

Taking a custom Executor and ThreadFactory wasn't thought through. It's actually useless. This constructor is now deprecated in favor of passing in an ExecutorService. The old version is wrapped internally so that it works as it used to. But, it will be removed in the near future.
                
> LeaderSelector with custom Executor does not guarantee unique leadership
> ------------------------------------------------------------------------
>
>                 Key: CURATOR-51
>                 URL: https://issues.apache.org/jira/browse/CURATOR-51
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Recipes
>    Affects Versions: 2.2.0-incubating
>            Reporter: Henrik Nordvik
>            Assignee: Jordan Zimmerman
>            Priority: Minor
>             Fix For: 2.2.1-incubating
>
>         Attachments: ZookeeperTest.java, ZookeeperTest.log
>
>
> When providing a custom executor to the leader selector it creates a thread that waits for leadership.
> When it has leadership, it submits a runnable to the custom executor and then release leadership. 
> If the executor is is e.g. a ThreadPoolExecutor, the takeLeadership method is executed asynchrounously, after releasing leadership.
> Is this a bug or am I missing the point of using my own executor?
> I have attached an example which shows multiple leaders being elected at the same time.
> (The example uses curator 1.3.3, but I think it is the same in 2.x)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira