You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/08 13:07:15 UTC
[GitHub] azagrebin commented on a change in pull request #7663:
[FLINK-11550][kinesis] Port manual tests
azagrebin commented on a change in pull request #7663: [FLINK-11550][kinesis] Port manual tests
URL: https://github.com/apache/flink/pull/7663#discussion_r255065397
##########
File path: flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/manualtests/ManualExactlyOnceWithStreamReshardingTest.java
##########
@@ -89,15 +90,17 @@ public static void main(String[] args) throws Exception {
}
final Configuration flinkConfig = new Configuration();
- flinkConfig.setInteger(ConfigConstants.LOCAL_NUMBER_TASK_MANAGER, 1);
- flinkConfig.setInteger(TaskManagerOptions.NUM_TASK_SLOTS, 8);
flinkConfig.setString(TaskManagerOptions.MANAGED_MEMORY_SIZE, "16m");
flinkConfig.setString(ConfigConstants.RESTART_STRATEGY_FIXED_DELAY_DELAY, "0 s");
- LocalFlinkMiniCluster flink = new LocalFlinkMiniCluster(flinkConfig, false);
- flink.start();
+ MiniClusterResource flink = new MiniClusterResource(new MiniClusterResourceConfiguration.Builder()
+ .setNumberTaskManagers(1)
+ .setNumberSlotsPerTaskManager(8)
+ .setConfiguration(flinkConfig)
Review comment:
It was "new LocalFlinkMiniCluster(flinkConfig, **false**)" which used different Actor systems for job and task managers.
Is it needed to set here also `.setRpcServiceSharing(RpcServiceSharing.DEDICATED)` as `RpcServiceSharing.SHARED` will be used by default in `MiniClusterResourceConfiguration.Builder` (in both modified tests)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services