[GitHub] [spark] srowen commented on a change in pull request #24516: [SPARK-27624][CORE] Fix CalenderInterval to show an empty interval correctly

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #24516: [SPARK-27624][CORE] Fix CalenderInterval to show an empty interval correctly
URL: https://github.com/apache/spark/pull/24516#discussion_r281030111
 
 

 ##########
 File path: common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java
 ##########
 @@ -321,6 +321,10 @@ public String toString() {
       appendUnit(sb, rest, "microsecond");
     }
 
+    if (months == 0 && microseconds == 0) {
+      sb.append(" 0 microseconds");
 
 Review comment:
   This seems fine; even just "0" seems reasonable as 0 seconds, microseconds, etc are all the same

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org