[jira] [Commented] (TS-2755) API is missing TSTextLogObjectRollingEnabledSet argument values

["Alan M. Carroll (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-2755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981645#comment-13981645 ] 

Alan M. Carroll commented on TS-2755:
-------------------------------------

It bothers me to not expose such values, but I do see that it's also confusing to have an "Enable" function that doesn't take a boolean.

I think this is OK for now, but we may want to implement TSTextLogObjectRollingActionSet() later to expose the values.

This brings up the issue of exposing enums that are embedded in classes to a C API.  That's an issue that will take some pondering.

> API is missing TSTextLogObjectRollingEnabledSet argument values
> ---------------------------------------------------------------
>
>                 Key: TS-2755
>                 URL: https://issues.apache.org/jira/browse/TS-2755
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: TS API
>            Reporter: James Peach
>            Assignee: James Peach
>             Fix For: 5.0.0
>
>
> The argument to {{TSTextLogObjectRollingEnabledSet}} is a value of type {{LogConfig::RollingEnabledValues}}, however these values are not exposed by the API.
> I'm going to fix this by using the {{enabled}} argument to {{TSTextLogObjectRollingEnabledSet}} as a boolean, since that is consistent with similar APIs. If rolling is enabled, then you will always get {{ROLL_ON_TIME_OR_SIZE}}



--
This message was sent by Atlassian JIRA
(v6.2#6252)