[GitHub] [incubator-celeborn] cfmcgrady commented on a diff in pull request #1735: [CELEBORN-812] Cleanup SendBufferPool if idle for long

["cfmcgrady (via GitHub)" <gi...@apache.org>]

cfmcgrady commented on code in PR #1735:
URL: https://github.com/apache/incubator-celeborn/pull/1735#discussion_r1268249595


##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -2883,6 +2886,24 @@ object CelebornConf extends Logging {
       .intConf
       .createWithDefault(1)
 
+  val CLIENT_PUSH_SENDBUFFERPOOL_CHECKEXPIREINTERVAL: ConfigEntry[Long] =
+    buildConf("celeborn.client.push.sendBufferPool.checkExpireInterval")
+      .categories("client")
+      .doc("Interval to check expire for send buffer pool. If the pool has been idle " +
+        "for more than `celeborn.client.push.sendbufferpool.expireTimeout`, the pooled send buffers and push tasks will be cleaned up.")

Review Comment:
   nit: celeborn.client.push.sendbufferpool.expireTimeout -> ${CLIENT_PUSH_SENDBUFFERPOOL_EXPIRETIMEOUT.key}



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org