You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/29 18:47:56 UTC

[GitHub] [airflow] aran3 opened a new issue #17899: upgrade_check should check python_callable is not used in TriggerDagRunOperator

aran3 opened a new issue #17899:
URL: https://github.com/apache/airflow/issues/17899


   ### Apache Airflow version
   
   2.1.2
   
   ### Operating System
   
   Red Hat Enterprise Linux Server 7.6 (Maipo)
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Deployment
   
   Virtualenv installation
   
   ### Deployment details
   
   _No response_
   
   ### What happened
   
   `airflow upgrade_check` should check `python_callable` is not used in `TriggerDagRunOperator`.
   As of https://github.com/apache/airflow/pull/6317, `python_callable` is no longer supported (in any 2.x version) and dag tasks using it will fail to parse. 
   This is not currently verified by upgrade_check and I caught it only after upgrading to 2.x. 
   
   ### What you expected to happen
   
   upgrade_check to verify parameters of `TriggerDagRunOperator` and warn that `upgrade_check` should be removed and replaced with passing `conf` dictionary directly. 
   
   ### How to reproduce
   
   run `airflow upgrade_check` on a dag with the following task (from PR):
   
   ```python
   def _trigger_task(context, object):
       object.payload = {"message": "Hello world"}
       return object
   
   trigger_task = TriggerDagRunOperator(
       task_id='test_trigger_dagrun',
       trigger_dag_id="example_trigger_target_dag",
       python_callable=_trigger_task,
       dag=dag,
   )
   ```
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #17899: upgrade_check should check python_callable is not used in TriggerDagRunOperator

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #17899:
URL: https://github.com/apache/airflow/issues/17899#issuecomment-907863146


   Closing for two reasons:
   1. There are no further releases of upgrade check tool as 1.10 is EOL.
   2. In any case this is not something that can be added to the upgrade check as the `conf` param doesn't exist in `TriggerDagRunOperator` of 1.10 - It wasn't backported so this specific change is a breaking change. The upgrade checker doesn't handle breaking changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal edited a comment on issue #17899: upgrade_check should check python_callable is not used in TriggerDagRunOperator

Posted by GitBox <gi...@apache.org>.
eladkal edited a comment on issue #17899:
URL: https://github.com/apache/airflow/issues/17899#issuecomment-907863146


   Closing for two reasons:
   1. There are no further releases of upgrade check tool as 1.10 is EOL.
   2. In any case this is not something that can be added to the upgrade check as the `conf` param doesn't exist in `TriggerDagRunOperator` of 1.10 - It wasn't backported so this specific change is a breaking change. The upgrade checker will not suggest changes that results in broken dags on 1.10


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal closed issue #17899: upgrade_check should check python_callable is not used in TriggerDagRunOperator

Posted by GitBox <gi...@apache.org>.
eladkal closed issue #17899:
URL: https://github.com/apache/airflow/issues/17899


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #17899: upgrade_check should check python_callable is not used in TriggerDagRunOperator

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #17899:
URL: https://github.com/apache/airflow/issues/17899#issuecomment-907848622


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org