You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/11 05:04:20 UTC

[GitHub] [rocketmq] lizhanhui commented on a diff in pull request #4637: [ISSUE #4585] PlainPermissionManagerTest add unit test

lizhanhui commented on code in PR #4637:
URL: https://github.com/apache/rocketmq/pull/4637#discussion_r943097563


##########
acl/src/test/java/org/apache/rocketmq/acl/plain/PlainPermissionManagerTest.java:
##########
@@ -45,6 +54,8 @@ public class PlainPermissionManagerTest {
     PlainAccessConfig plainAccessConfig = new PlainAccessConfig();
     Set<Integer> adminCode = new HashSet<>();
 
+    private static final String PATH = "src/test/resources";

Review Comment:
   Why not load test resources from classpath? It is a much more idiomatic



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org