You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/25 16:43:35 UTC
[GitHub] [incubator-tvm] ANSHUMAN87 opened a new pull request #5149:
[WIP][Relay][Frontend] Chainer frontend introduced
ANSHUMAN87 opened a new pull request #5149: [WIP][Relay][Frontend] Chainer frontend introduced
URL: https://github.com/apache/incubator-tvm/pull/5149
Chainer frontend is added among other Relay frontends.
Note: This is just a skeleton now. And it is under active development.
Please do not refer for review.
Once it is ready for review, will update and include respective reviewers.
However, if anyone has any specific requirement from chainer framework, please feel free to post here. Will sure take it up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] ANSHUMAN87 commented on issue #5149:
[WIP][Relay][Frontend] Chainer frontend introduced
Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 commented on issue #5149: [WIP][Relay][Frontend] Chainer frontend introduced
URL: https://github.com/apache/incubator-tvm/pull/5149#issuecomment-608997921
@tqchen : This PR is now ready with one complete model VGG16 importing from Chainer. Same test case is also added.
But when i check the CI report, it fails because of missing Chainer package. Can you please help me on resolving this issue? TIA!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi edited a comment on issue #5149:
[WIP][Relay][Frontend] Chainer frontend introduced
Posted by GitBox <gi...@apache.org>.
masahi edited a comment on issue #5149: [WIP][Relay][Frontend] Chainer frontend introduced
URL: https://github.com/apache/incubator-tvm/pull/5149#issuecomment-604681188
See https://discuss.tvm.ai/t/discuss-adding-a-pytorch-frontend/5026 for a RFC on adding the PyTorch frontend.
Yes, discussion with respect to ONNX is common when adding a new frontend, and the PyTorch RFC above gave some reasons adding the PyTorch frontend could be justified. You want to have similar story for Chainer, more specific than "Chainer users would benefit" or "attracting more users" or
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #5149:
[WIP][Relay][Frontend] Chainer frontend introduced
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5149: [WIP][Relay][Frontend] Chainer frontend introduced
URL: https://github.com/apache/incubator-tvm/pull/5149#issuecomment-604663268
@ANSHUMAN87 feel free to send an RFC to the discuss forum to get more feedbacks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] ANSHUMAN87 commented on issue #5149:
[WIP][Relay][Frontend] Chainer frontend introduced
Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 commented on issue #5149: [WIP][Relay][Frontend] Chainer frontend introduced
URL: https://github.com/apache/incubator-tvm/pull/5149#issuecomment-605589268
[RFC](https://discuss.tvm.ai/t/introduce-new-frontend-for-chainer/6129) raised.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi edited a comment on issue #5149:
[WIP][Relay][Frontend] Chainer frontend introduced
Posted by GitBox <gi...@apache.org>.
masahi edited a comment on issue #5149: [WIP][Relay][Frontend] Chainer frontend introduced
URL: https://github.com/apache/incubator-tvm/pull/5149#issuecomment-604095365
You should first send a RFC on why you want to add this frontend. I don't think it is a good idea for the following reasons:
* Chainer is now in maintenance mode
* We already have ONNX and PyTorch frontend. Existing Chainer users are being encouraged to switch to PyTorch, so they can use either frontend
* Additional frontend brings more development and maintenance burden (including reviews), and makes CI even slower
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #5149:
[WIP][Relay][Frontend] Chainer frontend introduced
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #5149: [WIP][Relay][Frontend] Chainer frontend introduced
URL: https://github.com/apache/incubator-tvm/pull/5149#issuecomment-604095365
You should first send a RFC on why you want to add this frontend. I don't think it is a good idea for the following reasons:
* Chainer is now in maintenance mode
* We already have ONNX and PyTorch frontend. Existing Chainer users are being encouraged to switch to PyTorch, so they can use either frontend
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] ANSHUMAN87 edited a comment on issue #5149:
[WIP][Relay][Frontend] Chainer frontend introduced
Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 edited a comment on issue #5149: [WIP][Relay][Frontend] Chainer frontend introduced
URL: https://github.com/apache/incubator-tvm/pull/5149#issuecomment-604639849
@tqchen, @masahi: Thanks for your feedback. However I couldn't not agree completely on the reasonings shared by masahi.
Please find my response accordingly.
I know the current support of ONNX, but is that not the case for many of the frontends already supported now?
Also if the CI slowness is the worry, then we should come up with a solution for that. We should not restrict to fewer frontends.
As I see, the numerous user of chainer framework will get benefitted by this frontends, even though they are encouraged to switch to other framework.
As the concern raised for development and maintenance, definitely I will take care of that through constant effort. Also one point, the maintenance effort is proportional to no of active user(as the requirement also increases with that).
My opinion is this frontend will attract more user towards TVM as it opens more space for experiments. Also it shows the strength of express abilities of TVM.
But having said that, I would not mind dropping this feature, if TVM members thinks it is unreasonable to add this frontends. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi commented on issue #5149:
[WIP][Relay][Frontend] Chainer frontend introduced
Posted by GitBox <gi...@apache.org>.
masahi commented on issue #5149: [WIP][Relay][Frontend] Chainer frontend introduced
URL: https://github.com/apache/incubator-tvm/pull/5149#issuecomment-604681188
See https://discuss.tvm.ai/t/discuss-adding-a-pytorch-frontend/5026 for a RFC on adding the PyTorch backend. Yes, discussion with respect to ONNX is common when adding a new frontend, and the PyTorch RFC above gave some reasons adding the PyTorch frontend could be justified. You want to have similar story for Chainer, more specific than "Chainer users would benefit" or "attracting more users" or
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #5149:
[WIP][Relay][Frontend] Chainer frontend introduced
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5149: [WIP][Relay][Frontend] Chainer frontend introduced
URL: https://github.com/apache/incubator-tvm/pull/5149#issuecomment-604546479
I agree that given the current support of chainer, perhaps we should not introduce this frontend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] masahi edited a comment on issue #5149:
[WIP][Relay][Frontend] Chainer frontend introduced
Posted by GitBox <gi...@apache.org>.
masahi edited a comment on issue #5149: [WIP][Relay][Frontend] Chainer frontend introduced
URL: https://github.com/apache/incubator-tvm/pull/5149#issuecomment-604681188
See https://discuss.tvm.ai/t/discuss-adding-a-pytorch-frontend/5026 for a RFC on adding the PyTorch frontend.
Yes, discussion with respect to ONNX is common when adding a new frontend, and the PyTorch RFC above gave some reasons adding the PyTorch frontend could be justified. You want to have similar story for Chainer, more specific than "Chainer users would benefit" or "attracting more users".
Note that unlike other frameworks, Chainer doesn't even have a well defined IR we can translate from. You need to start by developing some kind of tracing mechanism.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] FrozenGene commented on issue #5149:
[WIP][Relay][Frontend] Chainer frontend introduced
Posted by GitBox <gi...@apache.org>.
FrozenGene commented on issue #5149: [WIP][Relay][Frontend] Chainer frontend introduced
URL: https://github.com/apache/incubator-tvm/pull/5149#issuecomment-604794706
I agree some points of @ANSHUMAN87 . TVM is so attractive, I think one reason is we are very open and happy to provide stage for them . However, given current status of chainer, we are more willing to discuss more detail about it in RFC. Like whether we should introduce it into TVM, how to support it better and so on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] ANSHUMAN87 commented on issue #5149:
[WIP][Relay][Frontend] Chainer frontend introduced
Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 commented on issue #5149: [WIP][Relay][Frontend] Chainer frontend introduced
URL: https://github.com/apache/incubator-tvm/pull/5149#issuecomment-604847927
@tqchen , @masahi , @FrozenGene : I am really thankful for your responses. I will definitely raise RFC very soon(mostly within 2 days) for this feature and obtain all your expert opinions. TIA!
NOTE: Because of working timezone differences. You might see my response little delayed. However i will ensure my best effort to respond all your posts as early as possible. Please bear with me for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] ANSHUMAN87 commented on issue #5149:
[WIP][Relay][Frontend] Chainer frontend introduced
Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 commented on issue #5149: [WIP][Relay][Frontend] Chainer frontend introduced
URL: https://github.com/apache/incubator-tvm/pull/5149#issuecomment-604639849
@tqchen, @masahi: Thanks for your feedback. However I couldn't not agree completely on the reasonings shared by masahi.
Please find my response accordingly.
I know the current support of ONNX, but is that not the case for many of the frontends already supported now?
Also if the CI slowness is the worry, then we should come up with a solution for that. We should not restrict to fewer frontends.
As I see, the numerous user of chainer framework will get benefitted by this frontends, even though they are encouraged to switch to other framework.
As the concern raised for development and maintenance, definitely I will take care of that through constant effort. Also one point, the maintenance effort is proportional to no of active user(as the requirement also increases with that).
My opinion is this frontend will attract more user towards TVM. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen closed pull request #5149: [WIP][Relay][Frontend] Chainer frontend introduced
Posted by GitBox <gi...@apache.org>.
tqchen closed pull request #5149:
URL: https://github.com/apache/incubator-tvm/pull/5149
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org