[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2415: igmp: bypass MULTICAST_LOOP/TTL options

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on pull request #2415:
URL: https://github.com/apache/incubator-nuttx/pull/2415#issuecomment-734919971


   > Is this a Hack? This code change, changes the functionality from returning not supported to falsely returning that the functionality is supported but does nothing.
   
   @davids5 these options control the minor behaviour of group broadcast(e.g. time to live value). Where support these options doesn't generate the huge difference, it isn't too bad to return OK here to let the program run successfully. The similar approach use for open too:
   ```
   #define O_SYNC      (1 << 7)        /* Synchronize output on write */
   #define O_DSYNC     O_SYNC          /* Equivalent to OSYNC in NuttX */
   #define O_BINARY    (1 << 8)        /* Open the file in binary (untranslated) mode. */
   #define O_DIRECT    (1 << 9)        /* Avoid caching, write directly to hardware */
   ```
   We define these flags in fcntl.h, which mean user can open file with these flags, but none of NutX filesystem support any of them.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org