[GitHub] [flink-kubernetes-operator] gyfora commented on a change in pull request #27: [FLINK-26328] Control Logging Behavior in Flink Deployments

[GitBox <gi...@apache.org>]

gyfora commented on a change in pull request #27:
URL: https://github.com/apache/flink-kubernetes-operator/pull/27#discussion_r816981833



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkConfigBuilder.java
##########
@@ -80,6 +83,17 @@ public FlinkConfigBuilder applyFlinkConfiguration() {
         return this;
     }
 
+    public FlinkConfigBuilder applyLogConfiguration() throws IOException {
+        if (spec.getLogConfiguration() != null) {
+            String confDir =
+                    createLogConfigFiles(
+                            spec.getLogConfiguration().get(CONFIG_FILE_LOG4J_NAME),

Review comment:
       Since only 2 specific file names (keys) will be recognized and used, we should validate that the user did not specify anything else. 
   
   This check could go straight into the validator component.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org