You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Enrico Olivelli <eo...@gmail.com> on 2021/10/05 09:44:36 UTC
Using GitHub merge button
Hello,
The bk-merge-script has new problems, now it fails for me consistently, it
looks like a problem with the GH Merge API, see the error message below.
In Pulsar we are using the GH merge button
the main limitations of using the Merge Button are:
- you have to manually set labels and milestone
- it does not handle cherry-picks
I propose to switch to using the GH merge button, or at least to allow
Committers to use it
We can write instructions for committers
Thoughts ?
Enrico
From https://github.com/apache/bookkeeper
* [new ref] refs/pull/2808/head -> PR_TOOL_MERGE_PR_2808
Enter reviewers [Prashant Kumar <None>, Enrico Olivelli <eo...@gmail.com>,
Andrey Yegorov <None>]:
['git', 'log', 'HEAD..PR_TOOL_MERGE_PR_2808', '--pretty=format:%h [%an] %s']
List pull request commits in squashed commit message? (y/n): n
git rev-parse PR_TOOL_MERGE_PR_2808
Merge Pull Request (2808) with following details:
{
"commit_title": "set response body for bookie is_ready api",
"commit_message": "API `/api/v1/bookie/is_ready` should set some
response body, when code 200 returned.\r\nOr, this will confuse people,
they don't know if this api return successfully.\r\n\r\n\r\n\n\nReviewers:
Prashant Kumar <None>, Enrico Olivelli <eo...@gmail.com>, Andrey
Yegorov <None>\n\nThis closes #2808 from
gaozhangmin/api_bookie_is_ready_message_when_return_code_200",
"sha": "89f16843232848972bbd551b96ecc13428f3f36d",
"merge_method": "squash"
} (y/n): y
Unable to fetch URL, exiting:
https://api.github.com/repos/apache/bookkeeper/pulls/2808/merge - HTTP
Error 404: Not Found
HTTP Error 404: Not Found
Re: Using GitHub merge button
Posted by Andrey Yegorov <an...@datastax.com>.
+1 from me too.
On Wed, Oct 20, 2021 at 10:27 AM Henry Saputra <he...@gmail.com>
wrote:
> Other than formatting of the subject and some additional info to the PR
> commit, and automatically set tags to the PR, I think the script do not do
> anything special, right?
>
> I think this is kind of "legacy" approach when we commit to the Apache
> managed Git repo, following approach that Apache Spark was doing.
>
> I am +1 to just use Github merge tool.
>
> - Henry
>
> On Wed, Oct 20, 2021 at 10:05 AM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Do we need some VOTE?
> >
> > I think we do not need it
> >
> > But we should update the committer guide
> >
> > Enrico
> >
> > Il Mer 20 Ott 2021, 18:50 Henry Saputra <he...@gmail.com> ha
> > scritto:
> >
> > > Ack for this one. I have encountered this issue for some PRs.
> > >
> > > - Henry
> > >
> > > On Tue, Oct 5, 2021 at 2:44 AM Enrico Olivelli <eo...@gmail.com>
> > > wrote:
> > >
> > > > Hello,
> > > > The bk-merge-script has new problems, now it fails for me
> consistently,
> > > it
> > > > looks like a problem with the GH Merge API, see the error message
> > below.
> > > >
> > > > In Pulsar we are using the GH merge button
> > > > the main limitations of using the Merge Button are:
> > > > - you have to manually set labels and milestone
> > > > - it does not handle cherry-picks
> > > >
> > > > I propose to switch to using the GH merge button, or at least to
> allow
> > > > Committers to use it
> > > > We can write instructions for committers
> > > >
> > > > Thoughts ?
> > > > Enrico
> > > >
> > > >
> > > > From https://github.com/apache/bookkeeper
> > > >
> > > > * [new ref] refs/pull/2808/head -> PR_TOOL_MERGE_PR_2808
> > > >
> > > > Enter reviewers [Prashant Kumar <None>, Enrico Olivelli <
> > > > eolivelli@gmail.com>,
> > > > Andrey Yegorov <None>]:
> > > >
> > > > ['git', 'log', 'HEAD..PR_TOOL_MERGE_PR_2808', '--pretty=format:%h
> [%an]
> > > > %s']
> > > >
> > > > List pull request commits in squashed commit message? (y/n): n
> > > >
> > > > git rev-parse PR_TOOL_MERGE_PR_2808
> > > >
> > > >
> > > > Merge Pull Request (2808) with following details:
> > > >
> > > > {
> > > >
> > > > "commit_title": "set response body for bookie is_ready api",
> > > >
> > > > "commit_message": "API `/api/v1/bookie/is_ready` should set some
> > > > response body, when code 200 returned.\r\nOr, this will confuse
> people,
> > > > they don't know if this api return
> successfully.\r\n\r\n\r\n\n\nReviewers:
> > > > Prashant Kumar <None>, Enrico Olivelli <eo...@gmail.com>, Andrey
> > > > Yegorov <None>\n\nThis closes #2808 from
> > > > gaozhangmin/api_bookie_is_ready_message_when_return_code_200",
> > > >
> > > > "sha": "89f16843232848972bbd551b96ecc13428f3f36d",
> > > >
> > > > "merge_method": "squash"
> > > >
> > > > } (y/n): y
> > > >
> > > > Unable to fetch URL, exiting:
> > > > https://api.github.com/repos/apache/bookkeeper/pulls/2808/merge -
> HTTP
> > > > Error 404: Not Found
> > > >
> > > > HTTP Error 404: Not Found
> > > >
> > >
> >
>
--
Andrey Yegorov
Re: Using GitHub merge button
Posted by Henry Saputra <he...@gmail.com>.
Other than formatting of the subject and some additional info to the PR
commit, and automatically set tags to the PR, I think the script do not do
anything special, right?
I think this is kind of "legacy" approach when we commit to the Apache
managed Git repo, following approach that Apache Spark was doing.
I am +1 to just use Github merge tool.
- Henry
On Wed, Oct 20, 2021 at 10:05 AM Enrico Olivelli <eo...@gmail.com>
wrote:
> Do we need some VOTE?
>
> I think we do not need it
>
> But we should update the committer guide
>
> Enrico
>
> Il Mer 20 Ott 2021, 18:50 Henry Saputra <he...@gmail.com> ha
> scritto:
>
> > Ack for this one. I have encountered this issue for some PRs.
> >
> > - Henry
> >
> > On Tue, Oct 5, 2021 at 2:44 AM Enrico Olivelli <eo...@gmail.com>
> > wrote:
> >
> > > Hello,
> > > The bk-merge-script has new problems, now it fails for me consistently,
> > it
> > > looks like a problem with the GH Merge API, see the error message
> below.
> > >
> > > In Pulsar we are using the GH merge button
> > > the main limitations of using the Merge Button are:
> > > - you have to manually set labels and milestone
> > > - it does not handle cherry-picks
> > >
> > > I propose to switch to using the GH merge button, or at least to allow
> > > Committers to use it
> > > We can write instructions for committers
> > >
> > > Thoughts ?
> > > Enrico
> > >
> > >
> > > From https://github.com/apache/bookkeeper
> > >
> > > * [new ref] refs/pull/2808/head -> PR_TOOL_MERGE_PR_2808
> > >
> > > Enter reviewers [Prashant Kumar <None>, Enrico Olivelli <
> > > eolivelli@gmail.com>,
> > > Andrey Yegorov <None>]:
> > >
> > > ['git', 'log', 'HEAD..PR_TOOL_MERGE_PR_2808', '--pretty=format:%h [%an]
> > > %s']
> > >
> > > List pull request commits in squashed commit message? (y/n): n
> > >
> > > git rev-parse PR_TOOL_MERGE_PR_2808
> > >
> > >
> > > Merge Pull Request (2808) with following details:
> > >
> > > {
> > >
> > > "commit_title": "set response body for bookie is_ready api",
> > >
> > > "commit_message": "API `/api/v1/bookie/is_ready` should set some
> > > response body, when code 200 returned.\r\nOr, this will confuse people,
> > > they don't know if this api return successfully.\r\n\r\n\r\n\n\nReviewers:
> > > Prashant Kumar <None>, Enrico Olivelli <eo...@gmail.com>, Andrey
> > > Yegorov <None>\n\nThis closes #2808 from
> > > gaozhangmin/api_bookie_is_ready_message_when_return_code_200",
> > >
> > > "sha": "89f16843232848972bbd551b96ecc13428f3f36d",
> > >
> > > "merge_method": "squash"
> > >
> > > } (y/n): y
> > >
> > > Unable to fetch URL, exiting:
> > > https://api.github.com/repos/apache/bookkeeper/pulls/2808/merge - HTTP
> > > Error 404: Not Found
> > >
> > > HTTP Error 404: Not Found
> > >
> >
>
Re: Using GitHub merge button
Posted by Enrico Olivelli <eo...@gmail.com>.
Do we need some VOTE?
I think we do not need it
But we should update the committer guide
Enrico
Il Mer 20 Ott 2021, 18:50 Henry Saputra <he...@gmail.com> ha
scritto:
> Ack for this one. I have encountered this issue for some PRs.
>
> - Henry
>
> On Tue, Oct 5, 2021 at 2:44 AM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > Hello,
> > The bk-merge-script has new problems, now it fails for me consistently,
> it
> > looks like a problem with the GH Merge API, see the error message below.
> >
> > In Pulsar we are using the GH merge button
> > the main limitations of using the Merge Button are:
> > - you have to manually set labels and milestone
> > - it does not handle cherry-picks
> >
> > I propose to switch to using the GH merge button, or at least to allow
> > Committers to use it
> > We can write instructions for committers
> >
> > Thoughts ?
> > Enrico
> >
> >
> > From https://github.com/apache/bookkeeper
> >
> > * [new ref] refs/pull/2808/head -> PR_TOOL_MERGE_PR_2808
> >
> > Enter reviewers [Prashant Kumar <None>, Enrico Olivelli <
> > eolivelli@gmail.com>,
> > Andrey Yegorov <None>]:
> >
> > ['git', 'log', 'HEAD..PR_TOOL_MERGE_PR_2808', '--pretty=format:%h [%an]
> > %s']
> >
> > List pull request commits in squashed commit message? (y/n): n
> >
> > git rev-parse PR_TOOL_MERGE_PR_2808
> >
> >
> > Merge Pull Request (2808) with following details:
> >
> > {
> >
> > "commit_title": "set response body for bookie is_ready api",
> >
> > "commit_message": "API `/api/v1/bookie/is_ready` should set some
> > response body, when code 200 returned.\r\nOr, this will confuse people,
> > they don't know if this api return successfully.\r\n\r\n\r\n\n\nReviewers:
> > Prashant Kumar <None>, Enrico Olivelli <eo...@gmail.com>, Andrey
> > Yegorov <None>\n\nThis closes #2808 from
> > gaozhangmin/api_bookie_is_ready_message_when_return_code_200",
> >
> > "sha": "89f16843232848972bbd551b96ecc13428f3f36d",
> >
> > "merge_method": "squash"
> >
> > } (y/n): y
> >
> > Unable to fetch URL, exiting:
> > https://api.github.com/repos/apache/bookkeeper/pulls/2808/merge - HTTP
> > Error 404: Not Found
> >
> > HTTP Error 404: Not Found
> >
>
Re: Using GitHub merge button
Posted by Henry Saputra <he...@gmail.com>.
Ack for this one. I have encountered this issue for some PRs.
- Henry
On Tue, Oct 5, 2021 at 2:44 AM Enrico Olivelli <eo...@gmail.com> wrote:
> Hello,
> The bk-merge-script has new problems, now it fails for me consistently, it
> looks like a problem with the GH Merge API, see the error message below.
>
> In Pulsar we are using the GH merge button
> the main limitations of using the Merge Button are:
> - you have to manually set labels and milestone
> - it does not handle cherry-picks
>
> I propose to switch to using the GH merge button, or at least to allow
> Committers to use it
> We can write instructions for committers
>
> Thoughts ?
> Enrico
>
>
> From https://github.com/apache/bookkeeper
>
> * [new ref] refs/pull/2808/head -> PR_TOOL_MERGE_PR_2808
>
> Enter reviewers [Prashant Kumar <None>, Enrico Olivelli <
> eolivelli@gmail.com>,
> Andrey Yegorov <None>]:
>
> ['git', 'log', 'HEAD..PR_TOOL_MERGE_PR_2808', '--pretty=format:%h [%an]
> %s']
>
> List pull request commits in squashed commit message? (y/n): n
>
> git rev-parse PR_TOOL_MERGE_PR_2808
>
>
> Merge Pull Request (2808) with following details:
>
> {
>
> "commit_title": "set response body for bookie is_ready api",
>
> "commit_message": "API `/api/v1/bookie/is_ready` should set some
> response body, when code 200 returned.\r\nOr, this will confuse people,
> they don't know if this api return successfully.\r\n\r\n\r\n\n\nReviewers:
> Prashant Kumar <None>, Enrico Olivelli <eo...@gmail.com>, Andrey
> Yegorov <None>\n\nThis closes #2808 from
> gaozhangmin/api_bookie_is_ready_message_when_return_code_200",
>
> "sha": "89f16843232848972bbd551b96ecc13428f3f36d",
>
> "merge_method": "squash"
>
> } (y/n): y
>
> Unable to fetch URL, exiting:
> https://api.github.com/repos/apache/bookkeeper/pulls/2808/merge - HTTP
> Error 404: Not Found
>
> HTTP Error 404: Not Found
>