You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "jiangfucheng (via GitHub)" <gi...@apache.org> on 2023/04/04 16:55:58 UTC
[GitHub] [apisix] jiangfucheng opened a new pull request, #9243: fix: markdownlint ci node work
jiangfucheng opened a new pull request, #9243:
URL: https://github.com/apache/apisix/pull/9243
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes https://github.com/apache/apisix/issues/9242
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on pull request #9243: fix(ci): markdownlint ci not work
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #9243:
URL: https://github.com/apache/apisix/pull/9243#issuecomment-1518918786
@jiangfucheng Some of the changes seem unnecessary, perhaps you should raise a separate PR to fix these documentation issues, with a new PR starting with "docs: "
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on pull request #9243: fix(ci): markdownlint ci not work
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #9243:
URL: https://github.com/apache/apisix/pull/9243#issuecomment-1507807044
Could you show me the ci link of `doc-lint ci seems not work`? Are you sure this pr can fix this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] jiangfucheng commented on pull request #9243: fix(ci): markdownlint ci not work
Posted by "jiangfucheng (via GitHub)" <gi...@apache.org>.
jiangfucheng commented on PR #9243:
URL: https://github.com/apache/apisix/pull/9243#issuecomment-1518689791
Sorry, it was my mistake. I tested it in my own forked repository and it worked well, so I mistakenly thought that the issue was caused by `”“`. However, the doc-lint CI is really doesn't work anymore as evidenced by the numerous failed actions in https://github.com/apache/apisix/actions/workflows/doc-lint.yml.
I have researched some sources but I am unsure if they are related to this issue. Please refer to: https://github.com/orgs/community/discussions/25488
Regarding this PR, if you believe that these document modifications are useful and should be merged, I will remove any unnecessary code and keep it clean. Otherwise, I will close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] jiangfucheng commented on pull request #9243: fix(ci): markdownlint ci not work
Posted by "jiangfucheng (via GitHub)" <gi...@apache.org>.
jiangfucheng commented on PR #9243:
URL: https://github.com/apache/apisix/pull/9243#issuecomment-1507137588
The failed CI seems abnormaly, so i submit a empty commit try to re-trigger CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] jiangfucheng commented on pull request #9243: fix(ci): markdownlint ci not work
Posted by "jiangfucheng (via GitHub)" <gi...@apache.org>.
jiangfucheng commented on PR #9243:
URL: https://github.com/apache/apisix/pull/9243#issuecomment-1518920746
@soulbird @monkeyDluffy6017 Thank you for your reply, I will create new PR to fix these documentation issues in my spare time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 commented on a diff in pull request #9243: fix(ci): markdownlint ci not work
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #9243:
URL: https://github.com/apache/apisix/pull/9243#discussion_r1166184238
##########
docs/zh/latest/getting-started.md:
##########
@@ -143,13 +143,13 @@ curl -sL https://run.api7.ai/apisix/quickstart | sh
curl "http://127.0.0.1:9080" --head | grep Server
```
-I如果一切顺利，将输出如下信息。
+I 如果一切顺利，将输出如下信息。
Review Comment:
The `I` is redundant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] jiangfucheng closed pull request #9243: fix(ci): markdownlint ci not work
Posted by "jiangfucheng (via GitHub)" <gi...@apache.org>.
jiangfucheng closed pull request #9243: fix(ci): markdownlint ci not work
URL: https://github.com/apache/apisix/pull/9243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] soulbird commented on pull request #9243: fix(ci): markdownlint ci not work
Posted by "soulbird (via GitHub)" <gi...@apache.org>.
soulbird commented on PR #9243:
URL: https://github.com/apache/apisix/pull/9243#issuecomment-1518912816
> Sorry, it was my mistake. I tested it in my own forked repository and it worked well, so I mistakenly thought that the issue was caused by `”“`. However, the doc-lint CI is really doesn't work anymore as evidenced by the numerous failed actions in https://github.com/apache/apisix/actions/workflows/doc-lint.yml.
>
> I have researched some sources but I am unsure if they are related to this issue. Please refer to: https://github.com/orgs/community/discussions/25488
>
> Regarding this PR, if you believe that these document modifications are useful and should be merged, I will remove any unnecessary code and keep it clean. Otherwise, I will close it.
So， just remove any unnecessary code and keep it clean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] jiangfucheng commented on pull request #9243: fix(ci): markdownlint ci not work
Posted by "jiangfucheng (via GitHub)" <gi...@apache.org>.
jiangfucheng commented on PR #9243:
URL: https://github.com/apache/apisix/pull/9243#issuecomment-1518920892
@soulbird @monkeyDluffy6017 Thank you for your reply, I will create new PR to fix these documentations issues in my spare time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org