You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by randall <gi...@git.apache.org> on 2016/08/25 08:23:06 UTC
[GitHub] trafficserver pull request #920: TS-4268: Verbose OCSP notes in syslog
GitHub user randall opened a pull request:
https://github.com/apache/trafficserver/pull/920
TS-4268: Verbose OCSP notes in syslog
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/randall/trafficserver ts/4268
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/920.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #920
----
commit bb66ed7de518f0b563c03b35308c641c6cef571d
Author: Randall Meyer <rr...@apple.com>
Date: 2016-03-14T22:30:05Z
TS-4268: Verbose OCSP notes in syslog
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #920: TS-4268: Verbose OCSP notes in syslog
Posted by abh <gi...@git.apache.org>.
Github user abh commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/920#discussion_r90795038
--- Diff: iocore/net/OCSPStapling.cc ---
@@ -382,9 +382,11 @@ ocsp_update()
if (cinf->resp_derlen == 0 || cinf->is_expire || cinf->expire_time < current_time) {
ink_mutex_release(&cinf->stapling_mutex);
if (stapling_refresh_response(cinf, &resp)) {
- Note("Success to refresh OCSP response for 1 certificate.");
+ Debug("ssl_ocsp", "Successful OCSP refresh response for 1 certificate");
+ SSL_INCREMENT_DYN_STAT(ssl_ocsp_refreshed_cert_stat);
} else {
- Note("Fail to refresh OCSP response for 1 certificate.");
+ Debug("ssl_ocsp", "Failed to refresh OCSP for 1 certificate");
--- End diff --
It'd be nice to keep the failures in the non-debug logs, I think. Nicer if it included some information about the cert that couldn't be updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #920: TS-4268: Verbose OCSP notes in syslog
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/920
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #920: TS-4268: Verbose OCSP notes in syslog
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/920
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/608/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #920: TS-4268: Verbose OCSP notes in syslog
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/920
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #920: TS-4268: Verbose OCSP notes in syslog
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/920
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/504/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---