You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "werpu (via GitHub)" <gi...@apache.org> on 2023/02/10 09:05:37 UTC
[GitHub] [myfaces] werpu opened a new pull request, #514: Feature/myfaces 4466: Merge Pull request into main
werpu opened a new pull request, #514:
URL: https://github.com/apache/myfaces/pull/514
I have to open another pull request on the same branch, because the original one has been showing a merge error for quite some time. The merge is imminent, I just want to run another set of TCKs tests with the latest codebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #514: Feature/myfaces 4466: Merge Pull request into main (RC5 Target) - Faces.js new scripts!
Posted by "werpu (via GitHub)" <gi...@apache.org>.
werpu commented on PR #514:
URL: https://github.com/apache/myfaces/pull/514#issuecomment-1425569200
TCKs pass, however the Tobago people reported an issue with the fileupload for the RC34 of the jsf_ts codebase which needs a fix, so no merge this week, RC33 worked, but I do not want to fork the codebase there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #514: Feature/myfaces 4466: Merge Pull request into main (RC5 Target) - Faces.js new scripts!
Posted by "werpu (via GitHub)" <gi...@apache.org>.
werpu commented on PR #514:
URL: https://github.com/apache/myfaces/pull/514#issuecomment-1430825463
@tandraschko could you resolve the issue? Otherwise I will look into it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #514: Feature/myfaces 4466: Merge Pull request into main
Posted by "werpu (via GitHub)" <gi...@apache.org>.
werpu commented on PR #514:
URL: https://github.com/apache/myfaces/pull/514#issuecomment-1425457355
For the sake of documentation, I will close the old pull request, because it has been broken for quite a while.
So that nothing gets lost documentationwise, here is the link:
https://github.com/apache/myfaces/pull/356
(The old one will be closed now)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko merged pull request #514: Feature/myfaces 4466: Merge Pull request into main (RC5 Target) - Faces.js new scripts!
Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko merged PR #514:
URL: https://github.com/apache/myfaces/pull/514
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #514: Feature/myfaces 4466: Merge Pull request into main (RC5 Target) - Faces.js new scripts!
Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko commented on PR #514:
URL: https://github.com/apache/myfaces/pull/514#issuecomment-1428223061
lets merge this
thanks for your great and hard work werner!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #514: Feature/myfaces 4466: Merge Pull request into main (RC5 Target) - Faces.js new scripts!
Posted by "werpu (via GitHub)" <gi...@apache.org>.
werpu commented on PR #514:
URL: https://github.com/apache/myfaces/pull/514#issuecomment-1428405160
Hey, sorry for chiming in so late, but I just noticed the issue. This is a known issue with node as it seems, which I was not aware of, however there seems to be a fix/workaround: https://github.com/webpack/webpack.js.org/issues/2733
Try the cross-env solution, if this fails I will work on this on wednesday when I am back.
It just comes to to set the environment variable properly so of cross-env causes problems we can find others. I just wonder why I was not affected by this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #514: Feature/myfaces 4466: Merge Pull request into main (RC5 Target) - Faces.js new scripts!
Posted by "werpu (via GitHub)" <gi...@apache.org>.
werpu commented on PR #514:
URL: https://github.com/apache/myfaces/pull/514#issuecomment-1425672241
Integration Tests pass:
<img width="538" alt="image" src="https://user-images.githubusercontent.com/530547/218075526-93c533a4-1a63-4c36-843f-47154ce41a08.png">
TCK:
Faces23 / Ajax:
<img width="653" alt="image" src="https://user-images.githubusercontent.com/530547/218078313-c22e9be6-5755-4279-a2cc-f96249ef4632.png">
Faces 22
<img width="573" alt="image" src="https://user-images.githubusercontent.com/530547/218081276-66c53650-01e6-4c14-8448-d4e5d90ad652.png">
Faces 23/ajax:
<img width="573" alt="image" src="https://user-images.githubusercontent.com/530547/218082070-18a3fb93-2e6a-4b24-8bf0-86de42b9aa81.png">
Namespace:
<img width="573" alt="image" src="https://user-images.githubusercontent.com/530547/218081676-c2ff3e00-68b8-4194-9f97-115f5c470419.png">
Note originally in faces 23 Test 1423 was failing, this is an issue of the test itself (timing issue, with a race condition between the webdriver and the test code, which is not fixable on framework level, but the test itself needs adaption)
The adapted test passes. I will issue a fix for the test on the TCK side on monday together with a small selenium test framework update!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #514: Feature/myfaces 4466: Merge Pull request into main (RC5 Target) - Faces.js new scripts!
Posted by "werpu (via GitHub)" <gi...@apache.org>.
werpu commented on PR #514:
URL: https://github.com/apache/myfaces/pull/514#issuecomment-1427124412
Hi bad news... i got a mild infection, and currently being in bed with fever, so I will leave the honor for the merge to @volosied, @tandraschko or @pnicolucci unless you want to wait until I have recovered (which might be wednesday)
Feel free to go ahead with the merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #514: Feature/myfaces 4466: Merge Pull request into main (RC5 Target) - Faces.js new scripts!
Posted by "werpu (via GitHub)" <gi...@apache.org>.
werpu commented on PR #514:
URL: https://github.com/apache/myfaces/pull/514#issuecomment-1431351921
resolved it with @tandraschko, we can see the issue as closed now. The fix was indeed to use the cross-env package as replacement for the env command. I was not aware of the cross platform issues env in Node has and many people aren“t as it seems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #514: Feature/myfaces 4466: Merge Pull request into main (RC5 Target) - Faces.js new scripts!
Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko commented on PR #514:
URL: https://github.com/apache/myfaces/pull/514#issuecomment-1430915598
@werpu i didnt had the time
if you can "fix" our code, i can just do a mvn install again on my machine to test it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #514: Feature/myfaces 4466: Merge Pull request into main (RC5 Target) - Faces.js new scripts!
Posted by "werpu (via GitHub)" <gi...@apache.org>.
werpu commented on PR #514:
URL: https://github.com/apache/myfaces/pull/514#issuecomment-1427684325
Hi, given, I am still somewhat weak from the fever at the weekend, I will keep it short:
This is mostly a complexity reduction, because instead of 4-5 different target builds (without mapping files back then) we had in the original, we now have only two: production and development, but also we have mapping files. Thats all there is to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #514: Feature/myfaces 4466: Merge Pull request into main (RC5 Target) - Faces.js new scripts!
Posted by "melloware (via GitHub)" <gi...@apache.org>.
melloware commented on PR #514:
URL: https://github.com/apache/myfaces/pull/514#issuecomment-1428234669
I will second that I know this was a LOT of work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #514: Feature/myfaces 4466: Merge Pull request into main (RC5 Target) - Faces.js new scripts!
Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko commented on PR #514:
URL: https://github.com/apache/myfaces/pull/514#issuecomment-1427598038
@werpu i did a small review again and looks good
i just wonder if you could give a small explantation about the server side changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] werpu commented on pull request #514: Feature/myfaces 4466: Merge Pull request into main (RC5 Target) - Faces.js new scripts!
Posted by "werpu (via GitHub)" <gi...@apache.org>.
werpu commented on PR #514:
URL: https://github.com/apache/myfaces/pull/514#issuecomment-1425465831
need to check why it is failing the ajax integration test!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #514: Feature/myfaces 4466: Merge Pull request into main (RC5 Target) - Faces.js new scripts!
Posted by "tandraschko (via GitHub)" <gi...@apache.org>.
tandraschko commented on PR #514:
URL: https://github.com/apache/myfaces/pull/514#issuecomment-1428241292
the build somehow fails on localhost:
> myfaces.faces.ajax@1.0.0 test
> env TS_NODE_PROJECT=./tsconfig-myfaces.json mocha
Der Befehl "env" ist entweder falsch geschrieben oder konnte nicht gefunden werden.
any idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org