You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Yubi Lee <eu...@gmail.com> on 2022/09/21 01:43:45 UTC

Review Request 74132: RANGER-3924: Incrementing timestamp value for group and user is not 1sec but 60ms. It should be 1sec.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74132/
-----------------------------------------------------------

Review request for ranger.


Bugs: RANGER-3924
    https://issues.apache.org/jira/browse/RANGER-3924


Repository: ranger


Description
-------

As RANGER-1852 (https://github.com/apache/ranger/commit/38141722ee791f8ae0006247af148ed0bfa7db0c), incrementing timestamp value has become from 60s to 60ms.
However, it should be 1 sec. Maybe it is a mistake.

And the wrong value is inherited to LdapUserGroupBuilder.java with RANGER-2986 (https://github.com/apache/ranger/commit/4610df1fd126a07f1e19c5bed53e50742bb9f428#diff-5e58a9fb4de31652ab3ede63673d4b0ec614d540831027f02417612f36d7ae73R364-R373).


Diffs
-----

  ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java b1a6af183 


Diff: https://reviews.apache.org/r/74132/diff/1/


Testing
-------


Thanks,

Yubi Lee


Re: Review Request 74132: RANGER-3924: Incrementing timestamp value for group and user is not 1sec but 60ms. It should be 1sec.

Posted by Yubi Lee <eu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74132/
-----------------------------------------------------------

(Updated 10 15, 2022, 4:11 오전)


Review request for ranger.


Bugs: RANGER-3924
    https://issues.apache.org/jira/browse/RANGER-3924


Repository: ranger


Description (updated)
-------

As RANGER-1852 (https://github.com/apache/ranger/commit/38141722ee791f8ae0006247af148ed0bfa7db0c ), incrementing timestamp value has become from 60s to 60ms.
However, it should be 1 sec. Maybe it is a mistake.

And the wrong value is inherited to LdapUserGroupBuilder.java with RANGER-2986 (https://github.com/apache/ranger/commit/4610df1fd126a07f1e19c5bed53e50742bb9f428#diff-5e58a9fb4de31652ab3ede63673d4b0ec614d540831027f02417612f36d7ae73R364-R373 ).


Diffs
-----

  ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java b1a6af183 


Diff: https://reviews.apache.org/r/74132/diff/1/


Testing
-------


Thanks,

Yubi Lee