You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "heyihong (via GitHub)" <gi...@apache.org> on 2025/07/18 14:26:16 UTC
[PR] [SPARK-52448][CONNECT] Add simplified Struct Expression.Literal [spark]
heyihong opened a new pull request, #51561:
URL: https://github.com/apache/spark/pull/51561
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR improves the struct literal handling in Spark Connect protocol by enhancing the `LiteralValueProtoConverter` to better support the new struct literal format with named fields. The changes include:
1. **Enhanced struct field handling**: Updated the `toCatalystStruct` method to properly handle the new `fields` format in struct literals, which includes field names, values, data types, nullability, and metadata.
2. **Backward compatibility**: Maintained support for the deprecated `struct_type` and `elements` fields to ensure existing clients continue to work.
3. **Improved type inference**: Enhanced the `getInferredDataType` method to properly infer struct field types from the new field-based format.
4. **Testing**: Added test cases to verify both the new field-based struct literal format and backward compatibility with the old format.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
The current Expression.Struct literal is somewhat overcomplicated since it duplicates most of the information its fields already have. This is bulky to send over the wire, and it can be ambiguous.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No. This PR maintains backward compatibility with existing struct literal implementations while adding support for the new field-based format. Existing code using the deprecated `struct_type` and `elements` fields will continue to work without modification.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
`build/sbt "connect/testOnly *LiteralExpressionProtoConverterSuite"`
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
Generated-by: Cursor 1.2.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52448][CONNECT] Add simplified Struct Expression.Literal [spark]
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on code in PR #51561:
URL: https://github.com/apache/spark/pull/51561#discussion_r2219341431
##########
sql/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -227,8 +227,24 @@ message Expression {
}
message Struct {
- DataType struct_type = 1;
- repeated Literal elements = 2;
+ // (Deprecated) The data type of the struct. Only needs to be set if elements field is used.
+ // Consider using fields instead.
+ optional DataType struct_type = 1 [deprecated = true];
+
+ // (Deprecated) The elements of the struct. Consider using fields instead.
+ repeated Literal elements = 2 [deprecated = true];
+
+ repeated StructField fields = 3;
+
+ message StructField {
+ string name = 1;
Review Comment:
On second thought, it is not necessary to include the field name/data_type in every element, since not setting the data_type field should be sufficient for saving space.
##########
sql/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -227,8 +227,24 @@ message Expression {
}
message Struct {
- DataType struct_type = 1;
- repeated Literal elements = 2;
+ // (Deprecated) The data type of the struct. Only needs to be set if elements field is used.
+ // Consider using fields instead.
+ optional DataType struct_type = 1 [deprecated = true];
+
+ // (Deprecated) The elements of the struct. Consider using fields instead.
+ repeated Literal elements = 2 [deprecated = true];
+
+ repeated StructField fields = 3;
+
+ message StructField {
+ string name = 1;
Review Comment:
On second thought, it is not necessary to include the field name/data type in every element, since not setting the data_type field should be sufficient for saving space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52448][CONNECT] Add simplified Struct Expression.Literal [spark]
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on PR #51561:
URL: https://github.com/apache/spark/pull/51561#issuecomment-3096455591
@hvanhovell @HyukjinKwon @beliefer @zhengruifeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52448][CONNECT] Add simplified Struct Expression.Literal [spark]
Posted by "dengziming (via GitHub)" <gi...@apache.org>.
dengziming commented on code in PR #51561:
URL: https://github.com/apache/spark/pull/51561#discussion_r2217084830
##########
sql/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -227,8 +227,24 @@ message Expression {
}
message Struct {
- DataType struct_type = 1;
- repeated Literal elements = 2;
+ // (Deprecated) The data type of the struct. Only needs to be set if elements field is used.
+ // Consider using fields instead.
+ optional DataType struct_type = 1 [deprecated = true];
+
+ // (Deprecated) The elements of the struct. Consider using fields instead.
+ repeated Literal elements = 2 [deprecated = true];
+
+ repeated StructField fields = 3;
+
+ message StructField {
+ string name = 1;
Review Comment:
Thank you for this improvement. So we will contain the field name in every element, the space complexity would be O(n) compared to O(1) in the deprecated way? So what's the perf gain from this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52448][CONNECT] Add simplified Struct Expression.Literal [spark]
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on code in PR #51561:
URL: https://github.com/apache/spark/pull/51561#discussion_r2217901700
##########
sql/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -227,8 +227,24 @@ message Expression {
}
message Struct {
- DataType struct_type = 1;
- repeated Literal elements = 2;
+ // (Deprecated) The data type of the struct. Only needs to be set if elements field is used.
+ // Consider using fields instead.
+ optional DataType struct_type = 1 [deprecated = true];
+
+ // (Deprecated) The elements of the struct. Consider using fields instead.
+ repeated Literal elements = 2 [deprecated = true];
+
+ repeated StructField fields = 3;
+
+ message StructField {
+ string name = 1;
Review Comment:
My understanding is that the space complexity in the deprecated approach is also O(n), since every element includes the field name in the [struct_type](https://github.com/apache/spark/blob/master/sql/connect/common/src/main/protobuf/spark/connect/types.proto#L170-L180) field, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52448][CONNECT] Add simplified Struct Expression.Literal [spark]
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on code in PR #51561:
URL: https://github.com/apache/spark/pull/51561#discussion_r2219341431
##########
sql/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -227,8 +227,24 @@ message Expression {
}
message Struct {
- DataType struct_type = 1;
- repeated Literal elements = 2;
+ // (Deprecated) The data type of the struct. Only needs to be set if elements field is used.
+ // Consider using fields instead.
+ optional DataType struct_type = 1 [deprecated = true];
+
+ // (Deprecated) The elements of the struct. Consider using fields instead.
+ repeated Literal elements = 2 [deprecated = true];
+
+ repeated StructField fields = 3;
+
+ message StructField {
+ string name = 1;
Review Comment:
On second thought, it is not necessary to include the field name in every element, since not setting the data_type field should be sufficient for inferring types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52448][CONNECT] Add simplified Struct Expression.Literal [spark]
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on code in PR #51561:
URL: https://github.com/apache/spark/pull/51561#discussion_r2217901700
##########
sql/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -227,8 +227,24 @@ message Expression {
}
message Struct {
- DataType struct_type = 1;
- repeated Literal elements = 2;
+ // (Deprecated) The data type of the struct. Only needs to be set if elements field is used.
+ // Consider using fields instead.
+ optional DataType struct_type = 1 [deprecated = true];
+
+ // (Deprecated) The elements of the struct. Consider using fields instead.
+ repeated Literal elements = 2 [deprecated = true];
+
+ repeated StructField fields = 3;
+
+ message StructField {
+ string name = 1;
Review Comment:
My understanding is that the space complexity in the deprecated approach is also O(n), since every element includes the field name in the [struct_type field](https://github.com/apache/spark/blob/master/sql/connect/common/src/main/protobuf/spark/connect/types.proto#L170-L180), correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52448][CONNECT] Add simplified Struct Expression.Literal [spark]
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on code in PR #51561:
URL: https://github.com/apache/spark/pull/51561#discussion_r2217901700
##########
sql/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -227,8 +227,24 @@ message Expression {
}
message Struct {
- DataType struct_type = 1;
- repeated Literal elements = 2;
+ // (Deprecated) The data type of the struct. Only needs to be set if elements field is used.
+ // Consider using fields instead.
+ optional DataType struct_type = 1 [deprecated = true];
+
+ // (Deprecated) The elements of the struct. Consider using fields instead.
+ repeated Literal elements = 2 [deprecated = true];
+
+ repeated StructField fields = 3;
+
+ message StructField {
+ string name = 1;
Review Comment:
My understanding is that the space complexity in the deprecated approach is also O(n), since every element includes the field name in the [struct_type](https://github.com/apache/spark/blob/master/sql/connect/common/src/main/protobuf/spark/connect/types.proto#L170-L180) field, correct?
Also, it is possible to optimize the duplicate field names (e.g., for an array of structs) later by making them optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52448][CONNECT] Add simplified Struct Expression.Literal [spark]
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on code in PR #51561:
URL: https://github.com/apache/spark/pull/51561#discussion_r2293950991
##########
sql/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -227,8 +227,21 @@ message Expression {
}
message Struct {
- DataType struct_type = 1;
+ // (Deprecated) The type of the struct.
+ //
+ // This field is deprecated since Spark 4.1+ because using DataType as the type of a struct
+ // is ambiguous. This field should only be set if the data_type_struct field is not set.
+ // Use data_type_struct field instead.
+ DataType struct_type = 1 [deprecated = true];
+
+ // (Required) The literal values that make up the struct elements.
repeated Literal elements = 2;
+
+ // The type of the struct.
+ //
+ // Whether data_type_struct.fields.data_type should be set depends on
+ // whether each field's type can be inferred from the elements field.
+ DataType.Struct data_type_struct = 3;
Review Comment:
@zhengruifeng FYI, I simplified the implementation in this PR: https://github.com/apache/spark/pull/52098, but it's not necessary to introduce a new message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52448][CONNECT] Add simplified Struct Expression.Literal [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #51561:
URL: https://github.com/apache/spark/pull/51561#discussion_r2289834569
##########
sql/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -227,8 +227,21 @@ message Expression {
}
message Struct {
- DataType struct_type = 1;
+ // (Deprecated) The type of the struct.
+ //
+ // This field is deprecated since Spark 4.1+ because using DataType as the type of a struct
+ // is ambiguous. This field should only be set if the data_type_struct field is not set.
+ // Use data_type_struct field instead.
+ DataType struct_type = 1 [deprecated = true];
+
+ // (Required) The literal values that make up the struct elements.
repeated Literal elements = 2;
+
+ // The type of the struct.
+ //
+ // Whether data_type_struct.fields.data_type should be set depends on
+ // whether each field's type can be inferred from the elements field.
+ DataType.Struct data_type_struct = 3;
Review Comment:
@heyihong sorry for the late comments, what about introducing a new message for this purpose?
for example, `SimplifiedStruct` or `LightStruct`, my feeling is that the conversion in the server side become too complex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52448][CONNECT] Add simplified Struct Expression.Literal [spark]
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on code in PR #51561:
URL: https://github.com/apache/spark/pull/51561#discussion_r2219341431
##########
sql/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -227,8 +227,24 @@ message Expression {
}
message Struct {
- DataType struct_type = 1;
- repeated Literal elements = 2;
+ // (Deprecated) The data type of the struct. Only needs to be set if elements field is used.
+ // Consider using fields instead.
+ optional DataType struct_type = 1 [deprecated = true];
+
+ // (Deprecated) The elements of the struct. Consider using fields instead.
+ repeated Literal elements = 2 [deprecated = true];
+
+ repeated StructField fields = 3;
+
+ message StructField {
+ string name = 1;
Review Comment:
On second thought, it is not necessary to include the field name in every element, since not setting the data_type field should be sufficient for saving spaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52448][CONNECT] Add simplified Struct Expression.Literal [spark]
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on code in PR #51561:
URL: https://github.com/apache/spark/pull/51561#discussion_r2217901700
##########
sql/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -227,8 +227,24 @@ message Expression {
}
message Struct {
- DataType struct_type = 1;
- repeated Literal elements = 2;
+ // (Deprecated) The data type of the struct. Only needs to be set if elements field is used.
+ // Consider using fields instead.
+ optional DataType struct_type = 1 [deprecated = true];
+
+ // (Deprecated) The elements of the struct. Consider using fields instead.
+ repeated Literal elements = 2 [deprecated = true];
+
+ repeated StructField fields = 3;
+
+ message StructField {
+ string name = 1;
Review Comment:
My understanding is that the space complexity in the deprecated approach is also O(n), since every element includes the field name in the [struct_type](https://github.com/apache/spark/blob/master/sql/connect/common/src/main/protobuf/spark/connect/types.proto#L170-L180) field, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52448][CONNECT] Add simplified Struct Expression.Literal [spark]
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on code in PR #51561:
URL: https://github.com/apache/spark/pull/51561#discussion_r2219341431
##########
sql/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -227,8 +227,24 @@ message Expression {
}
message Struct {
- DataType struct_type = 1;
- repeated Literal elements = 2;
+ // (Deprecated) The data type of the struct. Only needs to be set if elements field is used.
+ // Consider using fields instead.
+ optional DataType struct_type = 1 [deprecated = true];
+
+ // (Deprecated) The elements of the struct. Consider using fields instead.
+ repeated Literal elements = 2 [deprecated = true];
+
+ repeated StructField fields = 3;
+
+ message StructField {
+ string name = 1;
Review Comment:
On second thought, it is not necessary to include the field name in every element, since not setting the data_type field should be sufficient for saving space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52448][CONNECT] Add simplified Struct Expression.Literal [spark]
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on code in PR #51561:
URL: https://github.com/apache/spark/pull/51561#discussion_r2217901700
##########
sql/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -227,8 +227,24 @@ message Expression {
}
message Struct {
- DataType struct_type = 1;
- repeated Literal elements = 2;
+ // (Deprecated) The data type of the struct. Only needs to be set if elements field is used.
+ // Consider using fields instead.
+ optional DataType struct_type = 1 [deprecated = true];
+
+ // (Deprecated) The elements of the struct. Consider using fields instead.
+ repeated Literal elements = 2 [deprecated = true];
+
+ repeated StructField fields = 3;
+
+ message StructField {
+ string name = 1;
Review Comment:
My understanding is that the space complexity in the deprecated approach is also O(n), since every element includes the field name in the [struct_type](https://github.com/apache/spark/blob/master/sql/connect/common/src/main/protobuf/spark/connect/types.proto#L170-L180) field, correct?
Also, it is possible to optimize the duplicate field names later by making them optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52448][CONNECT] Add simplified Struct Expression.Literal [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #51561: [SPARK-52448][CONNECT] Add simplified Struct Expression.Literal
URL: https://github.com/apache/spark/pull/51561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52448][CONNECT] Add simplified Struct Expression.Literal [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #51561:
URL: https://github.com/apache/spark/pull/51561#issuecomment-3099777385
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52448][CONNECT] Add simplified Struct Expression.Literal [spark]
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on code in PR #51561:
URL: https://github.com/apache/spark/pull/51561#discussion_r2293950991
##########
sql/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -227,8 +227,21 @@ message Expression {
}
message Struct {
- DataType struct_type = 1;
+ // (Deprecated) The type of the struct.
+ //
+ // This field is deprecated since Spark 4.1+ because using DataType as the type of a struct
+ // is ambiguous. This field should only be set if the data_type_struct field is not set.
+ // Use data_type_struct field instead.
+ DataType struct_type = 1 [deprecated = true];
+
+ // (Required) The literal values that make up the struct elements.
repeated Literal elements = 2;
+
+ // The type of the struct.
+ //
+ // Whether data_type_struct.fields.data_type should be set depends on
+ // whether each field's type can be inferred from the elements field.
+ DataType.Struct data_type_struct = 3;
Review Comment:
@zhengruifeng FYI, I simplified the implementation in this PR: https://github.com/apache/spark/pull/52098
, but it's not necessary to introduce a new message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org