[GitHub] mcculls commented on issue #169: [MNG-6344] Upgrade Guice to 4.2 wit AOP (cglib)

[GitBox <gi...@apache.org>]

mcculls commented on issue #169: [MNG-6344] Upgrade Guice to 4.2 wit AOP (cglib)
URL: https://github.com/apache/maven/pull/169#issuecomment-396177378
 
 
   Maven doesn't export any of the `com.google.inject` or `org.aopalliance` packages to plugins, so they're currently unable to take advantage of any AOP features (although maven-core could if it wished). The only reason to switch to the AOP build would be for the slightly faster reflection via CGLIB. Both CGLIB and ASM are embedded under an internal package, so there shouldn't be any clashes with other copies of these libraries on the classpath.
   
   However because the AOP build leans on CGLIB and ASM for reflection then it's affected more by recent JDK changes. For example while the latest release works fine on JDK 9, it needs a bump to ASM 6.2 to work properly on JDK 10+
   
   Given this, and because no plugins can use AOP until we export the packages from maven-core's `extension.xml`, we've kept with the no-AOP version. That may change if we want to start allowing AOP in plugins - but that's best done under a separate feature request, rather than at the same time as a version bump.
   
   HTH

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services