You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Joseph Wu (JIRA)" <ji...@apache.org> on 2015/09/18 22:29:05 UTC

[jira] [Commented] (MESOS-3459) Change /machine/up and /machine/down endpoints to take an array

    [ https://issues.apache.org/jira/browse/MESOS-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876334#comment-14876334 ] 

Joseph Wu commented on MESOS-3459:
----------------------------------

[~jvanremoortere] Committed:
{code}
commit cc0a847904510b80c72b9de70af9191b3d5b6c22
Author: Joseph Wu <jo...@mesosphere.io>
Date:   Fri Sep 18 13:07:38 2015 -0400

    Maintenance Primitives: Replaced MachineIDs with RepeatedPtrField<T>>.
    
    This removes the MachineIDs protobuf and changes it to instead use the
    RepeatedFieldPtr.
    This also changes the maintenance primitives (alpha) API for
    /machine/up and /machine/down, which both take an array instead of an
    object now.
    
    Review: https://reviews.apache.org/r/38011
{code}
{code}
commit 5f1195f8f10dc6fff65cb62a4745088e23bdc262
Author: Joseph Wu <jo...@mesosphere.io>
Date:   Fri Sep 18 12:44:03 2015 -0400

    Maintenance primitives: Used JSON instead of protobuf for errors.
    
    Replaces `__.DebugString()` with `stringify(JSON::Protobuf(__))`, which
    looks nicer and matches the JSON expected by the HTTP endpoints.
    
    Review: https://reviews.apache.org/r/37969
{code}

> Change /machine/up and /machine/down endpoints to take an array
> ---------------------------------------------------------------
>
>                 Key: MESOS-3459
>                 URL: https://issues.apache.org/jira/browse/MESOS-3459
>             Project: Mesos
>          Issue Type: Task
>          Components: master
>            Reporter: Joseph Wu
>            Assignee: Joseph Wu
>              Labels: mesosphere
>
> With [MESOS-3312] committed, the {{/machine/up}} and {{/machine/down}} endpoints should also take an input as an array.
> It is important to change this before maintenance primitives are released:
> https://reviews.apache.org/r/38011/
> Also, a minor change to the error message from these endpoints:
> https://reviews.apache.org/r/37969/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)