You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/11/25 10:38:14 UTC
[GitHub] [netbeans] neilcsmith-net opened a new pull request #3332: Switch to FlatLaf Light as default look and feel for IDE
neilcsmith-net opened a new pull request #3332:
URL: https://github.com/apache/netbeans/pull/3332
Switch to FlatLaf Light as default look and feel, and editor profile, for the IDE. This is the simplest approach using nb/ide.branding, so keeps the existing defaults for the platform, and the laf used for the upgrader dialog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net edited a comment on pull request #3332: Switch to FlatLaf Light as default look and feel for IDE
Posted by GitBox <gi...@apache.org>.
neilcsmith-net edited a comment on pull request #3332:
URL: https://github.com/apache/netbeans/pull/3332#issuecomment-979442853
Thanks @lkishalmi - it got simpler the more I looked at it.
@eirikbakke try it! It's what review is for. :wink:
The problem in that thread, and probably in your own platform application, is a missing dependency on the non-API `org.netbeans.swing.laf.flatlaf`. That module is autoload so doesn't kick in without one. We have that in `core.kit`. Having that module as autoload is a bug in my opinion. One perhaps to fix in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #3332: Switch to FlatLaf Light as default look and feel for IDE
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on pull request #3332:
URL: https://github.com/apache/netbeans/pull/3332#issuecomment-979432835
Did this approach successfully avoid the problems from the "The Options ruban remains white with DarkLaf" email thread, including on the very first startup with a clean user directory?
(In my own NetBeans Platform app, I noticed that simply setting "--laf com.formdev.flatlaf.FlatLightLaf" in app.conf did not work, due to the FlatLAF module not being loaded early enough in the startup sequence.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #3332: Switch to FlatLaf Light as default look and feel for IDE
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on pull request #3332:
URL: https://github.com/apache/netbeans/pull/3332#issuecomment-981861968
Sorry, I didn't get a chance to test this patch yet--but I'm sure it works fine!
(I'll apply it on my NetBeans Platform app eventually, though, and report problems if there are any.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3332: Switch to FlatLaf Light as default look and feel for IDE
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3332:
URL: https://github.com/apache/netbeans/pull/3332#issuecomment-979442853
@eirikbakke try it! It's what review is for. :wink:
The problem in that thread, and probably in your own platform application, is a missing dependency on the non-API `org.netbeans.swing.laf.flatlaf`. That module is autoload so doesn't kick in without one. We have that in `core.kit`. Having that module as autoload is a bug in my opinion. One perhaps to fix in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #3332: Switch to FlatLaf Light as default look and feel for IDE
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #3332:
URL: https://github.com/apache/netbeans/pull/3332#issuecomment-981988489
Looks Great!
The picture is taken from a new install of a freshly cut netbeans-dev Snap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net merged pull request #3332: Switch to FlatLaf Light as default look and feel for IDE
Posted by GitBox <gi...@apache.org>.
neilcsmith-net merged pull request #3332:
URL: https://github.com/apache/netbeans/pull/3332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] geertjanw commented on pull request #3332: Switch to FlatLaf Light as default look and feel for IDE
Posted by GitBox <gi...@apache.org>.
geertjanw commented on pull request #3332:
URL: https://github.com/apache/netbeans/pull/3332#issuecomment-981857357
Great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists