You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/11 11:21:39 UTC
[GitHub] [cloudstack] borisstoyanov opened a new issue #4462: restore vm does not attach back data disks
borisstoyanov opened a new issue #4462:
URL: https://github.com/apache/cloudstack/issues/4462
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and master branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete the comments.
-->
##### ISSUE TYPE
<!-- Pick one below and delete the rest -->
* Bug Report
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
API
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on master branch.
-->
~~~
4.15
~~~
##### CONFIGURATION
<!--
Information about the configuration if relevant, e.g. basic network, advanced networking, etc. N/A otherwise
-->
##### OS / ENVIRONMENT
<!--
Information about the environment if relevant, N/A otherwise
-->
##### SUMMARY
<!-- Explain the problem/feature briefly -->
data disks are left detached
##### STEPS TO REPRODUCE
<!--
For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
For new features, show how the feature would be used.
-->
<!-- Paste example playbooks or commands between quotes below -->
~~~
Steps: 1. Create a VM with at least 1 volume
2. Destroy the VM without expunging anything
3. Restore the VM
Observe the VM is being restored with it's root disk only, the data disk(s) are being left aside
~~~
<!-- You can also paste gist.github.com links for larger files -->
##### EXPECTED RESULTS
<!-- What did you expect to happen when running the steps above? -->
~~~
One should expect if a vm is restored, then it should end up in the same state as when it was deleted
~~~
##### ACTUAL RESULTS
<!-- What actually happened? -->
<!-- Paste verbatim command output between quotes below -->
~~~
VM has only root disk no data disks attached
~~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4462: restore vm does not attach back data disks
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4462:
URL: https://github.com/apache/cloudstack/issues/4462#issuecomment-820183068
New improvement issue https://github.com/apache/cloudstack/issues/4902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on issue #4462: restore vm does not attach back data disks
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #4462:
URL: https://github.com/apache/cloudstack/issues/4462#issuecomment-734259331
Was this tested to NOT be happening on VMware + 4.14? - so that we can see something is / is not different now in 4.15.
I also do recall that when VM is destroyed that disks are detached - this is an old behaviour for ages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #4462: restore vm does not attach back data disks
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #4462:
URL: https://github.com/apache/cloudstack/issues/4462#issuecomment-725406831
@borisstoyanov
I tested with 4.14 and cannot reproduce the issue.
what env do you use ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] PaulAngus commented on issue #4462: restore vm does not attach back data disks
Posted by GitBox <gi...@apache.org>.
PaulAngus commented on issue #4462:
URL: https://github.com/apache/cloudstack/issues/4462#issuecomment-732205371
@harikrishna-patnala
I'm not following the logic of what you're trying to achieve here.
If a user deletes a VM which has data disks (without expunging) then the disks get detached - as expected.
Disks are seen as first-class citizens; they can be attached to a VM, but they do not **_belong_** to a VM.
Therefore, at best a warning in the UI that the disks will be detached and will have to be re-attached to be used again is the most that could be required.
Restoring a VM is a fix for deleting something that you didn't mean to; so if:
A user has deleted their VM, then attaches the disks to another VM - which (because of above) is very likely (as otherwise, they would have deleted the data disks as well). Then they realise that they need the old VM back for some reason maybe get a config off it, - how are the disk(s) going to be reattached without breaking the second VM?
so right now I'm -1 on the PR and its premise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4462: restore vm does not attach back data disks
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4462:
URL: https://github.com/apache/cloudstack/issues/4462#issuecomment-730015117
@harikrishna-patnala @nvazquez any comments?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on issue #4462: restore vm does not attach back data disks
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on issue #4462:
URL: https://github.com/apache/cloudstack/issues/4462#issuecomment-730323095
Seems like a regression to me based on the changes made in destroy VM workflow in VMware. I'll verify and come back with a fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #4462: restore vm does not attach back data disks
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on issue #4462:
URL: https://github.com/apache/cloudstack/issues/4462#issuecomment-730180476
> Sounds to me as a bug to the restore functionality. Further if @weizhouapache cannot reproduce in 4.14 maybe it's a regerssion, since I've tested with latest Master.
@borisstoyanov might it be caused by #4307 ?
it has huge changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on issue #4462: restore vm does not attach back data disks
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #4462:
URL: https://github.com/apache/cloudstack/issues/4462#issuecomment-734267553
I guess I can answer my own questions - in 4.14/vmware disk are NOT detached on VM destroy, but they are on expunge.
From the functional point of view, that is LGTM - you are reverting back to the old behaviour, as in 4.14
From the PR4307 (and that is a complex one....) point of view - can you guarantee that this revert doesn't break anything now (is the gain worth the risk - this is the question)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #4462: restore vm does not attach back data disks
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4462:
URL: https://github.com/apache/cloudstack/issues/4462#issuecomment-725389362
@borisstoyanov any idea if this is a regression or a 'missing feature'?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on issue #4462: restore vm does not attach back data disks
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on issue #4462:
URL: https://github.com/apache/cloudstack/issues/4462#issuecomment-734269171
This will not harm or break anything as we are not reverting the detach operations but moving the detach operations from destroy workflow to expunge workflow. I'll kick off test matrix on the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #4462: restore vm does not attach back data disks
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4462:
URL: https://github.com/apache/cloudstack/issues/4462#issuecomment-725408567
@weizhouapache that would answer my question, @borisstoyanov reported 4.15 (master)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] borisstoyanov commented on issue #4462: restore vm does not attach back data disks
Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on issue #4462:
URL: https://github.com/apache/cloudstack/issues/4462#issuecomment-726602977
Sounds to me as a bug to the restore functionality. Further if @weizhouapache cannot reproduce in 4.14 maybe it's a regerssion, since I've tested with latest Master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on issue #4462: restore vm does not attach back data disks
Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on issue #4462:
URL: https://github.com/apache/cloudstack/issues/4462#issuecomment-733834456
My tests confirm that PR #4493 fixes this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4462: restore vm does not attach back data disks
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4462:
URL: https://github.com/apache/cloudstack/issues/4462#issuecomment-820182748
Fixed https://github.com/apache/cloudstack/pull/4493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed issue #4462: restore vm does not attach back data disks
Posted by GitBox <gi...@apache.org>.
rhtyd closed issue #4462:
URL: https://github.com/apache/cloudstack/issues/4462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org