You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/18 07:55:29 UTC
[GitHub] [flink] HuangXingBo opened a new pull request #11118:
[FLINK-16072][python] Optimize the performance of the write/read null mask
HuangXingBo opened a new pull request #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118
## What is the purpose of the change
*This pr optimize the performance of the write/read null mask*
## Brief change log
- *The decode/encode/write_null_mask/read_mask in FlattenRowCoder*
## Verifying this change
This change added tests and can be verified as follows:
- *It is a perforce improvement without extra function test*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu merged pull request #11118: [FLINK-16072][python]
Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
dianfu merged pull request #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11118:
[FLINK-16072][python] Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#issuecomment-587337576
<!--
Meta data
Hash:3bd212965eac342eb67cb216d47128405462889f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149401309 TriggerType:PUSH TriggerID:3bd212965eac342eb67cb216d47128405462889f
Hash:3bd212965eac342eb67cb216d47128405462889f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5265 TriggerType:PUSH TriggerID:3bd212965eac342eb67cb216d47128405462889f
Hash:7729a10a210e81cceb6ca909d2d7b73a93ae4c78 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5323 TriggerType:PUSH TriggerID:7729a10a210e81cceb6ca909d2d7b73a93ae4c78
Hash:7729a10a210e81cceb6ca909d2d7b73a93ae4c78 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149646256 TriggerType:PUSH TriggerID:7729a10a210e81cceb6ca909d2d7b73a93ae4c78
Hash:a0859b135ab2f39a8173500bbec3e289b84bb1d1 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:a0859b135ab2f39a8173500bbec3e289b84bb1d1
-->
## CI report:
* 3bd212965eac342eb67cb216d47128405462889f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149401309) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5265)
* 7729a10a210e81cceb6ca909d2d7b73a93ae4c78 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149646256) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5323)
* a0859b135ab2f39a8173500bbec3e289b84bb1d1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11118:
[FLINK-16072][python] Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#issuecomment-587337576
<!--
Meta data
Hash:3bd212965eac342eb67cb216d47128405462889f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149401309 TriggerType:PUSH TriggerID:3bd212965eac342eb67cb216d47128405462889f
Hash:3bd212965eac342eb67cb216d47128405462889f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5265 TriggerType:PUSH TriggerID:3bd212965eac342eb67cb216d47128405462889f
Hash:7729a10a210e81cceb6ca909d2d7b73a93ae4c78 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5323 TriggerType:PUSH TriggerID:7729a10a210e81cceb6ca909d2d7b73a93ae4c78
Hash:7729a10a210e81cceb6ca909d2d7b73a93ae4c78 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149646256 TriggerType:PUSH TriggerID:7729a10a210e81cceb6ca909d2d7b73a93ae4c78
-->
## CI report:
* 3bd212965eac342eb67cb216d47128405462889f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149401309) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5265)
* 7729a10a210e81cceb6ca909d2d7b73a93ae4c78 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149646256) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5323)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11118: [FLINK-16072][python]
Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#issuecomment-587337576
<!--
Meta data
Hash:3bd212965eac342eb67cb216d47128405462889f Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:3bd212965eac342eb67cb216d47128405462889f
-->
## CI report:
* 3bd212965eac342eb67cb216d47128405462889f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu commented on a change in pull request #11118:
[FLINK-16072][python] Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#discussion_r381200524
##########
File path: flink-python/pyflink/fn_execution/coder_impl.py
##########
@@ -25,56 +25,331 @@
class FlattenRowCoderImpl(StreamCoderImpl):
+ null_mask_search_table = ((False, False, False, False, False, False, False, False),
+ (False, False, False, False, False, False, False, True),
+ (False, False, False, False, False, False, True, False),
+ (False, False, False, False, False, False, True, True),
+ (False, False, False, False, False, True, False, False),
+ (False, False, False, False, False, True, False, True),
+ (False, False, False, False, False, True, True, False),
+ (False, False, False, False, False, True, True, True),
+ (False, False, False, False, True, False, False, False),
+ (False, False, False, False, True, False, False, True),
+ (False, False, False, False, True, False, True, False),
+ (False, False, False, False, True, False, True, True),
+ (False, False, False, False, True, True, False, False),
+ (False, False, False, False, True, True, False, True),
+ (False, False, False, False, True, True, True, False),
+ (False, False, False, False, True, True, True, True),
+ (False, False, False, True, False, False, False, False),
+ (False, False, False, True, False, False, False, True),
+ (False, False, False, True, False, False, True, False),
+ (False, False, False, True, False, False, True, True),
+ (False, False, False, True, False, True, False, False),
+ (False, False, False, True, False, True, False, True),
+ (False, False, False, True, False, True, True, False),
+ (False, False, False, True, False, True, True, True),
+ (False, False, False, True, True, False, False, False),
+ (False, False, False, True, True, False, False, True),
+ (False, False, False, True, True, False, True, False),
+ (False, False, False, True, True, False, True, True),
+ (False, False, False, True, True, True, False, False),
+ (False, False, False, True, True, True, False, True),
+ (False, False, False, True, True, True, True, False),
+ (False, False, False, True, True, True, True, True),
+ (False, False, True, False, False, False, False, False),
+ (False, False, True, False, False, False, False, True),
+ (False, False, True, False, False, False, True, False),
+ (False, False, True, False, False, False, True, True),
+ (False, False, True, False, False, True, False, False),
+ (False, False, True, False, False, True, False, True),
+ (False, False, True, False, False, True, True, False),
+ (False, False, True, False, False, True, True, True),
+ (False, False, True, False, True, False, False, False),
+ (False, False, True, False, True, False, False, True),
+ (False, False, True, False, True, False, True, False),
+ (False, False, True, False, True, False, True, True),
+ (False, False, True, False, True, True, False, False),
+ (False, False, True, False, True, True, False, True),
+ (False, False, True, False, True, True, True, False),
+ (False, False, True, False, True, True, True, True),
+ (False, False, True, True, False, False, False, False),
+ (False, False, True, True, False, False, False, True),
+ (False, False, True, True, False, False, True, False),
+ (False, False, True, True, False, False, True, True),
+ (False, False, True, True, False, True, False, False),
+ (False, False, True, True, False, True, False, True),
+ (False, False, True, True, False, True, True, False),
+ (False, False, True, True, False, True, True, True),
+ (False, False, True, True, True, False, False, False),
+ (False, False, True, True, True, False, False, True),
+ (False, False, True, True, True, False, True, False),
+ (False, False, True, True, True, False, True, True),
+ (False, False, True, True, True, True, False, False),
+ (False, False, True, True, True, True, False, True),
+ (False, False, True, True, True, True, True, False),
+ (False, False, True, True, True, True, True, True),
+ (False, True, False, False, False, False, False, False),
+ (False, True, False, False, False, False, False, True),
+ (False, True, False, False, False, False, True, False),
+ (False, True, False, False, False, False, True, True),
+ (False, True, False, False, False, True, False, False),
+ (False, True, False, False, False, True, False, True),
+ (False, True, False, False, False, True, True, False),
+ (False, True, False, False, False, True, True, True),
+ (False, True, False, False, True, False, False, False),
+ (False, True, False, False, True, False, False, True),
+ (False, True, False, False, True, False, True, False),
+ (False, True, False, False, True, False, True, True),
+ (False, True, False, False, True, True, False, False),
+ (False, True, False, False, True, True, False, True),
+ (False, True, False, False, True, True, True, False),
+ (False, True, False, False, True, True, True, True),
+ (False, True, False, True, False, False, False, False),
+ (False, True, False, True, False, False, False, True),
+ (False, True, False, True, False, False, True, False),
+ (False, True, False, True, False, False, True, True),
+ (False, True, False, True, False, True, False, False),
+ (False, True, False, True, False, True, False, True),
+ (False, True, False, True, False, True, True, False),
+ (False, True, False, True, False, True, True, True),
+ (False, True, False, True, True, False, False, False),
+ (False, True, False, True, True, False, False, True),
+ (False, True, False, True, True, False, True, False),
+ (False, True, False, True, True, False, True, True),
+ (False, True, False, True, True, True, False, False),
+ (False, True, False, True, True, True, False, True),
+ (False, True, False, True, True, True, True, False),
+ (False, True, False, True, True, True, True, True),
+ (False, True, True, False, False, False, False, False),
+ (False, True, True, False, False, False, False, True),
+ (False, True, True, False, False, False, True, False),
+ (False, True, True, False, False, False, True, True),
+ (False, True, True, False, False, True, False, False),
+ (False, True, True, False, False, True, False, True),
+ (False, True, True, False, False, True, True, False),
+ (False, True, True, False, False, True, True, True),
+ (False, True, True, False, True, False, False, False),
+ (False, True, True, False, True, False, False, True),
+ (False, True, True, False, True, False, True, False),
+ (False, True, True, False, True, False, True, True),
+ (False, True, True, False, True, True, False, False),
+ (False, True, True, False, True, True, False, True),
+ (False, True, True, False, True, True, True, False),
+ (False, True, True, False, True, True, True, True),
+ (False, True, True, True, False, False, False, False),
+ (False, True, True, True, False, False, False, True),
+ (False, True, True, True, False, False, True, False),
+ (False, True, True, True, False, False, True, True),
+ (False, True, True, True, False, True, False, False),
+ (False, True, True, True, False, True, False, True),
+ (False, True, True, True, False, True, True, False),
+ (False, True, True, True, False, True, True, True),
+ (False, True, True, True, True, False, False, False),
+ (False, True, True, True, True, False, False, True),
+ (False, True, True, True, True, False, True, False),
+ (False, True, True, True, True, False, True, True),
+ (False, True, True, True, True, True, False, False),
+ (False, True, True, True, True, True, False, True),
+ (False, True, True, True, True, True, True, False),
+ (False, True, True, True, True, True, True, True),
+ (True, False, False, False, False, False, False, False),
+ (True, False, False, False, False, False, False, True),
+ (True, False, False, False, False, False, True, False),
+ (True, False, False, False, False, False, True, True),
+ (True, False, False, False, False, True, False, False),
+ (True, False, False, False, False, True, False, True),
+ (True, False, False, False, False, True, True, False),
+ (True, False, False, False, False, True, True, True),
+ (True, False, False, False, True, False, False, False),
+ (True, False, False, False, True, False, False, True),
+ (True, False, False, False, True, False, True, False),
+ (True, False, False, False, True, False, True, True),
+ (True, False, False, False, True, True, False, False),
+ (True, False, False, False, True, True, False, True),
+ (True, False, False, False, True, True, True, False),
+ (True, False, False, False, True, True, True, True),
+ (True, False, False, True, False, False, False, False),
+ (True, False, False, True, False, False, False, True),
+ (True, False, False, True, False, False, True, False),
+ (True, False, False, True, False, False, True, True),
+ (True, False, False, True, False, True, False, False),
+ (True, False, False, True, False, True, False, True),
+ (True, False, False, True, False, True, True, False),
+ (True, False, False, True, False, True, True, True),
+ (True, False, False, True, True, False, False, False),
+ (True, False, False, True, True, False, False, True),
+ (True, False, False, True, True, False, True, False),
+ (True, False, False, True, True, False, True, True),
+ (True, False, False, True, True, True, False, False),
+ (True, False, False, True, True, True, False, True),
+ (True, False, False, True, True, True, True, False),
+ (True, False, False, True, True, True, True, True),
+ (True, False, True, False, False, False, False, False),
+ (True, False, True, False, False, False, False, True),
+ (True, False, True, False, False, False, True, False),
+ (True, False, True, False, False, False, True, True),
+ (True, False, True, False, False, True, False, False),
+ (True, False, True, False, False, True, False, True),
+ (True, False, True, False, False, True, True, False),
+ (True, False, True, False, False, True, True, True),
+ (True, False, True, False, True, False, False, False),
+ (True, False, True, False, True, False, False, True),
+ (True, False, True, False, True, False, True, False),
+ (True, False, True, False, True, False, True, True),
+ (True, False, True, False, True, True, False, False),
+ (True, False, True, False, True, True, False, True),
+ (True, False, True, False, True, True, True, False),
+ (True, False, True, False, True, True, True, True),
+ (True, False, True, True, False, False, False, False),
+ (True, False, True, True, False, False, False, True),
+ (True, False, True, True, False, False, True, False),
+ (True, False, True, True, False, False, True, True),
+ (True, False, True, True, False, True, False, False),
+ (True, False, True, True, False, True, False, True),
+ (True, False, True, True, False, True, True, False),
+ (True, False, True, True, False, True, True, True),
+ (True, False, True, True, True, False, False, False),
+ (True, False, True, True, True, False, False, True),
+ (True, False, True, True, True, False, True, False),
+ (True, False, True, True, True, False, True, True),
+ (True, False, True, True, True, True, False, False),
+ (True, False, True, True, True, True, False, True),
+ (True, False, True, True, True, True, True, False),
+ (True, False, True, True, True, True, True, True),
+ (True, True, False, False, False, False, False, False),
+ (True, True, False, False, False, False, False, True),
+ (True, True, False, False, False, False, True, False),
+ (True, True, False, False, False, False, True, True),
+ (True, True, False, False, False, True, False, False),
+ (True, True, False, False, False, True, False, True),
+ (True, True, False, False, False, True, True, False),
+ (True, True, False, False, False, True, True, True),
+ (True, True, False, False, True, False, False, False),
+ (True, True, False, False, True, False, False, True),
+ (True, True, False, False, True, False, True, False),
+ (True, True, False, False, True, False, True, True),
+ (True, True, False, False, True, True, False, False),
+ (True, True, False, False, True, True, False, True),
+ (True, True, False, False, True, True, True, False),
+ (True, True, False, False, True, True, True, True),
+ (True, True, False, True, False, False, False, False),
+ (True, True, False, True, False, False, False, True),
+ (True, True, False, True, False, False, True, False),
+ (True, True, False, True, False, False, True, True),
+ (True, True, False, True, False, True, False, False),
+ (True, True, False, True, False, True, False, True),
+ (True, True, False, True, False, True, True, False),
+ (True, True, False, True, False, True, True, True),
+ (True, True, False, True, True, False, False, False),
+ (True, True, False, True, True, False, False, True),
+ (True, True, False, True, True, False, True, False),
+ (True, True, False, True, True, False, True, True),
+ (True, True, False, True, True, True, False, False),
+ (True, True, False, True, True, True, False, True),
+ (True, True, False, True, True, True, True, False),
+ (True, True, False, True, True, True, True, True),
+ (True, True, True, False, False, False, False, False),
+ (True, True, True, False, False, False, False, True),
+ (True, True, True, False, False, False, True, False),
+ (True, True, True, False, False, False, True, True),
+ (True, True, True, False, False, True, False, False),
+ (True, True, True, False, False, True, False, True),
+ (True, True, True, False, False, True, True, False),
+ (True, True, True, False, False, True, True, True),
+ (True, True, True, False, True, False, False, False),
+ (True, True, True, False, True, False, False, True),
+ (True, True, True, False, True, False, True, False),
+ (True, True, True, False, True, False, True, True),
+ (True, True, True, False, True, True, False, False),
+ (True, True, True, False, True, True, False, True),
+ (True, True, True, False, True, True, True, False),
+ (True, True, True, False, True, True, True, True),
+ (True, True, True, True, False, False, False, False),
+ (True, True, True, True, False, False, False, True),
+ (True, True, True, True, False, False, True, False),
+ (True, True, True, True, False, False, True, True),
+ (True, True, True, True, False, True, False, False),
+ (True, True, True, True, False, True, False, True),
+ (True, True, True, True, False, True, True, False),
+ (True, True, True, True, False, True, True, True),
+ (True, True, True, True, True, False, False, False),
+ (True, True, True, True, True, False, False, True),
+ (True, True, True, True, True, False, True, False),
+ (True, True, True, True, True, False, True, True),
+ (True, True, True, True, True, True, False, False),
+ (True, True, True, True, True, True, False, True),
+ (True, True, True, True, True, True, True, False),
+ (True, True, True, True, True, True, True, True))
+
+ null_byte_search_table = (0x80, 0x40, 0x20, 0x10, 0x08, 0x04, 0x02, 0x01)
def __init__(self, field_coders):
self._field_coders = field_coders
self._filed_count = len(field_coders)
+ self._complete_byte_num = self._filed_count // 8
+ self._remaining_bit_num = self._filed_count % 8
def encode_to_stream(self, value, out_stream, nested):
- self.write_null_mask(value, out_stream)
+ self.write_null_mask(value, self._complete_byte_num, self._remaining_bit_num, out_stream)
for i in range(self._filed_count):
- if value[i] is not None:
- self._field_coders[i].encode_to_stream(value[i], out_stream, nested)
+ item = value[i]
+ if item is not None:
+ self._field_coders[i].encode_to_stream(item, out_stream, nested)
def decode_from_stream(self, in_stream, nested):
- null_mask = self.read_null_mask(self._filed_count, in_stream)
+ null_mask = self.read_null_mask(self._complete_byte_num, self._remaining_bit_num, in_stream)
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] HuangXingBo commented on issue #11118:
[FLINK-16072][python] Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on issue #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#issuecomment-588242398
Thanks a lot for @dianfu review, I have addressed the comments at the latest commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu commented on issue #11118: [FLINK-16072][python]
Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
dianfu commented on issue #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#issuecomment-588814305
@HuangXingBo Thanks for the update. LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu commented on a change in pull request #11118:
[FLINK-16072][python] Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#discussion_r381193279
##########
File path: flink-python/pyflink/fn_execution/coder_impl.py
##########
@@ -25,56 +25,331 @@
class FlattenRowCoderImpl(StreamCoderImpl):
+ null_mask_search_table = ((False, False, False, False, False, False, False, False),
+ (False, False, False, False, False, False, False, True),
+ (False, False, False, False, False, False, True, False),
+ (False, False, False, False, False, False, True, True),
+ (False, False, False, False, False, True, False, False),
+ (False, False, False, False, False, True, False, True),
+ (False, False, False, False, False, True, True, False),
+ (False, False, False, False, False, True, True, True),
+ (False, False, False, False, True, False, False, False),
+ (False, False, False, False, True, False, False, True),
+ (False, False, False, False, True, False, True, False),
+ (False, False, False, False, True, False, True, True),
+ (False, False, False, False, True, True, False, False),
+ (False, False, False, False, True, True, False, True),
+ (False, False, False, False, True, True, True, False),
+ (False, False, False, False, True, True, True, True),
+ (False, False, False, True, False, False, False, False),
+ (False, False, False, True, False, False, False, True),
+ (False, False, False, True, False, False, True, False),
+ (False, False, False, True, False, False, True, True),
+ (False, False, False, True, False, True, False, False),
+ (False, False, False, True, False, True, False, True),
+ (False, False, False, True, False, True, True, False),
+ (False, False, False, True, False, True, True, True),
+ (False, False, False, True, True, False, False, False),
+ (False, False, False, True, True, False, False, True),
+ (False, False, False, True, True, False, True, False),
+ (False, False, False, True, True, False, True, True),
+ (False, False, False, True, True, True, False, False),
+ (False, False, False, True, True, True, False, True),
+ (False, False, False, True, True, True, True, False),
+ (False, False, False, True, True, True, True, True),
+ (False, False, True, False, False, False, False, False),
+ (False, False, True, False, False, False, False, True),
+ (False, False, True, False, False, False, True, False),
+ (False, False, True, False, False, False, True, True),
+ (False, False, True, False, False, True, False, False),
+ (False, False, True, False, False, True, False, True),
+ (False, False, True, False, False, True, True, False),
+ (False, False, True, False, False, True, True, True),
+ (False, False, True, False, True, False, False, False),
+ (False, False, True, False, True, False, False, True),
+ (False, False, True, False, True, False, True, False),
+ (False, False, True, False, True, False, True, True),
+ (False, False, True, False, True, True, False, False),
+ (False, False, True, False, True, True, False, True),
+ (False, False, True, False, True, True, True, False),
+ (False, False, True, False, True, True, True, True),
+ (False, False, True, True, False, False, False, False),
+ (False, False, True, True, False, False, False, True),
+ (False, False, True, True, False, False, True, False),
+ (False, False, True, True, False, False, True, True),
+ (False, False, True, True, False, True, False, False),
+ (False, False, True, True, False, True, False, True),
+ (False, False, True, True, False, True, True, False),
+ (False, False, True, True, False, True, True, True),
+ (False, False, True, True, True, False, False, False),
+ (False, False, True, True, True, False, False, True),
+ (False, False, True, True, True, False, True, False),
+ (False, False, True, True, True, False, True, True),
+ (False, False, True, True, True, True, False, False),
+ (False, False, True, True, True, True, False, True),
+ (False, False, True, True, True, True, True, False),
+ (False, False, True, True, True, True, True, True),
+ (False, True, False, False, False, False, False, False),
+ (False, True, False, False, False, False, False, True),
+ (False, True, False, False, False, False, True, False),
+ (False, True, False, False, False, False, True, True),
+ (False, True, False, False, False, True, False, False),
+ (False, True, False, False, False, True, False, True),
+ (False, True, False, False, False, True, True, False),
+ (False, True, False, False, False, True, True, True),
+ (False, True, False, False, True, False, False, False),
+ (False, True, False, False, True, False, False, True),
+ (False, True, False, False, True, False, True, False),
+ (False, True, False, False, True, False, True, True),
+ (False, True, False, False, True, True, False, False),
+ (False, True, False, False, True, True, False, True),
+ (False, True, False, False, True, True, True, False),
+ (False, True, False, False, True, True, True, True),
+ (False, True, False, True, False, False, False, False),
+ (False, True, False, True, False, False, False, True),
+ (False, True, False, True, False, False, True, False),
+ (False, True, False, True, False, False, True, True),
+ (False, True, False, True, False, True, False, False),
+ (False, True, False, True, False, True, False, True),
+ (False, True, False, True, False, True, True, False),
+ (False, True, False, True, False, True, True, True),
+ (False, True, False, True, True, False, False, False),
+ (False, True, False, True, True, False, False, True),
+ (False, True, False, True, True, False, True, False),
+ (False, True, False, True, True, False, True, True),
+ (False, True, False, True, True, True, False, False),
+ (False, True, False, True, True, True, False, True),
+ (False, True, False, True, True, True, True, False),
+ (False, True, False, True, True, True, True, True),
+ (False, True, True, False, False, False, False, False),
+ (False, True, True, False, False, False, False, True),
+ (False, True, True, False, False, False, True, False),
+ (False, True, True, False, False, False, True, True),
+ (False, True, True, False, False, True, False, False),
+ (False, True, True, False, False, True, False, True),
+ (False, True, True, False, False, True, True, False),
+ (False, True, True, False, False, True, True, True),
+ (False, True, True, False, True, False, False, False),
+ (False, True, True, False, True, False, False, True),
+ (False, True, True, False, True, False, True, False),
+ (False, True, True, False, True, False, True, True),
+ (False, True, True, False, True, True, False, False),
+ (False, True, True, False, True, True, False, True),
+ (False, True, True, False, True, True, True, False),
+ (False, True, True, False, True, True, True, True),
+ (False, True, True, True, False, False, False, False),
+ (False, True, True, True, False, False, False, True),
+ (False, True, True, True, False, False, True, False),
+ (False, True, True, True, False, False, True, True),
+ (False, True, True, True, False, True, False, False),
+ (False, True, True, True, False, True, False, True),
+ (False, True, True, True, False, True, True, False),
+ (False, True, True, True, False, True, True, True),
+ (False, True, True, True, True, False, False, False),
+ (False, True, True, True, True, False, False, True),
+ (False, True, True, True, True, False, True, False),
+ (False, True, True, True, True, False, True, True),
+ (False, True, True, True, True, True, False, False),
+ (False, True, True, True, True, True, False, True),
+ (False, True, True, True, True, True, True, False),
+ (False, True, True, True, True, True, True, True),
+ (True, False, False, False, False, False, False, False),
+ (True, False, False, False, False, False, False, True),
+ (True, False, False, False, False, False, True, False),
+ (True, False, False, False, False, False, True, True),
+ (True, False, False, False, False, True, False, False),
+ (True, False, False, False, False, True, False, True),
+ (True, False, False, False, False, True, True, False),
+ (True, False, False, False, False, True, True, True),
+ (True, False, False, False, True, False, False, False),
+ (True, False, False, False, True, False, False, True),
+ (True, False, False, False, True, False, True, False),
+ (True, False, False, False, True, False, True, True),
+ (True, False, False, False, True, True, False, False),
+ (True, False, False, False, True, True, False, True),
+ (True, False, False, False, True, True, True, False),
+ (True, False, False, False, True, True, True, True),
+ (True, False, False, True, False, False, False, False),
+ (True, False, False, True, False, False, False, True),
+ (True, False, False, True, False, False, True, False),
+ (True, False, False, True, False, False, True, True),
+ (True, False, False, True, False, True, False, False),
+ (True, False, False, True, False, True, False, True),
+ (True, False, False, True, False, True, True, False),
+ (True, False, False, True, False, True, True, True),
+ (True, False, False, True, True, False, False, False),
+ (True, False, False, True, True, False, False, True),
+ (True, False, False, True, True, False, True, False),
+ (True, False, False, True, True, False, True, True),
+ (True, False, False, True, True, True, False, False),
+ (True, False, False, True, True, True, False, True),
+ (True, False, False, True, True, True, True, False),
+ (True, False, False, True, True, True, True, True),
+ (True, False, True, False, False, False, False, False),
+ (True, False, True, False, False, False, False, True),
+ (True, False, True, False, False, False, True, False),
+ (True, False, True, False, False, False, True, True),
+ (True, False, True, False, False, True, False, False),
+ (True, False, True, False, False, True, False, True),
+ (True, False, True, False, False, True, True, False),
+ (True, False, True, False, False, True, True, True),
+ (True, False, True, False, True, False, False, False),
+ (True, False, True, False, True, False, False, True),
+ (True, False, True, False, True, False, True, False),
+ (True, False, True, False, True, False, True, True),
+ (True, False, True, False, True, True, False, False),
+ (True, False, True, False, True, True, False, True),
+ (True, False, True, False, True, True, True, False),
+ (True, False, True, False, True, True, True, True),
+ (True, False, True, True, False, False, False, False),
+ (True, False, True, True, False, False, False, True),
+ (True, False, True, True, False, False, True, False),
+ (True, False, True, True, False, False, True, True),
+ (True, False, True, True, False, True, False, False),
+ (True, False, True, True, False, True, False, True),
+ (True, False, True, True, False, True, True, False),
+ (True, False, True, True, False, True, True, True),
+ (True, False, True, True, True, False, False, False),
+ (True, False, True, True, True, False, False, True),
+ (True, False, True, True, True, False, True, False),
+ (True, False, True, True, True, False, True, True),
+ (True, False, True, True, True, True, False, False),
+ (True, False, True, True, True, True, False, True),
+ (True, False, True, True, True, True, True, False),
+ (True, False, True, True, True, True, True, True),
+ (True, True, False, False, False, False, False, False),
+ (True, True, False, False, False, False, False, True),
+ (True, True, False, False, False, False, True, False),
+ (True, True, False, False, False, False, True, True),
+ (True, True, False, False, False, True, False, False),
+ (True, True, False, False, False, True, False, True),
+ (True, True, False, False, False, True, True, False),
+ (True, True, False, False, False, True, True, True),
+ (True, True, False, False, True, False, False, False),
+ (True, True, False, False, True, False, False, True),
+ (True, True, False, False, True, False, True, False),
+ (True, True, False, False, True, False, True, True),
+ (True, True, False, False, True, True, False, False),
+ (True, True, False, False, True, True, False, True),
+ (True, True, False, False, True, True, True, False),
+ (True, True, False, False, True, True, True, True),
+ (True, True, False, True, False, False, False, False),
+ (True, True, False, True, False, False, False, True),
+ (True, True, False, True, False, False, True, False),
+ (True, True, False, True, False, False, True, True),
+ (True, True, False, True, False, True, False, False),
+ (True, True, False, True, False, True, False, True),
+ (True, True, False, True, False, True, True, False),
+ (True, True, False, True, False, True, True, True),
+ (True, True, False, True, True, False, False, False),
+ (True, True, False, True, True, False, False, True),
+ (True, True, False, True, True, False, True, False),
+ (True, True, False, True, True, False, True, True),
+ (True, True, False, True, True, True, False, False),
+ (True, True, False, True, True, True, False, True),
+ (True, True, False, True, True, True, True, False),
+ (True, True, False, True, True, True, True, True),
+ (True, True, True, False, False, False, False, False),
+ (True, True, True, False, False, False, False, True),
+ (True, True, True, False, False, False, True, False),
+ (True, True, True, False, False, False, True, True),
+ (True, True, True, False, False, True, False, False),
+ (True, True, True, False, False, True, False, True),
+ (True, True, True, False, False, True, True, False),
+ (True, True, True, False, False, True, True, True),
+ (True, True, True, False, True, False, False, False),
+ (True, True, True, False, True, False, False, True),
+ (True, True, True, False, True, False, True, False),
+ (True, True, True, False, True, False, True, True),
+ (True, True, True, False, True, True, False, False),
+ (True, True, True, False, True, True, False, True),
+ (True, True, True, False, True, True, True, False),
+ (True, True, True, False, True, True, True, True),
+ (True, True, True, True, False, False, False, False),
+ (True, True, True, True, False, False, False, True),
+ (True, True, True, True, False, False, True, False),
+ (True, True, True, True, False, False, True, True),
+ (True, True, True, True, False, True, False, False),
+ (True, True, True, True, False, True, False, True),
+ (True, True, True, True, False, True, True, False),
+ (True, True, True, True, False, True, True, True),
+ (True, True, True, True, True, False, False, False),
+ (True, True, True, True, True, False, False, True),
+ (True, True, True, True, True, False, True, False),
+ (True, True, True, True, True, False, True, True),
+ (True, True, True, True, True, True, False, False),
+ (True, True, True, True, True, True, False, True),
+ (True, True, True, True, True, True, True, False),
+ (True, True, True, True, True, True, True, True))
+
+ null_byte_search_table = (0x80, 0x40, 0x20, 0x10, 0x08, 0x04, 0x02, 0x01)
def __init__(self, field_coders):
self._field_coders = field_coders
self._filed_count = len(field_coders)
+ self._complete_byte_num = self._filed_count // 8
Review comment:
What about renamed to _leading_bytes_num
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11118:
[FLINK-16072][python] Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#issuecomment-587337576
<!--
Meta data
Hash:3bd212965eac342eb67cb216d47128405462889f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149401309 TriggerType:PUSH TriggerID:3bd212965eac342eb67cb216d47128405462889f
Hash:3bd212965eac342eb67cb216d47128405462889f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5265 TriggerType:PUSH TriggerID:3bd212965eac342eb67cb216d47128405462889f
Hash:7729a10a210e81cceb6ca909d2d7b73a93ae4c78 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5323 TriggerType:PUSH TriggerID:7729a10a210e81cceb6ca909d2d7b73a93ae4c78
Hash:7729a10a210e81cceb6ca909d2d7b73a93ae4c78 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149646256 TriggerType:PUSH TriggerID:7729a10a210e81cceb6ca909d2d7b73a93ae4c78
-->
## CI report:
* 3bd212965eac342eb67cb216d47128405462889f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149401309) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5265)
* 7729a10a210e81cceb6ca909d2d7b73a93ae4c78 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149646256) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5323)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11118:
[FLINK-16072][python] Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#issuecomment-587337576
<!--
Meta data
Hash:3bd212965eac342eb67cb216d47128405462889f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149401309 TriggerType:PUSH TriggerID:3bd212965eac342eb67cb216d47128405462889f
Hash:3bd212965eac342eb67cb216d47128405462889f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5265 TriggerType:PUSH TriggerID:3bd212965eac342eb67cb216d47128405462889f
Hash:7729a10a210e81cceb6ca909d2d7b73a93ae4c78 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5323 TriggerType:PUSH TriggerID:7729a10a210e81cceb6ca909d2d7b73a93ae4c78
Hash:7729a10a210e81cceb6ca909d2d7b73a93ae4c78 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149646256 TriggerType:PUSH TriggerID:7729a10a210e81cceb6ca909d2d7b73a93ae4c78
Hash:a0859b135ab2f39a8173500bbec3e289b84bb1d1 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149783933 TriggerType:PUSH TriggerID:a0859b135ab2f39a8173500bbec3e289b84bb1d1
-->
## CI report:
* 3bd212965eac342eb67cb216d47128405462889f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149401309) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5265)
* 7729a10a210e81cceb6ca909d2d7b73a93ae4c78 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149646256) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5323)
* a0859b135ab2f39a8173500bbec3e289b84bb1d1 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149783933)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] HuangXingBo commented on a change in pull request #11118:
[FLINK-16072][python] Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on a change in pull request #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#discussion_r381302551
##########
File path: flink-python/pyflink/fn_execution/coder_impl.py
##########
@@ -25,56 +25,331 @@
class FlattenRowCoderImpl(StreamCoderImpl):
+ null_mask_search_table = ((False, False, False, False, False, False, False, False),
Review comment:
Yes. Good idea
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu commented on a change in pull request #11118:
[FLINK-16072][python] Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#discussion_r381304421
##########
File path: flink-python/pyflink/fn_execution/coder_impl.py
##########
@@ -24,57 +24,71 @@
from pyflink.table import Row
+def generate_null_mask_search_table():
+ """
+ Each bit of one byte represents if the column at the specified position is None or not, e.g.
+ 0x84 represents the first column and the sixth column are None.
+ """
+ num = 256
Review comment:
It seems that there is no need to introduce this variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11118:
[FLINK-16072][python] Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#issuecomment-587337576
<!--
Meta data
Hash:3bd212965eac342eb67cb216d47128405462889f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149401309 TriggerType:PUSH TriggerID:3bd212965eac342eb67cb216d47128405462889f
Hash:3bd212965eac342eb67cb216d47128405462889f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5265 TriggerType:PUSH TriggerID:3bd212965eac342eb67cb216d47128405462889f
Hash:7729a10a210e81cceb6ca909d2d7b73a93ae4c78 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5323 TriggerType:PUSH TriggerID:7729a10a210e81cceb6ca909d2d7b73a93ae4c78
Hash:7729a10a210e81cceb6ca909d2d7b73a93ae4c78 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149646256 TriggerType:PUSH TriggerID:7729a10a210e81cceb6ca909d2d7b73a93ae4c78
Hash:a0859b135ab2f39a8173500bbec3e289b84bb1d1 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149783933 TriggerType:PUSH TriggerID:a0859b135ab2f39a8173500bbec3e289b84bb1d1
-->
## CI report:
* 3bd212965eac342eb67cb216d47128405462889f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149401309) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5265)
* 7729a10a210e81cceb6ca909d2d7b73a93ae4c78 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149646256) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5323)
* a0859b135ab2f39a8173500bbec3e289b84bb1d1 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149783933)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu commented on a change in pull request #11118:
[FLINK-16072][python] Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#discussion_r381304831
##########
File path: flink-python/pyflink/fn_execution/coder_impl.py
##########
@@ -24,57 +24,71 @@
from pyflink.table import Row
+def generate_null_mask_search_table():
+ """
+ Each bit of one byte represents if the column at the specified position is None or not, e.g.
Review comment:
specified -> corresponding
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11118:
[FLINK-16072][python] Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#issuecomment-587337576
<!--
Meta data
Hash:3bd212965eac342eb67cb216d47128405462889f Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149401309 TriggerType:PUSH TriggerID:3bd212965eac342eb67cb216d47128405462889f
-->
## CI report:
* 3bd212965eac342eb67cb216d47128405462889f Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149401309)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11118: [FLINK-16072][python]
Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#issuecomment-587328532
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 3bd212965eac342eb67cb216d47128405462889f (Tue Feb 18 07:57:27 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-16072).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu commented on a change in pull request #11118:
[FLINK-16072][python] Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#discussion_r381725940
##########
File path: flink-python/pyflink/fn_execution/coder_impl.py
##########
@@ -24,57 +24,71 @@
from pyflink.table import Row
+def generate_null_mask_search_table():
Review comment:
Make it a private method of FlattenRowCoderImpl? I think there is no need to expose it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11118:
[FLINK-16072][python] Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#issuecomment-587337576
<!--
Meta data
Hash:3bd212965eac342eb67cb216d47128405462889f Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149401309 TriggerType:PUSH TriggerID:3bd212965eac342eb67cb216d47128405462889f
Hash:3bd212965eac342eb67cb216d47128405462889f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5265 TriggerType:PUSH TriggerID:3bd212965eac342eb67cb216d47128405462889f
-->
## CI report:
* 3bd212965eac342eb67cb216d47128405462889f Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149401309) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5265)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11118:
[FLINK-16072][python] Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#issuecomment-587337576
<!--
Meta data
Hash:3bd212965eac342eb67cb216d47128405462889f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149401309 TriggerType:PUSH TriggerID:3bd212965eac342eb67cb216d47128405462889f
Hash:3bd212965eac342eb67cb216d47128405462889f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5265 TriggerType:PUSH TriggerID:3bd212965eac342eb67cb216d47128405462889f
Hash:7729a10a210e81cceb6ca909d2d7b73a93ae4c78 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:7729a10a210e81cceb6ca909d2d7b73a93ae4c78
-->
## CI report:
* 3bd212965eac342eb67cb216d47128405462889f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149401309) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5265)
* 7729a10a210e81cceb6ca909d2d7b73a93ae4c78 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11118:
[FLINK-16072][python] Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#issuecomment-587337576
<!--
Meta data
Hash:3bd212965eac342eb67cb216d47128405462889f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149401309 TriggerType:PUSH TriggerID:3bd212965eac342eb67cb216d47128405462889f
Hash:3bd212965eac342eb67cb216d47128405462889f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5265 TriggerType:PUSH TriggerID:3bd212965eac342eb67cb216d47128405462889f
-->
## CI report:
* 3bd212965eac342eb67cb216d47128405462889f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149401309) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5265)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu commented on a change in pull request #11118:
[FLINK-16072][python] Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#discussion_r381768526
##########
File path: flink-python/pyflink/fn_execution/coder_impl.py
##########
@@ -24,57 +24,71 @@
from pyflink.table import Row
+def generate_null_mask_search_table():
+ """
+ Each bit of one byte represents if the column at the specified position is None or not, e.g.
+ 0x84 represents the first column and the sixth column are None.
+ """
+ num = 256
+ null_mask = []
+ for b in range(num):
+ every_num_null_mask = [(b & 0x80) > 0, (b & 0x40) > 0, (b & 0x20) > 0, (b & 0x10) > 0,
+ (b & 0x08) > 0, (b & 0x04) > 0, (b & 0x02) > 0, (b & 0x01) > 0]
+ null_mask.append(tuple(every_num_null_mask))
+
+ return tuple(null_mask)
+
+
class FlattenRowCoderImpl(StreamCoderImpl):
+ null_mask_search_table = generate_null_mask_search_table()
+
+ null_byte_search_table = (0x80, 0x40, 0x20, 0x10, 0x08, 0x04, 0x02, 0x01)
def __init__(self, field_coders):
self._field_coders = field_coders
self._filed_count = len(field_coders)
+ self._complete_byte_num = self._filed_count // 8
+ self._leading_bytes_num = self._filed_count % 8
def encode_to_stream(self, value, out_stream, nested):
self.write_null_mask(value, out_stream)
for i in range(self._filed_count):
- if value[i] is not None:
- self._field_coders[i].encode_to_stream(value[i], out_stream, nested)
+ item = value[i]
+ if item is not None:
+ self._field_coders[i].encode_to_stream(item, out_stream, nested)
def decode_from_stream(self, in_stream, nested):
- null_mask = self.read_null_mask(self._filed_count, in_stream)
+ null_mask = self.read_null_mask(in_stream)
return [None if null_mask[idx] else self._field_coders[idx].decode_from_stream(
in_stream, nested) for idx in range(0, self._filed_count)]
- @staticmethod
- def write_null_mask(value, out_stream):
Review comment:
Could we add some unit tests for the null mask related logic?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu commented on a change in pull request #11118:
[FLINK-16072][python] Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#discussion_r381769187
##########
File path: flink-python/pyflink/fn_execution/coder_impl.py
##########
@@ -25,56 +25,331 @@
class FlattenRowCoderImpl(StreamCoderImpl):
+ null_mask_search_table = ((False, False, False, False, False, False, False, False),
+ (False, False, False, False, False, False, False, True),
+ (False, False, False, False, False, False, True, False),
+ (False, False, False, False, False, False, True, True),
+ (False, False, False, False, False, True, False, False),
+ (False, False, False, False, False, True, False, True),
+ (False, False, False, False, False, True, True, False),
+ (False, False, False, False, False, True, True, True),
+ (False, False, False, False, True, False, False, False),
+ (False, False, False, False, True, False, False, True),
+ (False, False, False, False, True, False, True, False),
+ (False, False, False, False, True, False, True, True),
+ (False, False, False, False, True, True, False, False),
+ (False, False, False, False, True, True, False, True),
+ (False, False, False, False, True, True, True, False),
+ (False, False, False, False, True, True, True, True),
+ (False, False, False, True, False, False, False, False),
+ (False, False, False, True, False, False, False, True),
+ (False, False, False, True, False, False, True, False),
+ (False, False, False, True, False, False, True, True),
+ (False, False, False, True, False, True, False, False),
+ (False, False, False, True, False, True, False, True),
+ (False, False, False, True, False, True, True, False),
+ (False, False, False, True, False, True, True, True),
+ (False, False, False, True, True, False, False, False),
+ (False, False, False, True, True, False, False, True),
+ (False, False, False, True, True, False, True, False),
+ (False, False, False, True, True, False, True, True),
+ (False, False, False, True, True, True, False, False),
+ (False, False, False, True, True, True, False, True),
+ (False, False, False, True, True, True, True, False),
+ (False, False, False, True, True, True, True, True),
+ (False, False, True, False, False, False, False, False),
+ (False, False, True, False, False, False, False, True),
+ (False, False, True, False, False, False, True, False),
+ (False, False, True, False, False, False, True, True),
+ (False, False, True, False, False, True, False, False),
+ (False, False, True, False, False, True, False, True),
+ (False, False, True, False, False, True, True, False),
+ (False, False, True, False, False, True, True, True),
+ (False, False, True, False, True, False, False, False),
+ (False, False, True, False, True, False, False, True),
+ (False, False, True, False, True, False, True, False),
+ (False, False, True, False, True, False, True, True),
+ (False, False, True, False, True, True, False, False),
+ (False, False, True, False, True, True, False, True),
+ (False, False, True, False, True, True, True, False),
+ (False, False, True, False, True, True, True, True),
+ (False, False, True, True, False, False, False, False),
+ (False, False, True, True, False, False, False, True),
+ (False, False, True, True, False, False, True, False),
+ (False, False, True, True, False, False, True, True),
+ (False, False, True, True, False, True, False, False),
+ (False, False, True, True, False, True, False, True),
+ (False, False, True, True, False, True, True, False),
+ (False, False, True, True, False, True, True, True),
+ (False, False, True, True, True, False, False, False),
+ (False, False, True, True, True, False, False, True),
+ (False, False, True, True, True, False, True, False),
+ (False, False, True, True, True, False, True, True),
+ (False, False, True, True, True, True, False, False),
+ (False, False, True, True, True, True, False, True),
+ (False, False, True, True, True, True, True, False),
+ (False, False, True, True, True, True, True, True),
+ (False, True, False, False, False, False, False, False),
+ (False, True, False, False, False, False, False, True),
+ (False, True, False, False, False, False, True, False),
+ (False, True, False, False, False, False, True, True),
+ (False, True, False, False, False, True, False, False),
+ (False, True, False, False, False, True, False, True),
+ (False, True, False, False, False, True, True, False),
+ (False, True, False, False, False, True, True, True),
+ (False, True, False, False, True, False, False, False),
+ (False, True, False, False, True, False, False, True),
+ (False, True, False, False, True, False, True, False),
+ (False, True, False, False, True, False, True, True),
+ (False, True, False, False, True, True, False, False),
+ (False, True, False, False, True, True, False, True),
+ (False, True, False, False, True, True, True, False),
+ (False, True, False, False, True, True, True, True),
+ (False, True, False, True, False, False, False, False),
+ (False, True, False, True, False, False, False, True),
+ (False, True, False, True, False, False, True, False),
+ (False, True, False, True, False, False, True, True),
+ (False, True, False, True, False, True, False, False),
+ (False, True, False, True, False, True, False, True),
+ (False, True, False, True, False, True, True, False),
+ (False, True, False, True, False, True, True, True),
+ (False, True, False, True, True, False, False, False),
+ (False, True, False, True, True, False, False, True),
+ (False, True, False, True, True, False, True, False),
+ (False, True, False, True, True, False, True, True),
+ (False, True, False, True, True, True, False, False),
+ (False, True, False, True, True, True, False, True),
+ (False, True, False, True, True, True, True, False),
+ (False, True, False, True, True, True, True, True),
+ (False, True, True, False, False, False, False, False),
+ (False, True, True, False, False, False, False, True),
+ (False, True, True, False, False, False, True, False),
+ (False, True, True, False, False, False, True, True),
+ (False, True, True, False, False, True, False, False),
+ (False, True, True, False, False, True, False, True),
+ (False, True, True, False, False, True, True, False),
+ (False, True, True, False, False, True, True, True),
+ (False, True, True, False, True, False, False, False),
+ (False, True, True, False, True, False, False, True),
+ (False, True, True, False, True, False, True, False),
+ (False, True, True, False, True, False, True, True),
+ (False, True, True, False, True, True, False, False),
+ (False, True, True, False, True, True, False, True),
+ (False, True, True, False, True, True, True, False),
+ (False, True, True, False, True, True, True, True),
+ (False, True, True, True, False, False, False, False),
+ (False, True, True, True, False, False, False, True),
+ (False, True, True, True, False, False, True, False),
+ (False, True, True, True, False, False, True, True),
+ (False, True, True, True, False, True, False, False),
+ (False, True, True, True, False, True, False, True),
+ (False, True, True, True, False, True, True, False),
+ (False, True, True, True, False, True, True, True),
+ (False, True, True, True, True, False, False, False),
+ (False, True, True, True, True, False, False, True),
+ (False, True, True, True, True, False, True, False),
+ (False, True, True, True, True, False, True, True),
+ (False, True, True, True, True, True, False, False),
+ (False, True, True, True, True, True, False, True),
+ (False, True, True, True, True, True, True, False),
+ (False, True, True, True, True, True, True, True),
+ (True, False, False, False, False, False, False, False),
+ (True, False, False, False, False, False, False, True),
+ (True, False, False, False, False, False, True, False),
+ (True, False, False, False, False, False, True, True),
+ (True, False, False, False, False, True, False, False),
+ (True, False, False, False, False, True, False, True),
+ (True, False, False, False, False, True, True, False),
+ (True, False, False, False, False, True, True, True),
+ (True, False, False, False, True, False, False, False),
+ (True, False, False, False, True, False, False, True),
+ (True, False, False, False, True, False, True, False),
+ (True, False, False, False, True, False, True, True),
+ (True, False, False, False, True, True, False, False),
+ (True, False, False, False, True, True, False, True),
+ (True, False, False, False, True, True, True, False),
+ (True, False, False, False, True, True, True, True),
+ (True, False, False, True, False, False, False, False),
+ (True, False, False, True, False, False, False, True),
+ (True, False, False, True, False, False, True, False),
+ (True, False, False, True, False, False, True, True),
+ (True, False, False, True, False, True, False, False),
+ (True, False, False, True, False, True, False, True),
+ (True, False, False, True, False, True, True, False),
+ (True, False, False, True, False, True, True, True),
+ (True, False, False, True, True, False, False, False),
+ (True, False, False, True, True, False, False, True),
+ (True, False, False, True, True, False, True, False),
+ (True, False, False, True, True, False, True, True),
+ (True, False, False, True, True, True, False, False),
+ (True, False, False, True, True, True, False, True),
+ (True, False, False, True, True, True, True, False),
+ (True, False, False, True, True, True, True, True),
+ (True, False, True, False, False, False, False, False),
+ (True, False, True, False, False, False, False, True),
+ (True, False, True, False, False, False, True, False),
+ (True, False, True, False, False, False, True, True),
+ (True, False, True, False, False, True, False, False),
+ (True, False, True, False, False, True, False, True),
+ (True, False, True, False, False, True, True, False),
+ (True, False, True, False, False, True, True, True),
+ (True, False, True, False, True, False, False, False),
+ (True, False, True, False, True, False, False, True),
+ (True, False, True, False, True, False, True, False),
+ (True, False, True, False, True, False, True, True),
+ (True, False, True, False, True, True, False, False),
+ (True, False, True, False, True, True, False, True),
+ (True, False, True, False, True, True, True, False),
+ (True, False, True, False, True, True, True, True),
+ (True, False, True, True, False, False, False, False),
+ (True, False, True, True, False, False, False, True),
+ (True, False, True, True, False, False, True, False),
+ (True, False, True, True, False, False, True, True),
+ (True, False, True, True, False, True, False, False),
+ (True, False, True, True, False, True, False, True),
+ (True, False, True, True, False, True, True, False),
+ (True, False, True, True, False, True, True, True),
+ (True, False, True, True, True, False, False, False),
+ (True, False, True, True, True, False, False, True),
+ (True, False, True, True, True, False, True, False),
+ (True, False, True, True, True, False, True, True),
+ (True, False, True, True, True, True, False, False),
+ (True, False, True, True, True, True, False, True),
+ (True, False, True, True, True, True, True, False),
+ (True, False, True, True, True, True, True, True),
+ (True, True, False, False, False, False, False, False),
+ (True, True, False, False, False, False, False, True),
+ (True, True, False, False, False, False, True, False),
+ (True, True, False, False, False, False, True, True),
+ (True, True, False, False, False, True, False, False),
+ (True, True, False, False, False, True, False, True),
+ (True, True, False, False, False, True, True, False),
+ (True, True, False, False, False, True, True, True),
+ (True, True, False, False, True, False, False, False),
+ (True, True, False, False, True, False, False, True),
+ (True, True, False, False, True, False, True, False),
+ (True, True, False, False, True, False, True, True),
+ (True, True, False, False, True, True, False, False),
+ (True, True, False, False, True, True, False, True),
+ (True, True, False, False, True, True, True, False),
+ (True, True, False, False, True, True, True, True),
+ (True, True, False, True, False, False, False, False),
+ (True, True, False, True, False, False, False, True),
+ (True, True, False, True, False, False, True, False),
+ (True, True, False, True, False, False, True, True),
+ (True, True, False, True, False, True, False, False),
+ (True, True, False, True, False, True, False, True),
+ (True, True, False, True, False, True, True, False),
+ (True, True, False, True, False, True, True, True),
+ (True, True, False, True, True, False, False, False),
+ (True, True, False, True, True, False, False, True),
+ (True, True, False, True, True, False, True, False),
+ (True, True, False, True, True, False, True, True),
+ (True, True, False, True, True, True, False, False),
+ (True, True, False, True, True, True, False, True),
+ (True, True, False, True, True, True, True, False),
+ (True, True, False, True, True, True, True, True),
+ (True, True, True, False, False, False, False, False),
+ (True, True, True, False, False, False, False, True),
+ (True, True, True, False, False, False, True, False),
+ (True, True, True, False, False, False, True, True),
+ (True, True, True, False, False, True, False, False),
+ (True, True, True, False, False, True, False, True),
+ (True, True, True, False, False, True, True, False),
+ (True, True, True, False, False, True, True, True),
+ (True, True, True, False, True, False, False, False),
+ (True, True, True, False, True, False, False, True),
+ (True, True, True, False, True, False, True, False),
+ (True, True, True, False, True, False, True, True),
+ (True, True, True, False, True, True, False, False),
+ (True, True, True, False, True, True, False, True),
+ (True, True, True, False, True, True, True, False),
+ (True, True, True, False, True, True, True, True),
+ (True, True, True, True, False, False, False, False),
+ (True, True, True, True, False, False, False, True),
+ (True, True, True, True, False, False, True, False),
+ (True, True, True, True, False, False, True, True),
+ (True, True, True, True, False, True, False, False),
+ (True, True, True, True, False, True, False, True),
+ (True, True, True, True, False, True, True, False),
+ (True, True, True, True, False, True, True, True),
+ (True, True, True, True, True, False, False, False),
+ (True, True, True, True, True, False, False, True),
+ (True, True, True, True, True, False, True, False),
+ (True, True, True, True, True, False, True, True),
+ (True, True, True, True, True, True, False, False),
+ (True, True, True, True, True, True, False, True),
+ (True, True, True, True, True, True, True, False),
+ (True, True, True, True, True, True, True, True))
+
+ null_byte_search_table = (0x80, 0x40, 0x20, 0x10, 0x08, 0x04, 0x02, 0x01)
def __init__(self, field_coders):
self._field_coders = field_coders
self._filed_count = len(field_coders)
+ self._complete_byte_num = self._filed_count // 8
Review comment:
_complete_byte_num -> _leading_complete_bytes_num
_leading_bytes_num -> _remaining_bits_num
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu commented on a change in pull request #11118:
[FLINK-16072][python] Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#discussion_r381188340
##########
File path: flink-python/pyflink/fn_execution/coder_impl.py
##########
@@ -25,56 +25,331 @@
class FlattenRowCoderImpl(StreamCoderImpl):
+ null_mask_search_table = ((False, False, False, False, False, False, False, False),
Review comment:
Could we generate this search table using one function? Besides, it would be great to add some comments on how to generate the search table. It will make it more readable and maintainable. What's your thought?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu commented on a change in pull request #11118:
[FLINK-16072][python] Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#discussion_r381195297
##########
File path: flink-python/pyflink/fn_execution/coder_impl.py
##########
@@ -25,56 +25,331 @@
class FlattenRowCoderImpl(StreamCoderImpl):
+ null_mask_search_table = ((False, False, False, False, False, False, False, False),
+ (False, False, False, False, False, False, False, True),
+ (False, False, False, False, False, False, True, False),
+ (False, False, False, False, False, False, True, True),
+ (False, False, False, False, False, True, False, False),
+ (False, False, False, False, False, True, False, True),
+ (False, False, False, False, False, True, True, False),
+ (False, False, False, False, False, True, True, True),
+ (False, False, False, False, True, False, False, False),
+ (False, False, False, False, True, False, False, True),
+ (False, False, False, False, True, False, True, False),
+ (False, False, False, False, True, False, True, True),
+ (False, False, False, False, True, True, False, False),
+ (False, False, False, False, True, True, False, True),
+ (False, False, False, False, True, True, True, False),
+ (False, False, False, False, True, True, True, True),
+ (False, False, False, True, False, False, False, False),
+ (False, False, False, True, False, False, False, True),
+ (False, False, False, True, False, False, True, False),
+ (False, False, False, True, False, False, True, True),
+ (False, False, False, True, False, True, False, False),
+ (False, False, False, True, False, True, False, True),
+ (False, False, False, True, False, True, True, False),
+ (False, False, False, True, False, True, True, True),
+ (False, False, False, True, True, False, False, False),
+ (False, False, False, True, True, False, False, True),
+ (False, False, False, True, True, False, True, False),
+ (False, False, False, True, True, False, True, True),
+ (False, False, False, True, True, True, False, False),
+ (False, False, False, True, True, True, False, True),
+ (False, False, False, True, True, True, True, False),
+ (False, False, False, True, True, True, True, True),
+ (False, False, True, False, False, False, False, False),
+ (False, False, True, False, False, False, False, True),
+ (False, False, True, False, False, False, True, False),
+ (False, False, True, False, False, False, True, True),
+ (False, False, True, False, False, True, False, False),
+ (False, False, True, False, False, True, False, True),
+ (False, False, True, False, False, True, True, False),
+ (False, False, True, False, False, True, True, True),
+ (False, False, True, False, True, False, False, False),
+ (False, False, True, False, True, False, False, True),
+ (False, False, True, False, True, False, True, False),
+ (False, False, True, False, True, False, True, True),
+ (False, False, True, False, True, True, False, False),
+ (False, False, True, False, True, True, False, True),
+ (False, False, True, False, True, True, True, False),
+ (False, False, True, False, True, True, True, True),
+ (False, False, True, True, False, False, False, False),
+ (False, False, True, True, False, False, False, True),
+ (False, False, True, True, False, False, True, False),
+ (False, False, True, True, False, False, True, True),
+ (False, False, True, True, False, True, False, False),
+ (False, False, True, True, False, True, False, True),
+ (False, False, True, True, False, True, True, False),
+ (False, False, True, True, False, True, True, True),
+ (False, False, True, True, True, False, False, False),
+ (False, False, True, True, True, False, False, True),
+ (False, False, True, True, True, False, True, False),
+ (False, False, True, True, True, False, True, True),
+ (False, False, True, True, True, True, False, False),
+ (False, False, True, True, True, True, False, True),
+ (False, False, True, True, True, True, True, False),
+ (False, False, True, True, True, True, True, True),
+ (False, True, False, False, False, False, False, False),
+ (False, True, False, False, False, False, False, True),
+ (False, True, False, False, False, False, True, False),
+ (False, True, False, False, False, False, True, True),
+ (False, True, False, False, False, True, False, False),
+ (False, True, False, False, False, True, False, True),
+ (False, True, False, False, False, True, True, False),
+ (False, True, False, False, False, True, True, True),
+ (False, True, False, False, True, False, False, False),
+ (False, True, False, False, True, False, False, True),
+ (False, True, False, False, True, False, True, False),
+ (False, True, False, False, True, False, True, True),
+ (False, True, False, False, True, True, False, False),
+ (False, True, False, False, True, True, False, True),
+ (False, True, False, False, True, True, True, False),
+ (False, True, False, False, True, True, True, True),
+ (False, True, False, True, False, False, False, False),
+ (False, True, False, True, False, False, False, True),
+ (False, True, False, True, False, False, True, False),
+ (False, True, False, True, False, False, True, True),
+ (False, True, False, True, False, True, False, False),
+ (False, True, False, True, False, True, False, True),
+ (False, True, False, True, False, True, True, False),
+ (False, True, False, True, False, True, True, True),
+ (False, True, False, True, True, False, False, False),
+ (False, True, False, True, True, False, False, True),
+ (False, True, False, True, True, False, True, False),
+ (False, True, False, True, True, False, True, True),
+ (False, True, False, True, True, True, False, False),
+ (False, True, False, True, True, True, False, True),
+ (False, True, False, True, True, True, True, False),
+ (False, True, False, True, True, True, True, True),
+ (False, True, True, False, False, False, False, False),
+ (False, True, True, False, False, False, False, True),
+ (False, True, True, False, False, False, True, False),
+ (False, True, True, False, False, False, True, True),
+ (False, True, True, False, False, True, False, False),
+ (False, True, True, False, False, True, False, True),
+ (False, True, True, False, False, True, True, False),
+ (False, True, True, False, False, True, True, True),
+ (False, True, True, False, True, False, False, False),
+ (False, True, True, False, True, False, False, True),
+ (False, True, True, False, True, False, True, False),
+ (False, True, True, False, True, False, True, True),
+ (False, True, True, False, True, True, False, False),
+ (False, True, True, False, True, True, False, True),
+ (False, True, True, False, True, True, True, False),
+ (False, True, True, False, True, True, True, True),
+ (False, True, True, True, False, False, False, False),
+ (False, True, True, True, False, False, False, True),
+ (False, True, True, True, False, False, True, False),
+ (False, True, True, True, False, False, True, True),
+ (False, True, True, True, False, True, False, False),
+ (False, True, True, True, False, True, False, True),
+ (False, True, True, True, False, True, True, False),
+ (False, True, True, True, False, True, True, True),
+ (False, True, True, True, True, False, False, False),
+ (False, True, True, True, True, False, False, True),
+ (False, True, True, True, True, False, True, False),
+ (False, True, True, True, True, False, True, True),
+ (False, True, True, True, True, True, False, False),
+ (False, True, True, True, True, True, False, True),
+ (False, True, True, True, True, True, True, False),
+ (False, True, True, True, True, True, True, True),
+ (True, False, False, False, False, False, False, False),
+ (True, False, False, False, False, False, False, True),
+ (True, False, False, False, False, False, True, False),
+ (True, False, False, False, False, False, True, True),
+ (True, False, False, False, False, True, False, False),
+ (True, False, False, False, False, True, False, True),
+ (True, False, False, False, False, True, True, False),
+ (True, False, False, False, False, True, True, True),
+ (True, False, False, False, True, False, False, False),
+ (True, False, False, False, True, False, False, True),
+ (True, False, False, False, True, False, True, False),
+ (True, False, False, False, True, False, True, True),
+ (True, False, False, False, True, True, False, False),
+ (True, False, False, False, True, True, False, True),
+ (True, False, False, False, True, True, True, False),
+ (True, False, False, False, True, True, True, True),
+ (True, False, False, True, False, False, False, False),
+ (True, False, False, True, False, False, False, True),
+ (True, False, False, True, False, False, True, False),
+ (True, False, False, True, False, False, True, True),
+ (True, False, False, True, False, True, False, False),
+ (True, False, False, True, False, True, False, True),
+ (True, False, False, True, False, True, True, False),
+ (True, False, False, True, False, True, True, True),
+ (True, False, False, True, True, False, False, False),
+ (True, False, False, True, True, False, False, True),
+ (True, False, False, True, True, False, True, False),
+ (True, False, False, True, True, False, True, True),
+ (True, False, False, True, True, True, False, False),
+ (True, False, False, True, True, True, False, True),
+ (True, False, False, True, True, True, True, False),
+ (True, False, False, True, True, True, True, True),
+ (True, False, True, False, False, False, False, False),
+ (True, False, True, False, False, False, False, True),
+ (True, False, True, False, False, False, True, False),
+ (True, False, True, False, False, False, True, True),
+ (True, False, True, False, False, True, False, False),
+ (True, False, True, False, False, True, False, True),
+ (True, False, True, False, False, True, True, False),
+ (True, False, True, False, False, True, True, True),
+ (True, False, True, False, True, False, False, False),
+ (True, False, True, False, True, False, False, True),
+ (True, False, True, False, True, False, True, False),
+ (True, False, True, False, True, False, True, True),
+ (True, False, True, False, True, True, False, False),
+ (True, False, True, False, True, True, False, True),
+ (True, False, True, False, True, True, True, False),
+ (True, False, True, False, True, True, True, True),
+ (True, False, True, True, False, False, False, False),
+ (True, False, True, True, False, False, False, True),
+ (True, False, True, True, False, False, True, False),
+ (True, False, True, True, False, False, True, True),
+ (True, False, True, True, False, True, False, False),
+ (True, False, True, True, False, True, False, True),
+ (True, False, True, True, False, True, True, False),
+ (True, False, True, True, False, True, True, True),
+ (True, False, True, True, True, False, False, False),
+ (True, False, True, True, True, False, False, True),
+ (True, False, True, True, True, False, True, False),
+ (True, False, True, True, True, False, True, True),
+ (True, False, True, True, True, True, False, False),
+ (True, False, True, True, True, True, False, True),
+ (True, False, True, True, True, True, True, False),
+ (True, False, True, True, True, True, True, True),
+ (True, True, False, False, False, False, False, False),
+ (True, True, False, False, False, False, False, True),
+ (True, True, False, False, False, False, True, False),
+ (True, True, False, False, False, False, True, True),
+ (True, True, False, False, False, True, False, False),
+ (True, True, False, False, False, True, False, True),
+ (True, True, False, False, False, True, True, False),
+ (True, True, False, False, False, True, True, True),
+ (True, True, False, False, True, False, False, False),
+ (True, True, False, False, True, False, False, True),
+ (True, True, False, False, True, False, True, False),
+ (True, True, False, False, True, False, True, True),
+ (True, True, False, False, True, True, False, False),
+ (True, True, False, False, True, True, False, True),
+ (True, True, False, False, True, True, True, False),
+ (True, True, False, False, True, True, True, True),
+ (True, True, False, True, False, False, False, False),
+ (True, True, False, True, False, False, False, True),
+ (True, True, False, True, False, False, True, False),
+ (True, True, False, True, False, False, True, True),
+ (True, True, False, True, False, True, False, False),
+ (True, True, False, True, False, True, False, True),
+ (True, True, False, True, False, True, True, False),
+ (True, True, False, True, False, True, True, True),
+ (True, True, False, True, True, False, False, False),
+ (True, True, False, True, True, False, False, True),
+ (True, True, False, True, True, False, True, False),
+ (True, True, False, True, True, False, True, True),
+ (True, True, False, True, True, True, False, False),
+ (True, True, False, True, True, True, False, True),
+ (True, True, False, True, True, True, True, False),
+ (True, True, False, True, True, True, True, True),
+ (True, True, True, False, False, False, False, False),
+ (True, True, True, False, False, False, False, True),
+ (True, True, True, False, False, False, True, False),
+ (True, True, True, False, False, False, True, True),
+ (True, True, True, False, False, True, False, False),
+ (True, True, True, False, False, True, False, True),
+ (True, True, True, False, False, True, True, False),
+ (True, True, True, False, False, True, True, True),
+ (True, True, True, False, True, False, False, False),
+ (True, True, True, False, True, False, False, True),
+ (True, True, True, False, True, False, True, False),
+ (True, True, True, False, True, False, True, True),
+ (True, True, True, False, True, True, False, False),
+ (True, True, True, False, True, True, False, True),
+ (True, True, True, False, True, True, True, False),
+ (True, True, True, False, True, True, True, True),
+ (True, True, True, True, False, False, False, False),
+ (True, True, True, True, False, False, False, True),
+ (True, True, True, True, False, False, True, False),
+ (True, True, True, True, False, False, True, True),
+ (True, True, True, True, False, True, False, False),
+ (True, True, True, True, False, True, False, True),
+ (True, True, True, True, False, True, True, False),
+ (True, True, True, True, False, True, True, True),
+ (True, True, True, True, True, False, False, False),
+ (True, True, True, True, True, False, False, True),
+ (True, True, True, True, True, False, True, False),
+ (True, True, True, True, True, False, True, True),
+ (True, True, True, True, True, True, False, False),
+ (True, True, True, True, True, True, False, True),
+ (True, True, True, True, True, True, True, False),
+ (True, True, True, True, True, True, True, True))
+
+ null_byte_search_table = (0x80, 0x40, 0x20, 0x10, 0x08, 0x04, 0x02, 0x01)
def __init__(self, field_coders):
self._field_coders = field_coders
self._filed_count = len(field_coders)
+ self._complete_byte_num = self._filed_count // 8
+ self._remaining_bit_num = self._filed_count % 8
def encode_to_stream(self, value, out_stream, nested):
- self.write_null_mask(value, out_stream)
+ self.write_null_mask(value, self._complete_byte_num, self._remaining_bit_num, out_stream)
Review comment:
Make write_null_mask non-static? then this change is not needed any more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dianfu commented on a change in pull request #11118:
[FLINK-16072][python] Optimize the performance of the write/read null mask
Posted by GitBox <gi...@apache.org>.
dianfu commented on a change in pull request #11118: [FLINK-16072][python] Optimize the performance of the write/read null mask
URL: https://github.com/apache/flink/pull/11118#discussion_r381766299
##########
File path: flink-python/pyflink/fn_execution/coder_impl.py
##########
@@ -24,57 +24,71 @@
from pyflink.table import Row
+def generate_null_mask_search_table():
+ """
+ Each bit of one byte represents if the column at the specified position is None or not, e.g.
+ 0x84 represents the first column and the sixth column are None.
+ """
+ num = 256
+ null_mask = []
+ for b in range(num):
+ every_num_null_mask = [(b & 0x80) > 0, (b & 0x40) > 0, (b & 0x20) > 0, (b & 0x10) > 0,
+ (b & 0x08) > 0, (b & 0x04) > 0, (b & 0x02) > 0, (b & 0x01) > 0]
+ null_mask.append(tuple(every_num_null_mask))
+
+ return tuple(null_mask)
+
+
class FlattenRowCoderImpl(StreamCoderImpl):
+ null_mask_search_table = generate_null_mask_search_table()
Review comment:
What about make it an instance variable as it's faster than static variable: https://stackoverflow.com/questions/2714573/instance-variables-vs-class-variables-in-python
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services