You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/11/25 13:46:51 UTC

[GitHub] [cordova-ios] NiklasMerz opened a new pull request #1031: Set CDVWebViewProcessPoolFactory to public

NiklasMerz opened a new pull request #1031:
URL: https://github.com/apache/cordova-ios/pull/1031


   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   The InAppBrowser used to import the process pool from the wkwebview plugin. No the processpool is in the iOS platform and got renamed. Because it's in the private part InAppBrowser can never import it and use the shared pool.
   
   See this issue: https://github.com/apache/cordova-plugin-inappbrowser/issues/751
   
   ### Description
   <!-- Describe your changes in detail -->
   I just set the file to public in Xcode.
   
   From my understanding this should be public for plugins to use (like IAB to share Cookies). I am not sure if this is the right way to make this public though. Are there any other problems for having this private?
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] NiklasMerz commented on pull request #1031: Set CDVWebViewProcessPoolFactory to public

Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on pull request #1031:
URL: https://github.com/apache/cordova-ios/pull/1031#issuecomment-733776817


   By setting the checkbox it becomes public and works. But I would agree that moving it to `Classes/Public` would make sense since it should be part of the public API.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] codecov-io edited a comment on pull request #1031: Set CDVWebViewProcessPoolFactory to public

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1031:
URL: https://github.com/apache/cordova-ios/pull/1031#issuecomment-733718966


   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=h1) Report
   > Merging [#1031](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=desc) (bee6a5f) into [master](https://codecov.io/gh/apache/cordova-ios/commit/e92f653f6825b5a57eb5d2f181d59b5cfae1e0c2?el=desc) (e92f653) will **increase** coverage by `74.91%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/1031/graphs/tree.svg?width=650&height=150&src=pr&token=WomDD5jInz)](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #1031       +/-   ##
   ===========================================
   + Coverage        0   74.91%   +74.91%     
   ===========================================
     Files           0       13       +13     
     Lines           0     1718     +1718     
   ===========================================
   + Hits            0     1287     +1287     
   - Misses          0      431      +431     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/scripts/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2NoZWNrX3JlcXMuanM=) | `46.93% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/versions.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ZlcnNpb25zLmpz) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz) | `51.87% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/listDevices.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2xpc3REZXZpY2VzLmpz) | `100.00% <0.00%> (ø)` | |
   | [...emplates/scripts/cordova/lib/listEmulatorImages.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2xpc3RFbXVsYXRvckltYWdlcy5qcw==) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/projectFile.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3Byb2plY3RGaWxlLmpz) | `95.00% <0.00%> (ø)` | |
   | [...in/templates/scripts/cordova/lib/BridgingHeader.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL0JyaWRnaW5nSGVhZGVyLmpz) | `95.45% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `85.00% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/Podfile.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL1BvZGZpbGUuanM=) | `73.20% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/Api.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvQXBpLmpz) | `71.53% <0.00%> (ø)` | |
   | ... and [3 more](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=footer). Last update [e92f653...bee6a5f](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] codecov-io commented on pull request #1031: Set CDVWebViewProcessPoolFactory to public

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1031:
URL: https://github.com/apache/cordova-ios/pull/1031#issuecomment-733718966


   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=h1) Report
   > Merging [#1031](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=desc) (bee6a5f) into [master](https://codecov.io/gh/apache/cordova-ios/commit/e92f653f6825b5a57eb5d2f181d59b5cfae1e0c2?el=desc) (e92f653) will **increase** coverage by `74.91%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/1031/graphs/tree.svg?width=650&height=150&src=pr&token=WomDD5jInz)](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #1031       +/-   ##
   ===========================================
   + Coverage        0   74.91%   +74.91%     
   ===========================================
     Files           0       13       +13     
     Lines           0     1718     +1718     
   ===========================================
   + Hits            0     1287     +1287     
   - Misses          0      431      +431     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/scripts/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2NoZWNrX3JlcXMuanM=) | `46.93% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/versions.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ZlcnNpb25zLmpz) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz) | `51.87% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/listDevices.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2xpc3REZXZpY2VzLmpz) | `100.00% <0.00%> (ø)` | |
   | [...emplates/scripts/cordova/lib/listEmulatorImages.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2xpc3RFbXVsYXRvckltYWdlcy5qcw==) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/projectFile.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3Byb2plY3RGaWxlLmpz) | `95.00% <0.00%> (ø)` | |
   | [...in/templates/scripts/cordova/lib/BridgingHeader.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL0JyaWRnaW5nSGVhZGVyLmpz) | `95.45% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `85.00% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/Podfile.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL1BvZGZpbGUuanM=) | `73.20% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/Api.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvQXBpLmpz) | `71.53% <0.00%> (ø)` | |
   | ... and [3 more](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=footer). Last update [e92f653...bee6a5f](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] NiklasMerz commented on pull request #1031: Set CDVWebViewProcessPoolFactory to public

Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on pull request #1031:
URL: https://github.com/apache/cordova-ios/pull/1031#issuecomment-734181345


   I did another commit and moved the class to the `Classes/Public` folder. From my understanding this could be public like it used to be in WKWebView engine plugin. Now the InAppBrowser can use the pool again.
   
   Does anyone know reasons why this is private with the other plugins? Any known issues in the past?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] NiklasMerz merged pull request #1031: Set CDVWebViewProcessPoolFactory to public

Posted by GitBox <gi...@apache.org>.
NiklasMerz merged pull request #1031:
URL: https://github.com/apache/cordova-ios/pull/1031


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] codecov-io edited a comment on pull request #1031: Set CDVWebViewProcessPoolFactory to public

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1031:
URL: https://github.com/apache/cordova-ios/pull/1031#issuecomment-733718966


   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=h1) Report
   > Merging [#1031](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=desc) (bee6a5f) into [master](https://codecov.io/gh/apache/cordova-ios/commit/e92f653f6825b5a57eb5d2f181d59b5cfae1e0c2?el=desc) (e92f653) will **increase** coverage by `74.91%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/1031/graphs/tree.svg?width=650&height=150&src=pr&token=WomDD5jInz)](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #1031       +/-   ##
   ===========================================
   + Coverage        0   74.91%   +74.91%     
   ===========================================
     Files           0       13       +13     
     Lines           0     1718     +1718     
   ===========================================
   + Hits            0     1287     +1287     
   - Misses          0      431      +431     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/scripts/cordova/Api.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvQXBpLmpz) | `71.53% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `85.00% <0.00%> (ø)` | |
   | [...in/templates/scripts/cordova/lib/BridgingHeader.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL0JyaWRnaW5nSGVhZGVyLmpz) | `95.45% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3J1bi5qcw==) | `19.62% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2NoZWNrX3JlcXMuanM=) | `46.93% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz) | `51.87% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/versions.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ZlcnNpb25zLmpz) | `100.00% <0.00%> (ø)` | |
   | [...ates/scripts/cordova/lib/plugman/pluginHandlers.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3BsdWdtYW4vcGx1Z2luSGFuZGxlcnMuanM=) | `90.05% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/projectFile.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3Byb2plY3RGaWxlLmpz) | `95.00% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/Podfile.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL1BvZGZpbGUuanM=) | `73.20% <0.00%> (ø)` | |
   | ... and [3 more](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=footer). Last update [e92f653...bee6a5f](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] codecov-io edited a comment on pull request #1031: Set CDVWebViewProcessPoolFactory to public

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1031:
URL: https://github.com/apache/cordova-ios/pull/1031#issuecomment-733718966






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] NiklasMerz commented on pull request #1031: Set CDVWebViewProcessPoolFactory to public

Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on pull request #1031:
URL: https://github.com/apache/cordova-ios/pull/1031#issuecomment-755221947


   Thanks for the reviews. If no one objects I will merge this in 24 hours together with https://github.com/apache/cordova-plugin-inappbrowser/pull/825.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] NiklasMerz edited a comment on pull request #1031: Set CDVWebViewProcessPoolFactory to public

Posted by GitBox <gi...@apache.org>.
NiklasMerz edited a comment on pull request #1031:
URL: https://github.com/apache/cordova-ios/pull/1031#issuecomment-755221947


   Thanks for the reviews. If nobody objects I will merge this in 24 hours together with https://github.com/apache/cordova-plugin-inappbrowser/pull/825.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] codecov-io edited a comment on pull request #1031: Set CDVWebViewProcessPoolFactory to public

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1031:
URL: https://github.com/apache/cordova-ios/pull/1031#issuecomment-733718966


   # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=h1) Report
   > Merging [#1031](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=desc) (bee6a5f) into [master](https://codecov.io/gh/apache/cordova-ios/commit/e92f653f6825b5a57eb5d2f181d59b5cfae1e0c2?el=desc) (e92f653) will **increase** coverage by `74.91%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-ios/pull/1031/graphs/tree.svg?width=650&height=150&src=pr&token=WomDD5jInz)](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #1031       +/-   ##
   ===========================================
   + Coverage        0   74.91%   +74.91%     
   ===========================================
     Files           0       13       +13     
     Lines           0     1718     +1718     
   ===========================================
   + Hits            0     1287     +1287     
   - Misses          0      431      +431     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `85.00% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/versions.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ZlcnNpb25zLmpz) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/listDevices.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2xpc3REZXZpY2VzLmpz) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2NoZWNrX3JlcXMuanM=) | `46.93% <0.00%> (ø)` | |
   | [...ates/scripts/cordova/lib/plugman/pluginHandlers.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3BsdWdtYW4vcGx1Z2luSGFuZGxlcnMuanM=) | `90.05% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/Api.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvQXBpLmpz) | `71.53% <0.00%> (ø)` | |
   | [...emplates/scripts/cordova/lib/listEmulatorImages.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2xpc3RFbXVsYXRvckltYWdlcy5qcw==) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/projectFile.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3Byb2plY3RGaWxlLmpz) | `95.00% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2J1aWxkLmpz) | `51.87% <0.00%> (ø)` | |
   | [bin/templates/scripts/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3J1bi5qcw==) | `19.62% <0.00%> (ø)` | |
   | ... and [3 more](https://codecov.io/gh/apache/cordova-ios/pull/1031/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=footer). Last update [e92f653...bee6a5f](https://codecov.io/gh/apache/cordova-ios/pull/1031?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-ios] dpogue commented on pull request #1031: Set CDVWebViewProcessPoolFactory to public

Posted by GitBox <gi...@apache.org>.
dpogue commented on pull request #1031:
URL: https://github.com/apache/cordova-ios/pull/1031#issuecomment-733772464


   The problem is that this is not part of our public API, it's part of a built-in internal plugin. It lives in `Classes/Private/Plugins` rather than `Classes/Public`.
   
   CDVWebViewProcessPoolFactory is fairly small and self-contained though, so maybe it makes sense to move that one class into the public API?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org