You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by msmerek <gi...@git.apache.org> on 2016/06/03 13:58:46 UTC
[GitHub] activemq-artemis pull request #557: ARTEMIS-551 Obfuscate truststore passwor...
GitHub user msmerek opened a pull request:
https://github.com/apache/activemq-artemis/pull/557
ARTEMIS-551 Obfuscate truststore password in TransportConfiguration.toString()
Obfuscate truststore password in TransportConfiguration.toString() in the same way as keystore. The password will not be logged in plain text when bridge is connected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/msmerek/activemq-artemis ARTEMIS-551
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/557.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #557
----
commit 33aa84f4061224fd56cd25eb562e33328bb0f55c
Author: Martin \u0160m�rek <ms...@redhat.com>
Date: 2016-06-03T13:52:17Z
ARTEMIS-551 Obfuscate truststore password in TransportConfiguration.toString()
Obfuscate truststore password in TransportConfiguration.toString() in the same way as keystore. The password will not be logged in plain text when bridge is connected.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #557: ARTEMIS-551 Obfuscate truststore password
Posted by msmerek <gi...@git.apache.org>.
Github user msmerek commented on the issue:
https://github.com/apache/activemq-artemis/pull/557
Thanks for pointing that out, fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #557: ARTEMIS-551 Obfuscate truststore password
Posted by msmerek <gi...@git.apache.org>.
Github user msmerek commented on the issue:
https://github.com/apache/activemq-artemis/pull/557
Done, thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #557: ARTEMIS-551 Obfuscate truststore passwor...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/557
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #557: ARTEMIS-551 Obfuscate truststore password
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/557
You changed the title of the commit but I don't think you amended the commit
you have to do:
git commit --amend
change the title
git push origin -f YOUR_BRANCH
that should update this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #557: ARTEMIS-551 Obfuscate truststore password in Tr...
Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:
https://github.com/apache/activemq-artemis/pull/557
The first line of the commit comment should only be 40 characters long as noted in the Artemis Hacking Guide - https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/maintainers.md#commit-messages.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---