You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/11 16:27:03 UTC
[GitHub] [airflow] FloChehab opened a new pull request #13616: Support annotations for the flower service in the chart
FloChehab opened a new pull request #13616:
URL: https://github.com/apache/airflow/pull/13616
Hello,
This is simple PR that adds the ability to add annotations
to the flower service in the chart.
Docs and tests updated accordingly.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] FloChehab commented on pull request #13616: Support annotations for the flower service in the chart
Posted by GitBox <gi...@apache.org>.
FloChehab commented on pull request #13616:
URL: https://github.com/apache/airflow/pull/13616#issuecomment-758067958
Hello @mik-laj , this PR is good start towards what you were describing in https://github.com/apache/airflow/pull/12010#issuecomment-757344368 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] FloChehab commented on pull request #13616: Support annotations for the flower service in the chart
Posted by GitBox <gi...@apache.org>.
FloChehab commented on pull request #13616:
URL: https://github.com/apache/airflow/pull/13616#issuecomment-758891692
Closing in favor of https://github.com/apache/airflow/issues/13643.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13616: Support annotations for the flower service in the chart
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13616:
URL: https://github.com/apache/airflow/pull/13616#issuecomment-758234146
I wonder if we should review all objects and standardize support for annotations. As you can see this annotation support is being added in several PRs for different objects, and I guess it won't be hard to do this for all objects. Are you interested in this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] FloChehab commented on pull request #13616: Support annotations for the flower service in the chart
Posted by GitBox <gi...@apache.org>.
FloChehab commented on pull request #13616:
URL: https://github.com/apache/airflow/pull/13616#issuecomment-758630982
> I wonder if we should review all objects and standardize support for annotations. As you can see this annotation support is being added in several PRs for different objects, and I guess it won't be hard to do this for all objects. Are you interested in this?
Yeah I can look into that. Maybe we should create an issue for this so that we agree on the how (terminology, objects, location in the values.yaml) before starting the dev? Wdyt ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] FloChehab closed pull request #13616: Support annotations for the flower service in the chart
Posted by GitBox <gi...@apache.org>.
FloChehab closed pull request #13616:
URL: https://github.com/apache/airflow/pull/13616
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13616: Support annotations for the flower service in the chart
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13616:
URL: https://github.com/apache/airflow/pull/13616#issuecomment-758312504
[The Workflow run](https://github.com/apache/airflow/actions/runs/478010255) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13616: Support annotations for the flower service in the chart
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13616:
URL: https://github.com/apache/airflow/pull/13616#issuecomment-758725177
@FloChehab the idea sounds good to me. the new issue allows us to discuss freely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org