[jira] [Commented] (SOLR-12361) Change _childDocuments to Map

["Cao Manh Dat (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499819#comment-16499819 ] 

Cao Manh Dat commented on SOLR-12361:
-------------------------------------

[~dsmiley] In {{fastEstimate(map)}} and {{fastEstimate(collection)}} we only count its element if it is a primitive object (we do not go further here).
{quote}line 115 could be changed to loop on the SolrInputFields instead of the field names to avoid doing an internal hashmap lookup on all field names.
{quote}
+1 for this one.

With the change in pull request, we can change {{fastEstimate}} to {{estimate}} and merge all the duplications.

> Change _childDocuments to Map
> -----------------------------
>
>                 Key: SOLR-12361
>                 URL: https://issues.apache.org/jira/browse/SOLR-12361
>             Project: Solr
>          Issue Type: Sub-task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: mosh
>            Priority: Major
>         Attachments: SOLR-12361.patch, SOLR-12361.patch
>
>          Time Spent: 9h 40m
>  Remaining Estimate: 0h
>
> During the discussion on SOLR-12298, there was a proposal to change _childDocuments in SolrDocumentBase to a Map, to incorporate the relationship between the parent and its child documents.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org