[GitHub] merlimat closed pull request #1116: Increase client setting concurrentLookupRequest default to 50K

[GitBox <gi...@apache.org>]

merlimat closed pull request #1116: Increase client setting concurrentLookupRequest default to 50K
URL: https://github.com/apache/incubator-pulsar/pull/1116
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pulsar-client-cpp/include/pulsar/ClientConfiguration.h b/pulsar-client-cpp/include/pulsar/ClientConfiguration.h
index 08cfdf036..137d528ca 100644
--- a/pulsar-client-cpp/include/pulsar/ClientConfiguration.h
+++ b/pulsar-client-cpp/include/pulsar/ClientConfiguration.h
@@ -88,7 +88,7 @@ class ClientConfiguration {
 
     /**
      * Number of concurrent lookup-requests allowed on each broker-connection to prevent overload on broker.
-     * <i>(default: 5000)</i> It should be configured with higher value only in case of it requires to
+     * <i>(default: 50000)</i> It should be configured with higher value only in case of it requires to
      * produce/subscribe on
      * thousands of topic using created {@link PulsarClient}
      *
diff --git a/pulsar-client-cpp/lib/ClientConfigurationImpl.h b/pulsar-client-cpp/lib/ClientConfigurationImpl.h
index 14a5fdab8..4ea77cf92 100644
--- a/pulsar-client-cpp/lib/ClientConfigurationImpl.h
+++ b/pulsar-client-cpp/lib/ClientConfigurationImpl.h
@@ -39,7 +39,7 @@ struct ClientConfigurationImpl {
           ioThreads(1),
           operationTimeoutSeconds(30),
           messageListenerThreads(1),
-          concurrentLookupRequest(5000),
+          concurrentLookupRequest(50000),
           logConfFilePath(),
           useTls(false),
           tlsAllowInsecureConnection(true),
diff --git a/pulsar-client-cpp/python/pulsar.py b/pulsar-client-cpp/python/pulsar.py
index 9cdb90d2e..8c1ff45f7 100644
--- a/pulsar-client-cpp/python/pulsar.py
+++ b/pulsar-client-cpp/python/pulsar.py
@@ -202,7 +202,7 @@ def __init__(self, service_url,
                  operation_timeout_seconds=30,
                  io_threads=1,
                  message_listener_threads=1,
-                 concurrent_lookup_requests=5000,
+                 concurrent_lookup_requests=50000,
                  log_conf_file_path=None,
                  use_tls=False,
                  tls_trust_certs_file_path=None,
diff --git a/pulsar-client/src/main/java/org/apache/pulsar/client/api/ClientConfiguration.java b/pulsar-client/src/main/java/org/apache/pulsar/client/api/ClientConfiguration.java
index 9c3e66281..dd62728f7 100644
--- a/pulsar-client/src/main/java/org/apache/pulsar/client/api/ClientConfiguration.java
+++ b/pulsar-client/src/main/java/org/apache/pulsar/client/api/ClientConfiguration.java
@@ -51,7 +51,7 @@
     private boolean useTls = false;
     private String tlsTrustCertsFilePath = "";
     private boolean tlsAllowInsecureConnection = false;
-    private int concurrentLookupRequest = 5000;
+    private int concurrentLookupRequest = 50000;
     private int maxNumberOfRejectedRequestPerConnection = 50;
 
     /**
@@ -296,7 +296,7 @@ public void setTlsAllowInsecureConnection(boolean tlsAllowInsecureConnection) {
 
     /**
      * Stats will be activated with positive statsIntervalSeconds
-     * 
+     *
      * @return the interval between each stat info <i>(default: 60 seconds)</i>
      */
     public long getStatsIntervalSeconds() {
@@ -306,7 +306,7 @@ public long getStatsIntervalSeconds() {
     /**
      * Set the interval between each stat info <i>(default: 60 seconds)</i> Stats will be activated with positive
      * statsIntervalSeconds It should be set to at least 1 second
-     * 
+     *
      * @param statsIntervalSeconds
      *            the interval between each stat info
      * @param unit
@@ -318,7 +318,7 @@ public void setStatsInterval(long statsInterval, TimeUnit unit) {
 
     /**
      * Get configured total allowed concurrent lookup-request.
-     * 
+     *
      * @return
      */
     public int getConcurrentLookupRequest() {
@@ -327,9 +327,9 @@ public int getConcurrentLookupRequest() {
 
     /**
      * Number of concurrent lookup-requests allowed on each broker-connection to prevent overload on broker.
-     * <i>(default: 5000)</i> It should be configured with higher value only in case of it requires to produce/subscribe on
+     * <i>(default: 50000)</i> It should be configured with higher value only in case of it requires to produce/subscribe on
      * thousands of topic using created {@link PulsarClient}
-     * 
+     *
      * @param concurrentLookupRequest
      */
     public void setConcurrentLookupRequest(int concurrentLookupRequest) {
@@ -338,7 +338,7 @@ public void setConcurrentLookupRequest(int concurrentLookupRequest) {
 
     /**
      * Get configured max number of reject-request in a time-frame (30 seconds) after which connection will be closed
-     * 
+     *
      * @return
      */
     public int getMaxNumberOfRejectedRequestPerConnection() {
@@ -349,7 +349,7 @@ public int getMaxNumberOfRejectedRequestPerConnection() {
      * Set max number of broker-rejected requests in a certain time-frame (30 seconds) after which current connection
      * will be closed and client creates a new connection that give chance to connect a different broker <i>(default:
      * 50)</i>
-     * 
+     *
      * @param maxNumberOfRejectedRequestPerConnection
      */
     public void setMaxNumberOfRejectedRequestPerConnection(int maxNumberOfRejectedRequestPerConnection) {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services