You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "caozj1011 (via GitHub)" <gi...@apache.org> on 2023/08/21 10:38:29 UTC
[GitHub] [iotdb] caozj1011 commented on a diff in pull request #10900: [To rel/1.2] fix wal npe when memTable has flushed.
caozj1011 commented on code in PR #10900:
URL: https://github.com/apache/iotdb/pull/10900#discussion_r1299934886
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/node/WALNode.java:
##########
@@ -457,8 +455,8 @@ private void snapshotMemTable(DataRegion dataRegion, File tsFile, MemTableInfo m
"CheckpointManager$DeleteOutdatedFileTask.snapshotOrFlushOldestMemTable");
try {
// make sure snapshot is made before memTable flush operation
- synchronized (memTable) {
- if (memTable.getFlushStatus() != FlushStatus.WORKING) {
+ synchronized (this) {
Review Comment:
Your question makes sense. I changed it to memTableInfo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org