You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by ze...@apache.org on 2026/06/29 13:01:20 UTC
(iceberg-go) branch main updated: fix(table): return ([]string, error) from writePositionDeletesForFiles (#1342)
This is an automated email from the ASF dual-hosted git repository.
zeroshade pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-go.git
The following commit(s) were added to refs/heads/main by this push:
new d86ee87f fix(table): return ([]string, error) from writePositionDeletesForFiles (#1342)
d86ee87f is described below
commit d86ee87f7f860a86bc21cca39f6affaccaea75cc
Author: Andrei Tserakhau <la...@gmail.com>
AuthorDate: Mon Jun 29 15:01:15 2026 +0200
fix(table): return ([]string, error) from writePositionDeletesForFiles (#1342)
A bare `return err` returned a single value where the function now
returns ([]string, error), so the table package — and every package that
imports it — failed to compile, turning main red.
Silent semantic merge conflict: #1256 added the requireWriteFileIO guard
with `return err` while the function still returned only error; #1298
later widened the signature and converted the returns it could see, but
its base predated #1256 so it never saw that one. Each PR compiled
alone; only the merge breaks, and with no textual conflict git didn't
flag it.
---
table/transaction.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/table/transaction.go b/table/transaction.go
index 4f031d6c..39304012 100644
--- a/table/transaction.go
+++ b/table/transaction.go
@@ -1860,7 +1860,7 @@ func (t *Transaction) writePositionDeletesForFiles(ctx context.Context, fs io.IO
}
wfs, err := requireWriteFileIO(fs)
if err != nil {
- return err
+ return nil, err
}
partitionContextByFilePath := make(map[string]partitionContext, len(files))