[jira] [Commented] (FLUME-2629) Improve RpcClient unit tests

["Santiago M. Mola (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLUME-2629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14327506#comment-14327506 ] 

Santiago M. Mola commented on FLUME-2629:
-----------------------------------------

Here's the review board: https://reviews.apache.org/r/31195/

I have fixed a few minor bugs that arised when writing new tests.

> Improve RpcClient unit tests
> ----------------------------
>
>                 Key: FLUME-2629
>                 URL: https://issues.apache.org/jira/browse/FLUME-2629
>             Project: Flume
>          Issue Type: Improvement
>            Reporter: Santiago M. Mola
>            Assignee: Santiago M. Mola
>         Attachments: FLUME-2629-0.patch
>
>
> There is some room for improvement in RpcClient-related tests:
> - Some of them use Avro and Thrift servers that are not needed (most of the time). This makes them unnecessarily slower and, in some cases, unstable.
> - There is a lot of reliance on Thread.sleep(arbitraryTime) hoping that *something* happens meanwhile. These tests are unstable in some environments where arbitraryTime is too low.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)