You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@teaclave.apache.org by "tchebb (via GitHub)" <gi...@apache.org> on 2023/04/23 03:54:28 UTC

[GitHub] [incubator-teaclave-trustzone-sdk] tchebb commented on a diff in pull request #109: `setup.sh` and default toolchain fixes

tchebb commented on code in PR #109:
URL: https://github.com/apache/incubator-teaclave-trustzone-sdk/pull/109#discussion_r1174503164


##########
.github/workflows/ci.yml:
##########
@@ -92,6 +86,11 @@ jobs:
           mkdir -p ~/optee-qemuv8 && cd ~/optee-qemuv8 &&
           repo init -u https://github.com/OP-TEE/manifest.git -m qemu_v8.xml &&
           repo sync -j4 --no-clone-bundle
+      - name: Setting up $HOME
+        run: |
+          cp /root/.bashrc $HOME/.bashrc &&
+          ln -sf /root/.rustup ~/.rustup &&
+          ln -sf /root/.cargo ~/.cargo

Review Comment:
   I think it's because we unconditionally installed our own version of rustup from https://rustup.rs/ before. My changes to `setup.py` make us use an installed version if it exists, though, which means that installed version has to work. And the version in the GitHub Actions container we use doesn't seem to work unless those symlinks exist.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@teaclave.apache.org
For additional commands, e-mail: dev-help@teaclave.apache.org