[jira] [Commented] (HBASE-15851) Makefile update for build env

["Elliott Clark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-15851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15289255#comment-15289255 ] 

Elliott Clark commented on HBASE-15851:
---------------------------------------

Thanks for this.  Few comments:

* Name the patch according to the yetus rules and we can get some checks run by the qa bot.
* Need to keep the header on the make file.
* -D_GLIBCXX_USE_CXX11_ABI=0 should be in all the cpp flags, or people on older libstdc++ won't be able to use it.
* If we're going to have a clean command then it should clean buck-out too please.
* We shouldn't put the if source in location. That makes git un-happy and will confuse people. We should do that in the build dir.
* Release should be -02 at least.


> Makefile update for build env
> -----------------------------
>
>                 Key: HBASE-15851
>                 URL: https://issues.apache.org/jira/browse/HBASE-15851
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sudeep Sunthankar
>         Attachments: hbase-native-client-with-makefile.patch
>
>
> 1) Makefile:- edited to compile using g++ .  A SO would be created with the name libHbaseClient.so.
> 2) core/meta-utils.h :- Edited to update an incorrect header file reference (connection/Request.h -> connection/request.h)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)