You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/30 06:56:13 UTC

[GitHub] [dolphinscheduler] hstdream commented on a diff in pull request #11839: [Improvement-#11822]Return more friendly return information in class of ProcessDefinitionServiceImpl,and remove invalid codes

hstdream commented on code in PR #11839:
URL: https://github.com/apache/dolphinscheduler/pull/11839#discussion_r984267439


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java:
##########
@@ -322,12 +322,10 @@ protected Map<String, Object> createDagDefine(User loginUser,
             logger.info("The task has not changed, so skip");
         }
         if (saveTaskResult == Constants.DEFINITION_FAILURE) {
-            putMsg(result, Status.CREATE_TASK_DEFINITION_ERROR);

Review Comment:
   This needs to be returned to the front end, and can't be returned after deleting it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org