[PR] FINERACT-2566: Refresh loan summary after account-transfer disbursement charge collection [fineract]

["rhopman (via GitHub)" <gi...@apache.org>]

rhopman opened a new pull request, #5710:
URL: https://github.com/apache/fineract/pull/5710

   ## Bug
   
   When a loan is disbursed and one or more loan charges have their payment mode set to **Account Transfer** (`ACCOUNT_TRANSFER`), the system collects each charge by calling `transferFunds(`) on the linked savings account. This creates a `REPAYMENT_AT_DISBURSEMENT` loan transaction and marks the charge as paid.
   
   However, `transferFunds()` does **not** recompute the `LoanSummary` derived fields. As a result, fields such as `feeChargesPaid`, `feeChargesOutstanding`, and `totalOutstanding` remain stale, reflecting the values computed during the `saveAndFlush` that preceded the charge loop.
   
   This causes the loan balance to appear higher than what the client actually owes after disbursement.
   
   ## Fix
   
   After the `disBuLoanCharges` transfer loop, when the map is non-empty, call:
   
   ```java
   if (!disBuLoanCharges.isEmpty()) {
       loanBalanceService.updateLoanSummaryDerivedFields(loan);
       saveAndFlushLoanWithDataIntegrityViolationChecks(loan);
   }
   ```
   
   ## Checklist
   
   - [x] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
   - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
   - [x] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made.
   - [x] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
   - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
   - [x] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FINERACT-2566: Refresh loan summary after account-transfer disbursement charge collection [fineract]

["adamsaghy (via GitHub)" <gi...@apache.org>]

adamsaghy merged PR #5710:
URL: https://github.com/apache/fineract/pull/5710


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org