[GitHub] [incubator-doris] morningman commented on a change in pull request #7050: Add errno for hdfs writer. when no dir, hdfs writer open failed, the dir need to be created.

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #7050:
URL: https://github.com/apache/incubator-doris/pull/7050#discussion_r744755540



##########
File path: be/src/exec/hdfs_file_reader.cpp
##########
@@ -80,7 +80,7 @@ Status HdfsFileReader::open() {
     _hdfs_file = hdfsOpenFile(_hdfs_fs, _path.c_str(), O_RDONLY, 0, 0, 0);
     if (_hdfs_file == nullptr) {
         std::stringstream ss;
-        ss << "open file failed. " << _namenode << _path;
+        ss << "open file failed. " << _namenode << _path << ", err: " << strerror(errno);;

Review comment:
       Also add BE ip info so that we can easily find which BE report the error.
   You can call `BackendOptions::get_localhost();`

##########
File path: be/test/exprs/bitmap_function_test.cpp
##########
@@ -866,6 +866,61 @@ TEST_F(BitmapFunctionsTest, bitmap_subset_limit) {
 
 }
 
+TEST_F(BitmapFunctionsTest, bitmap_subset_limit) {

Review comment:
       Why there is bitmap unit test in this PR?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org