You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/09/24 05:52:53 UTC
[kudu-CR] KUDU-2612 p6 (c): add GetTransactionStatus() to TxnSystemClient
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16501
Change subject: KUDU-2612 p6 (c): add GetTransactionStatus() to TxnSystemClient
......................................................................
KUDU-2612 p6 (c): add GetTransactionStatus() to TxnSystemClient
This patch adds GetTransactionStatus() method into the interface
of the TxnSystemClient class. Added corresponding test as well.
This is a follow-up to cb1c2efb59373453e734074a02021f14c403257d
and 0f9ff5ff043125be4a1150be0306373619b4ca89
Change-Id: I7fac7158df307d03db6a48087e7c5a16269a3bc6
---
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/transactions/coordinator_rpc.cc
M src/kudu/transactions/coordinator_rpc.h
M src/kudu/transactions/txn_system_client.cc
M src/kudu/transactions/txn_system_client.h
M src/kudu/tserver/tablet_service.cc
6 files changed, 122 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/16501/1
--
To view, visit http://gerrit.cloudera.org:8080/16501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7fac7158df307d03db6a48087e7c5a16269a3bc6
Gerrit-Change-Number: 16501
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] KUDU-2612 p6 (c): add GetTransactionStatus() to TxnSystemClient
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16501 )
Change subject: KUDU-2612 p6 (c): add GetTransactionStatus() to TxnSystemClient
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fac7158df307d03db6a48087e7c5a16269a3bc6
Gerrit-Change-Number: 16501
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 28 Sep 2020 21:18:28 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2612 p6 (c): add GetTransactionStatus() to TxnSystemClient
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16501
to look at the new patch set (#2).
Change subject: KUDU-2612 p6 (c): add GetTransactionStatus() to TxnSystemClient
......................................................................
KUDU-2612 p6 (c): add GetTransactionStatus() to TxnSystemClient
This patch adds GetTransactionStatus() method into the interface
of the TxnSystemClient class. Added corresponding test as well.
This is a follow-up to cb1c2efb59373453e734074a02021f14c403257d
and 0f9ff5ff043125be4a1150be0306373619b4ca89
Change-Id: I7fac7158df307d03db6a48087e7c5a16269a3bc6
---
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/transactions/coordinator_rpc.cc
M src/kudu/transactions/coordinator_rpc.h
M src/kudu/transactions/txn_system_client.cc
M src/kudu/transactions/txn_system_client.h
5 files changed, 136 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/16501/2
--
To view, visit http://gerrit.cloudera.org:8080/16501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7fac7158df307d03db6a48087e7c5a16269a3bc6
Gerrit-Change-Number: 16501
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2612 p6 (c): add GetTransactionStatus() to TxnSystemClient
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16501 )
Change subject: KUDU-2612 p6 (c): add GetTransactionStatus() to TxnSystemClient
......................................................................
Patch Set 1: Verified+1 -Code-Review
--
To view, visit http://gerrit.cloudera.org:8080/16501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fac7158df307d03db6a48087e7c5a16269a3bc6
Gerrit-Change-Number: 16501
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 24 Sep 2020 19:30:04 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2612 p6 (c): add GetTransactionStatus() to TxnSystemClient
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16501 )
Change subject: KUDU-2612 p6 (c): add GetTransactionStatus() to TxnSystemClient
......................................................................
Patch Set 1: Code-Review+1
unrelated test failure in HmsConfigurations/MasterFailoverTest.TestMasterPermanentFailure/1
--
To view, visit http://gerrit.cloudera.org:8080/16501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fac7158df307d03db6a48087e7c5a16269a3bc6
Gerrit-Change-Number: 16501
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 24 Sep 2020 06:57:49 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2612 p6 (c): add GetTransactionStatus() to TxnSystemClient
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-2612 p6 (c): add GetTransactionStatus() to TxnSystemClient
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7fac7158df307d03db6a48087e7c5a16269a3bc6
Gerrit-Change-Number: 16501
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2612 p6 (c): add GetTransactionStatus() to TxnSystemClient
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16501 )
Change subject: KUDU-2612 p6 (c): add GetTransactionStatus() to TxnSystemClient
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
http://gerrit.cloudera.org:8080/#/c/16501/1/src/kudu/integration-tests/txn_status_table-itest.cc
File src/kudu/integration-tests/txn_status_table-itest.cc:
http://gerrit.cloudera.org:8080/#/c/16501/1/src/kudu/integration-tests/txn_status_table-itest.cc@516
PS1, Line 516:
: ASSERT_OK(txn_sys_client_->AbortTransaction(1, kUser));
: NO_FATALS(verify_state(TxnStatePB::ABORTED));
nit: just making sure this was intentional; maybe add a comment if it was
http://gerrit.cloudera.org:8080/#/c/16501/1/src/kudu/integration-tests/txn_status_table-itest.cc@521
PS1, Line 521: nullptr
nit: rather than allowing nullptrs in GetTransactionStatus(), maybe instead verify that nothing is set on error?
http://gerrit.cloudera.org:8080/#/c/16501/1/src/kudu/tserver/tablet_service.cc
File src/kudu/tserver/tablet_service.cc:
http://gerrit.cloudera.org:8080/#/c/16501/1/src/kudu/tserver/tablet_service.cc@1198
PS1, Line 1198: case CoordinatorOpPB::GET_TXN_STATUS:
nit: may belong as a part of https://gerrit.cloudera.org/c/16495/ ?
--
To view, visit http://gerrit.cloudera.org:8080/16501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fac7158df307d03db6a48087e7c5a16269a3bc6
Gerrit-Change-Number: 16501
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 27 Sep 2020 19:59:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2612 p6 (c): add GetTransactionStatus() to TxnSystemClient
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16501 )
Change subject: KUDU-2612 p6 (c): add GetTransactionStatus() to TxnSystemClient
......................................................................
KUDU-2612 p6 (c): add GetTransactionStatus() to TxnSystemClient
This patch adds GetTransactionStatus() method into the interface
of the TxnSystemClient class. Added corresponding test as well.
This is a follow-up to cb1c2efb59373453e734074a02021f14c403257d
and 0f9ff5ff043125be4a1150be0306373619b4ca89
Change-Id: I7fac7158df307d03db6a48087e7c5a16269a3bc6
Reviewed-on: http://gerrit.cloudera.org:8080/16501
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/integration-tests/txn_status_table-itest.cc
M src/kudu/transactions/coordinator_rpc.cc
M src/kudu/transactions/coordinator_rpc.h
M src/kudu/transactions/txn_system_client.cc
M src/kudu/transactions/txn_system_client.h
5 files changed, 136 insertions(+), 19 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7fac7158df307d03db6a48087e7c5a16269a3bc6
Gerrit-Change-Number: 16501
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-2612 p6 (c): add GetTransactionStatus() to TxnSystemClient
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16501 )
Change subject: KUDU-2612 p6 (c): add GetTransactionStatus() to TxnSystemClient
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/16501/1/src/kudu/integration-tests/txn_status_table-itest.cc
File src/kudu/integration-tests/txn_status_table-itest.cc:
http://gerrit.cloudera.org:8080/#/c/16501/1/src/kudu/integration-tests/txn_status_table-itest.cc@516
PS1, Line 516:
: ASSERT_OK(txn_sys_client_->AbortTransaction(1, kUser));
: NO_FATALS(verify_state(TxnStatePB::ABORTED));
> nit: just making sure this was intentional; maybe add a comment if it was
I think the idea was to try to start committing, get the error, and then see the status still as ABORTED.
Fixed!
http://gerrit.cloudera.org:8080/#/c/16501/1/src/kudu/integration-tests/txn_status_table-itest.cc@521
PS1, Line 521: nullptr
> nit: rather than allowing nullptrs in GetTransactionStatus(), maybe instead
Good point. Done.
http://gerrit.cloudera.org:8080/#/c/16501/1/src/kudu/tserver/tablet_service.cc
File src/kudu/tserver/tablet_service.cc:
http://gerrit.cloudera.org:8080/#/c/16501/1/src/kudu/tserver/tablet_service.cc@1198
PS1, Line 1198: case CoordinatorOpPB::GET_TXN_STATUS:
> nit: may belong as a part of https://gerrit.cloudera.org/c/16495/ ?
Indeed. Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/16501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7fac7158df307d03db6a48087e7c5a16269a3bc6
Gerrit-Change-Number: 16501
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 28 Sep 2020 19:36:21 +0000
Gerrit-HasComments: Yes