You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "rbalachandar (via GitHub)" <gi...@apache.org> on 2026/08/25 18:49:03 UTC

[PR] docs(cli): Ctrl+T help says latest thinking block but the binding toggles all in view [maka]

rbalachandar opened a new pull request, #3829:
URL: https://github.com/apache/maka/pull/3829

   Closes #3826
   
   ## Summary
   
   `/help` claimed Ctrl+T expands or collapses only *the latest* thinking block, but the binding calls `toggleAllThinkingExpansion`, which flips every thinking entry in the live viewport and retargets future entries — exactly the same `#1134`-style viewport contract as Ctrl+O's "all tool output" binding. With two thinking blocks in view, both toggle while `/help` promised only the latest.
   
   This rewords both locales to match the handler, consistent with the adjacent Ctrl+O phrasing:
   
   - EN: "expand or collapse **all thinking in view**"
   - zh-CN: 展开或折叠**视图中的所有思考块**
   
   Rewording rather than scoping the handler to the latest entry: the function name, its `#1134` contract comment (`pi-transcript.ts:471`), and its parallel with `toggleAllToolExpansion` all say viewport-wide was the intent.
   
   ## Verification
   
   - `npm run build`, `npm run lint`, `npm run format:check`, `npm run typecheck` (from root) — pass
   - `packages/cli` suite: 459/459 pass
   - Repo-wide grep: no remaining copies of the old wording in either locale
   
   ## AI use
   
   Select exactly one:
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: opencode verified the mismatch against the handler, drafted the reworded copy in both locales, and ran verification. Human contributor of record reviewed and owns the change.
   
   ## Checklist
   
   - [x] Tests cover the change and fail without it — not applicable: user-facing `/help` copy only; no behavior change
   - [x] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [x] No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] docs(cli): Ctrl+T help says latest thinking block but the binding toggles all in view [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #3829:
URL: https://github.com/apache/maka/pull/3829


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org