You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/07/29 15:29:18 UTC

[GitHub] [zookeeper] anmolnar commented on issue #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time

anmolnar commented on issue #863: ZOOKEEPER-3320: Leader election port stop listen when hostname unresolvable for some time
URL: https://github.com/apache/zookeeper/pull/863#issuecomment-516040724
 
 
   @Lagrang @nkalmar 
   Sorry for being late with the review, but I got the following problems with this patch:
   1. I set `electionPortBindRetry` to 0 and the instance hasn't tried to bind the election port at all. This is not a valid behaviour. Why is that a valid value?
   2. I think it would make sense to force ZooKeeper trying to bind the port indefinitely with a value of 0 or -1 for instance. It could be useful in a containerised environment.
   3. Small doc issue: name of the setting is `electionPortBindRetry` while Java system property is `zookeeper.electionPortBindRetry`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services