You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/11/28 23:17:50 UTC
[GitHub] [cassandra] belliottsmith opened a new pull request, #2030: CEP-15: Routables
belliottsmith opened a new pull request, #2030:
URL: https://github.com/apache/cassandra/pull/2030
Integrate cassandra-accord Routables PR to CEP-15 branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] belliottsmith merged pull request #2030: CEP-15: Routables
Posted by GitBox <gi...@apache.org>.
belliottsmith merged PR #2030:
URL: https://github.com/apache/cassandra/pull/2030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] aweisberg commented on a diff in pull request #2030: CEP-15: Routables
Posted by GitBox <gi...@apache.org>.
aweisberg commented on code in PR #2030:
URL: https://github.com/apache/cassandra/pull/2030#discussion_r1035382826
##########
src/java/org/apache/cassandra/service/accord/serializers/AcceptSerializers.java:
##########
@@ -108,15 +106,22 @@ public void serialize(AcceptReply reply, DataOutputPlus out, int version) throws
{
default: throw new AssertionError();
case Success:
- out.writeByte(1);
- DepsSerializer.partialDeps.serialize(((AcceptOk)reply).deps, out, version);
+ if (reply.deps != null)
+ {
+ out.writeByte(1);
Review Comment:
These should really be constants or enum values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org