[PR] Fix Python socket timeout test units [thrift]

["kpumuk (via GitHub)" <gi...@apache.org>]

kpumuk opened a new pull request, #3663:
URL: https://github.com/apache/thrift/pull/3663

   <!-- Explain the changes in the pull request below: -->
   `TSocket.setTimeout` accepts milliseconds, but the socket readability test passed `1.0`, producing a one-millisecond socket timeout. That made the immediate readability check unnecessarily timing-sensitive, particularly on macOS.
   
   Use `1000` milliseconds for timeout mode and assert that the underlying Python socket receives the expected one-second timeout. The blocking and non-blocking cases are also asserted explicitly.
     
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes) — Not required for this minor test-only fix.
   - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? — No ticket exists.
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. — Not applicable; this changes a test.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix Python socket timeout test units [thrift]

["kpumuk (via GitHub)" <gi...@apache.org>]

kpumuk merged PR #3663:
URL: https://github.com/apache/thrift/pull/3663


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org