You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2020/06/23 09:36:24 UTC
[GitHub] [knox] smolnar82 opened a new pull request #353: Knox 2344
smolnar82 opened a new pull request #353:
URL: https://github.com/apache/knox/pull/353
## What changes were proposed in this pull request?
Renamed the `gateway-cm-integration` Maven module to `gateway-topology-hadoopxml` since the feature we implemented there is not CM specific: anyone can generate a Hadoop style XML file have Knox process it.
Additional changes:
- Knox will monitor `.hxr` (**H**adoop **X**ml **R**esources) files within `KNOX_DESCRIPTOR_DIR` (instead of `.cm`)
- logging parser result of Knox provider configurations too (in addition to Knox descriptors)
## How was this patch tested?
Ran a full build:
```
$ mvn clean -Dshellcheck=true -T1C verify -Prelease,package
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 32:03 min (Wall Clock)
[INFO] Finished at: 2020-06-23T10:43:35+02:00
[INFO] Final Memory: 436M/2415M
[INFO] ------------------------------------------------------------------------
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 commented on a change in pull request #353: KNOX-2344 - Rename gateway-cm-integration module and related resources
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on a change in pull request #353:
URL: https://github.com/apache/knox/pull/353#discussion_r444226990
##########
File path: gateway-topology-hadoopxml/pom.xml
##########
@@ -25,9 +25,9 @@
<version>1.5.0-SNAPSHOT</version>
</parent>
- <artifactId>gateway-cm-integration</artifactId>
- <name>gateway-cm-integration</name>
- <description>Cloudera Manager integration related resources</description>
+ <artifactId>gateway-topology-hadoopxml</artifactId>
+ <name>gateway-topology-hadoopxml</name>
Review comment:
Done.
##########
File path: gateway-release/pom.xml
##########
@@ -439,7 +439,7 @@
</dependency>
<dependency>
<groupId>org.apache.knox</groupId>
- <artifactId>gateway-cm-integration</artifactId>
+ <artifactId>gateway-topology-hadoopxml</artifactId>
Review comment:
Fine by me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] moresandeep commented on a change in pull request #353: Knox 2344
Posted by GitBox <gi...@apache.org>.
moresandeep commented on a change in pull request #353:
URL: https://github.com/apache/knox/pull/353#discussion_r444113547
##########
File path: gateway-release/pom.xml
##########
@@ -439,7 +439,7 @@
</dependency>
<dependency>
<groupId>org.apache.knox</groupId>
- <artifactId>gateway-cm-integration</artifactId>
+ <artifactId>gateway-topology-hadoopxml</artifactId>
Review comment:
nit: since hadoop and xml are two different words do you think the name `gateway-topology-hadoop-xml` is more appropriate? it does look a bit long and awkward though.
##########
File path: gateway-topology-hadoopxml/pom.xml
##########
@@ -25,9 +25,9 @@
<version>1.5.0-SNAPSHOT</version>
</parent>
- <artifactId>gateway-cm-integration</artifactId>
- <name>gateway-cm-integration</name>
- <description>Cloudera Manager integration related resources</description>
+ <artifactId>gateway-topology-hadoopxml</artifactId>
+ <name>gateway-topology-hadoopxml</name>
Review comment:
Same nit as above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 commented on pull request #353: KNOX-2344 - Rename gateway-cm-integration module and related resources
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on pull request #353:
URL: https://github.com/apache/knox/pull/353#issuecomment-648159484
> Need we be concerned with backward-compatibility at all here? Was this part of the 1.4 release?
Yes, this was released in 1.4. In fact, the JIRA was an outcome of the release e-mail thread where we agreed this should be renamed but it's not a release blocker.
The module I renamed was a new feature in 1.4 and AFAIK it's only been used by someone who integrated with Cloudera Manager. This means that whoever upgrades to this version needs to make sure to rename the CM generated file(s) to end with `.hxr` instead of `.cm`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 merged pull request #353: KNOX-2344 - Rename gateway-cm-integration module and related resources
Posted by GitBox <gi...@apache.org>.
smolnar82 merged pull request #353:
URL: https://github.com/apache/knox/pull/353
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] pzampino commented on pull request #353: KNOX-2344 - Rename gateway-cm-integration module and related resources
Posted by GitBox <gi...@apache.org>.
pzampino commented on pull request #353:
URL: https://github.com/apache/knox/pull/353#issuecomment-648161548
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org