You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/05/16 23:05:43 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4214: Support
default BYTES (zero-length byte array) in aggregation function and aggregator
codecov-io commented on issue #4214: Support default BYTES (zero-length byte array) in aggregation function and aggregator
URL: https://github.com/apache/incubator-pinot/pull/4214#issuecomment-493260672
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4214?src=pr&el=h1) Report
> Merging [#4214](https://codecov.io/gh/apache/incubator-pinot/pull/4214?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/3cca15fe810b5e01fc76cc94de92749e73d656ba?src=pr&el=desc) will **increase** coverage by `0.31%`.
> The diff coverage is `55.03%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4214?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4214 +/- ##
============================================
+ Coverage 67.11% 67.43% +0.31%
Complexity 20 20
============================================
Files 1035 1035
Lines 51520 51572 +52
Branches 7220 7245 +25
============================================
+ Hits 34577 34775 +198
+ Misses 14569 14395 -174
- Partials 2374 2402 +28
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4214?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../function/DistinctCountHLLAggregationFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/4214/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9EaXN0aW5jdENvdW50SExMQWdncmVnYXRpb25GdW5jdGlvbi5qYXZh) | `35.91% <30.76%> (+5.48%)` | `0 <0> (ø)` | :arrow_down: |
| [...ion/function/PercentileEstAggregationFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/4214/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9QZXJjZW50aWxlRXN0QWdncmVnYXRpb25GdW5jdGlvbi5qYXZh) | `61.72% <36.36%> (+8.48%)` | `0 <0> (ø)` | :arrow_down: |
| [...ta/aggregator/DistinctCountHLLValueAggregator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4214/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL2FnZ3JlZ2F0b3IvRGlzdGluY3RDb3VudEhMTFZhbHVlQWdncmVnYXRvci5qYXZh) | `76.47% <50%> (-9.25%)` | `0 <0> (ø)` | |
| [...re/data/aggregator/MinMaxRangeValueAggregator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4214/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL2FnZ3JlZ2F0b3IvTWluTWF4UmFuZ2VWYWx1ZUFnZ3JlZ2F0b3IuamF2YQ==) | `88% <57.14%> (-12%)` | `0 <0> (ø)` | |
| [...pinot/core/data/aggregator/AvgValueAggregator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4214/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL2FnZ3JlZ2F0b3IvQXZnVmFsdWVBZ2dyZWdhdG9yLmphdmE=) | `86.95% <57.14%> (-13.05%)` | `0 <0> (ø)` | |
| [...function/PercentileTDigestAggregationFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/4214/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9QZXJjZW50aWxlVERpZ2VzdEFnZ3JlZ2F0aW9uRnVuY3Rpb24uamF2YQ==) | `66.26% <61.9%> (+2.97%)` | `0 <0> (ø)` | :arrow_down: |
| [.../data/aggregator/PercentileEstValueAggregator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4214/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL2FnZ3JlZ2F0b3IvUGVyY2VudGlsZUVzdFZhbHVlQWdncmVnYXRvci5qYXZh) | `87.5% <63.63%> (-12.5%)` | `0 <0> (ø)` | |
| [...ation/function/MinMaxRangeAggregationFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/4214/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9NaW5NYXhSYW5nZUFnZ3JlZ2F0aW9uRnVuY3Rpb24uamF2YQ==) | `74.44% <63.63%> (+1.18%)` | `0 <0> (ø)` | :arrow_down: |
| [...y/aggregation/function/AvgAggregationFunction.java](https://codecov.io/gh/apache/incubator-pinot/pull/4214/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9hZ2dyZWdhdGlvbi9mdW5jdGlvbi9BdmdBZ2dyZWdhdGlvbkZ1bmN0aW9uLmphdmE=) | `80.45% <63.63%> (-0.27%)` | `0 <0> (ø)` | |
| [...a/aggregator/PercentileTDigestValueAggregator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4214/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL2FnZ3JlZ2F0b3IvUGVyY2VudGlsZVREaWdlc3RWYWx1ZUFnZ3JlZ2F0b3IuamF2YQ==) | `87.5% <66.66%> (-12.5%)` | `0 <0> (ø)` | |
| ... and [39 more](https://codecov.io/gh/apache/incubator-pinot/pull/4214/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4214?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4214?src=pr&el=footer). Last update [3cca15f...c8169e4](https://codecov.io/gh/apache/incubator-pinot/pull/4214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org