You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Browning <mr...@uber.com> on 2016/04/27 02:30:59 UTC

Review Request 46717: Added sketch of fetcher cache metrics.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46717/
-----------------------------------------------------------

Review request for mesos and Bernd Mathiske.


Bugs: MESOS-4760
    https://issues.apache.org/jira/browse/MESOS-4760


Repository: mesos


Description
-------

Added sketch of fetcher cache metrics.


Diffs
-----

  src/slave/containerizer/fetcher.hpp 9e3018dc087ed55c61b2824d0105bc5339b83043 
  src/slave/containerizer/fetcher.cpp 176d8863d1becd8864218a0012ab45c614f0ad77 
  src/slave/metrics.cpp 86eb8db644227cb593e52305bfbd05444bb87a6e 
  src/slave/slave.hpp 57b18882e30e44dcc40449b0e3be8ee970c45bc8 

Diff: https://reviews.apache.org/r/46717/diff/


Testing
-------


Thanks,

Michael Browning

Re: Review Request 46717: Added sketch of fetcher cache metrics.

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46717/#review130748
-----------------------------------------------------------




src/slave/containerizer/fetcher.cpp (line 337)
<https://reviews.apache.org/r/46717/#comment194627>

    Note that we don't necessarily use the whole cache dir. The agent flag fetcher_cache_size is free to be set to a different value, a logical usage limit.


- Bernd Mathiske


On April 26, 2016, 5:30 p.m., Michael Browning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46717/
> -----------------------------------------------------------
> 
> (Updated April 26, 2016, 5:30 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4760
>     https://issues.apache.org/jira/browse/MESOS-4760
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added sketch of fetcher cache metrics.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/fetcher.hpp 9e3018dc087ed55c61b2824d0105bc5339b83043 
>   src/slave/containerizer/fetcher.cpp 176d8863d1becd8864218a0012ab45c614f0ad77 
>   src/slave/metrics.cpp 86eb8db644227cb593e52305bfbd05444bb87a6e 
>   src/slave/slave.hpp 57b18882e30e44dcc40449b0e3be8ee970c45bc8 
> 
> Diff: https://reviews.apache.org/r/46717/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Browning
> 
>