You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/02/02 02:18:27 UTC
[GitHub] [incubator-yunikorn-k8shim] wilfred-s opened a new pull request #226: [YUNIKORN-485] docker image update
wilfred-s opened a new pull request #226:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/226
The current dockerfiles use a go based image for the scheduler and some
tools. There is no need to deploy with go as part of the image.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] kingamarton commented on pull request #226: [YUNIKORN-485] docker image update
Posted by GitBox <gi...@apache.org>.
kingamarton commented on pull request #226:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/226#issuecomment-772435158
> hi @wilfred-s the changes look good to me, but can we hold on merging this before releasing v0.10?
> It should be fine, but since this changes the base image, I am not sure if we are going to run into some issues in production.
@yangwwei, I don't think it might cause any issues. We use the same alpine:latest image for the admission controller as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on pull request #226: [YUNIKORN-485] docker image update
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #226:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/226#issuecomment-775070483
We standardise on one image for the scheduler and admission controller. That we should have done earlier.
This change fixes a 1 high and 3 medium impact security issues that are part of the base image we use for the scheduler.
I would say that this is a must before we push the next release. Just that is enough to fix this.
The other images for the gang code have more than 40 high impact security issues open. We should never use them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s closed pull request #226: [YUNIKORN-485] docker image update
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #226:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/226
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #226: [YUNIKORN-485] docker image update
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #226:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/226#issuecomment-771423230
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/226?src=pr&el=h1) Report
> Merging [#226](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/226?src=pr&el=desc) (f54ba08) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/226?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #226 +/- ##
=======================================
Coverage 59.75% 59.75%
=======================================
Files 35 35
Lines 3133 3133
=======================================
Hits 1872 1872
Misses 1180 1180
Partials 81 81
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/226?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/226?src=pr&el=footer). Last update [c47ed51...f54ba08](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/226?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #226: [YUNIKORN-485] docker image update
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #226:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/226#issuecomment-771423230
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/226?src=pr&el=h1) Report
> Merging [#226](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/226?src=pr&el=desc) (f54ba08) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/c47ed51f075c5af5910f71da40e7e68699a9abae?el=desc) (c47ed51) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/226?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #226 +/- ##
=======================================
Coverage 59.75% 59.75%
=======================================
Files 35 35
Lines 3133 3133
=======================================
Hits 1872 1872
Misses 1180 1180
Partials 81 81
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/226?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/226?src=pr&el=footer). Last update [c47ed51...f54ba08](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/226?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #226: [YUNIKORN-485] docker image update
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #226:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/226#issuecomment-772723895
> > hi @wilfred-s the changes look good to me, but can we hold on merging this before releasing v0.10?
> > It should be fine, but since this changes the base image, I am not sure if we are going to run into some issues in production.
>
> @yangwwei, I don't think it might cause any issues. We use the same alpine:latest image for the admission controller as well.
Ideally, that's the case. But given we could not stabilize the v0.10 branch as far, my concern is to add this change could lead up to some risk. if not absolutely necessary, I suggest postponing this to post v0.10.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #226: [YUNIKORN-485] docker image update
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #226:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/226#issuecomment-772304750
hi @wilfred-s the changes look good to me, but can we hold on merging this before releasing v0.10?
It should be fine, but since this changes the base image, I am not sure if we are going to run into some issues in production.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s edited a comment on pull request #226: [YUNIKORN-485] docker image update
Posted by GitBox <gi...@apache.org>.
wilfred-s edited a comment on pull request #226:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/226#issuecomment-775070483
We standardise on one image for the scheduler and admission controller. That we should have done earlier.
This change fixes a 1 high and 3 medium impact security issues that are part of the base image we use for the scheduler.
I would say that this is a must before we push the next release. Just that is enough to make this a must have fix.
The other images for the gang code have more than 40 high impact security issues open. We should never use them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #226: [YUNIKORN-485] docker image update
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #226:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/226#issuecomment-775682582
> This change fixes a 1 high and 3 medium impact security issues that are part of the base image we use for the scheduler.
> I would say that this is a must before we push the next release. Just that is enough to make this a must have fix.
Make sense, approving the change. Feel free to merge it. Thanks
BTW, we need to make sure our e2e test is good after this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org