You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/01/13 09:54:35 UTC
Review Request 55488: Slimmed down the size of the docker image from
2GB to roughly 650MB.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55488/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Repository: mesos
Description
-------
See summary.
Diffs
-----
support/mesos-tidy/Dockerfile 82da813f78ccfe17812e09647cb7b3db4e279464
Diff: https://reviews.apache.org/r/55488/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 55488: Slimmed down the size of the docker image
from 2GB to roughly 650MB.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55488/
-----------------------------------------------------------
(Updated Jan. 14, 2017, 12:01 p.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Addressed Benjamin's comments.
Repository: mesos
Description (updated)
-------
Slimmed down the size of the docker image from 2GB to roughly 650MB.
Diffs (updated)
-----
support/mesos-tidy/Dockerfile 82da813f78ccfe17812e09647cb7b3db4e279464
Diff: https://reviews.apache.org/r/55488/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 55488: Slimmed down the size of the docker image
from 2GB to roughly 650MB.
Posted by Michael Park <mp...@apache.org>.
> On Jan. 13, 2017, 3:53 a.m., Benjamin Bannier wrote:
> > support/mesos-tidy/Dockerfile, lines 69-77
> > <https://reviews.apache.org/r/55488/diff/1/?file=1604404#file1604404line69>
> >
> > These packages are from the Mesos getting started guide, and I am not sure we would like to deviate here. It does save about 400MB in this layer (probably since we do not install the java packages), but we'll likely be perpetually out of sync as the Mesos cmake setup approaches the autotool setup's capabilities.
- `libev` is bundled.
- `libevent` is not, but we download it via `ExternalProject` for CMake.
- `libssl` is not supported by CMake, but I imagine we'll be taking the same approach as `libevent`. We can adjust if it changes.
- We don't build the Java stuff with CMake and frankly I don't think we care about it... so I dropped `maven` and `openjdk-8-jdk`.
Let me know if you still think I should add any of them back.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55488/#review161503
-----------------------------------------------------------
On Jan. 13, 2017, 1:54 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55488/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 1:54 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/mesos-tidy/Dockerfile 82da813f78ccfe17812e09647cb7b3db4e279464
>
> Diff: https://reviews.apache.org/r/55488/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 55488: Slimmed down the size of the docker image
from 2GB to roughly 650MB.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Jan. 13, 2017, 12:53 p.m., Benjamin Bannier wrote:
> > support/mesos-tidy/Dockerfile, lines 69-77
> > <https://reviews.apache.org/r/55488/diff/1/?file=1604404#file1604404line69>
> >
> > These packages are from the Mesos getting started guide, and I am not sure we would like to deviate here. It does save about 400MB in this layer (probably since we do not install the java packages), but we'll likely be perpetually out of sync as the Mesos cmake setup approaches the autotool setup's capabilities.
>
> Michael Park wrote:
> - `libev` is bundled.
> - `libevent` is not, but we download it via `ExternalProject` for CMake.
> - `libssl` is not supported by CMake, but I imagine we'll be taking the same approach as `libevent`. We can adjust if it changes.
> - We don't build the Java stuff with CMake and frankly I don't think we care about it... so I dropped `maven` and `openjdk-8-jdk`.
>
> Let me know if you still think I should add any of them back.
Makes sense, after all the getting started guide isn't really geared towards the cmake build; also, we can always add back stuff later.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55488/#review161503
-----------------------------------------------------------
On Jan. 13, 2017, 10:54 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55488/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 10:54 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/mesos-tidy/Dockerfile 82da813f78ccfe17812e09647cb7b3db4e279464
>
> Diff: https://reviews.apache.org/r/55488/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 55488: Slimmed down the size of the docker image
from 2GB to roughly 650MB.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55488/#review161503
-----------------------------------------------------------
Fix it, then Ship it!
support/mesos-tidy/Dockerfile
<https://reviews.apache.org/r/55488/#comment232799>
Agree that this one is better in its own section.
support/mesos-tidy/Dockerfile (lines 68 - 71)
<https://reviews.apache.org/r/55488/#comment232800>
These packages are from the Mesos getting started guide, and I am not sure we would like to deviate here. It does save about 400MB in this layer (probably since we do not install the java packages), but we'll likely be perpetually out of sync as the Mesos cmake setup approaches the autotool setup's capabilities.
support/mesos-tidy/Dockerfile (line 76)
<https://reviews.apache.org/r/55488/#comment232801>
Please wrap this
RUN apt-get install -qy \
jq \
parallel
Not yours, but it probably makes sense to terminate the command with an `apt-get clean` just for consistency (this safes almost no space for that layer).
- Benjamin Bannier
On Jan. 13, 2017, 10:54 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55488/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2017, 10:54 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> support/mesos-tidy/Dockerfile 82da813f78ccfe17812e09647cb7b3db4e279464
>
> Diff: https://reviews.apache.org/r/55488/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>