You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "Aireed (via GitHub)" <gi...@apache.org> on 2025/05/08 11:05:45 UTC
[PR] fix some doc error [amoro]
Aireed opened a new pull request, #3551:
URL: https://github.com/apache/amoro/pull/3551
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://amoro.apache.org/how-to-contribute/
2. If the PR is related to an issue in https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title, e.g., '[AMORO-XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][AMORO-XXXX] Your PR title ...'.
-->
## Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about its use case.
2. If you fix a bug, you can clarify why it is a bug.
3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related issue
-->
fix some doc error, keep same with amoro-site repo
## Brief change log
<!--
Clearly describe the changes made in modules, classes, methods, etc.
-->
-
## How was this patch tested?
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] Run test locally before making a pull request
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix some doc error [amoro]
Posted by "xxubai (via GitHub)" <gi...@apache.org>.
xxubai commented on code in PR #3551:
URL: https://github.com/apache/amoro/pull/3551#discussion_r2081307635
##########
docs/admin-guides/deployment-on-kubernetes.md:
##########
@@ -74,20 +74,7 @@ or build the `amoro-spark-optimizer` image by:
```
## Get Helm Charts
-
-You can obtain the latest official release chart by adding the official Helm repository.
-
-```shell
-$ helm repo add amoro https://netease.github.io/amoro/charts
-$ helm search repo amoro
-NAME CHART VERSION APP VERSION DESCRIPTION
-amoro/amoro 0.1.0 0.7.0 A Helm chart for Amoro
-
-$ helm pull amoro/amoro
-$ tar zxvf amoro-*.tgz
-```
-
-Alternatively, you can find the latest charts directly from the Github source code.
+You can find the latest charts directly from the Github source code.
Review Comment:
refer to a link?
##########
docs/admin-guides/deployment-on-kubernetes.md:
##########
@@ -74,20 +74,7 @@ or build the `amoro-spark-optimizer` image by:
```
## Get Helm Charts
-
-You can obtain the latest official release chart by adding the official Helm repository.
-
-```shell
-$ helm repo add amoro https://netease.github.io/amoro/charts
-$ helm search repo amoro
-NAME CHART VERSION APP VERSION DESCRIPTION
-amoro/amoro 0.1.0 0.7.0 A Helm chart for Amoro
Review Comment:
APP VERSION need to update: 0.8.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org