[GitHub] [spark] peter-toth commented on a change in pull request #31477: [SPARK-34369][SQL] Track number of pairs processed out of Join

[GitBox <gi...@apache.org>]

peter-toth commented on a change in pull request #31477:
URL: https://github.com/apache/spark/pull/31477#discussion_r577480847



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastNestedLoopJoinExec.scala
##########
@@ -89,13 +90,20 @@ case class BroadcastNestedLoopJoinExec(
     }
   }
 
-  @transient private lazy val boundCondition = {
+  private val numMatchedRows = longMetric("numMatchedRows")

Review comment:
       shouldn't this be `lazy`? otherwise `metrics` becomes non lazy...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org