[GitHub] [apisix-website] yzeng25 edited a comment on pull request #694: refactor：load images from CDN

[GitBox <gi...@apache.org>]

yzeng25 edited a comment on pull request #694:
URL: https://github.com/apache/apisix-website/pull/694#issuecomment-960573814


   > In order to load the picture from the CDN, i modified the files of blog and index.js , is there something wrong？ Is there anything else missing?
   
   Hi @Ylikj ,
   
   Sorry for the confusion. I did not specify which kind of images should be changed. It is a bit late but here is the clarification:
   
   For the `authorImageURL` part, you can just leave it as it is. If you really want to change them to CDN, please change them at the very end of this process.
   
   For images in the content of blogs, please change all of them to CDN. 
   
   And here is my suggested plan:
   
   Changing all images is indeed a long process. 
   
   I would suggest split them in multiple pull requests, and categorize them by months . For example, you can create a pull request with images changes for blogs posted in December 2020, and create another pull request with images changes for blogs posted in January 2021. In this way, it is easier for reviewers to do their jobs.
   
   You can get start changing them from `/blog/2020/12/~`, which is the earliest blogs we have on our website. Then you can go from there, continue to `/blog/2021/01/~`.
   
   As you may notice, we started to use CDN around July, 2021. So the images involved in each month may come to a peak in `/blog/2021/06/~` or `/blog/2021/07/~`, then suddenly drop a lot because of the change.
   
   Hope this clarifies your confusion, and thank you for your contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org