You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/04/20 05:49:21 UTC

[GitHub] [bookkeeper] lhotari opened a new pull request #2697: Upgrade Lombok to 1.18.20

lhotari opened a new pull request #2697:
URL: https://github.com/apache/bookkeeper/pull/2697


   ### Motivation
   
   - required for compilation on JDK 16
   - see https://projectlombok.org/changelog
   
   ### Changes
   
   Upgrade Lombok version to `1.18.20` in `pom.xml` and `dependencies.gradle`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] Ghatage merged pull request #2697: Upgrade Lombok to 1.18.20

Posted by GitBox <gi...@apache.org>.
Ghatage merged pull request #2697:
URL: https://github.com/apache/bookkeeper/pull/2697


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] dlg99 commented on pull request #2697: Upgrade Lombok to 1.18.20

Posted by GitBox <gi...@apache.org>.
dlg99 commented on pull request #2697:
URL: https://github.com/apache/bookkeeper/pull/2697#issuecomment-831494536


   I tried to merge this one and the script failed (successfully merged couple of other PRs):
   
   ./dev/bk-merge-pr3.py -> trying to merge 2697 
   
   Merge Pull Request (2697) with following details:
   ```
   ..
   } (y/n): y
   Unable to fetch URL, exiting: https://api.github.com/repos/apache/bookkeeper/pulls/2697/merge - HTTP Error 404: Not Found
   HTTP Error 404: Not Found
   ```
   > try https://api.github.com/repos/apache/bookkeeper/pulls/2697/merge
   ```
     "message": "Not Found",
     "documentation_url": "https://docs.github.com/rest/reference/pulls#check-if-a-pull-request-has-been-merged"
   ```
   
   > try  https://api.github.com/repos/apache/bookkeeper/pulls/2697
   ```
     "active_lock_reason": null,
     "merged": false,
     "mergeable": true,
     "rebaseable": true,
     "mergeable_state": "clean",
     "merged_by": null,
   ```
   everything looks fine yet merge fails at the API level?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] Ghatage commented on pull request #2697: Upgrade Lombok to 1.18.20

Posted by GitBox <gi...@apache.org>.
Ghatage commented on pull request #2697:
URL: https://github.com/apache/bookkeeper/pull/2697#issuecomment-831710088


   Hey @dlg99 dunno why you're seeing that? @hsaputra also saw something similar with the default python script.
   However, in the mean time I've merged this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [bookkeeper] Ghatage edited a comment on pull request #2697: Upgrade Lombok to 1.18.20

Posted by GitBox <gi...@apache.org>.
Ghatage edited a comment on pull request #2697:
URL: https://github.com/apache/bookkeeper/pull/2697#issuecomment-831710088


   Hey @dlg99 dunno why you're seeing that? @hsaputra also saw something similar with the default python script.
   Can you guys try and refresh your Github personal api tokens and try again next time?
   However, in the mean time I've merged this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org